From: Dmitry Osipenko <digetx@gmail.com>
To: Akhil R <akhilrajeev@nvidia.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Krishna Yarlagadda <kyarlagadda@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
Rajesh Gumasta <rgumasta@nvidia.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"vkoul@kernel.org" <vkoul@kernel.org>
Cc: Pavan Kunapuli <pkunapuli@nvidia.com>
Subject: Re: [PATCH v18 2/4] dmaengine: tegra: Add tegra gpcdma driver
Date: Thu, 3 Feb 2022 21:22:49 +0300 [thread overview]
Message-ID: <d6d70e52-a984-d973-f3bb-f70f1a4ce95d@gmail.com> (raw)
In-Reply-To: <DM5PR12MB18509939C17ABEB5EEA825FFC0289@DM5PR12MB1850.namprd12.prod.outlook.com>
03.02.2022 06:44, Akhil R пишет:
>> But why do you need to pause at all here and can't use
>> tegra_dma_stop_client() even if pause is supported?
> The recommended method to terminate a transfer in
> between is to pause the channel first and then disable it.
> This is more graceful and stable for the hardware.
> stop_client() is more abrupt, though it does the job.
If there is no real practical difference, then I'd use the common method
only. This will make code cleaner and simpler a tad.
next prev parent reply other threads:[~2022-02-03 18:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 15:26 [PATCH v18 0/4] Add NVIDIA Tegra GPC-DMA driver Akhil R
2022-02-01 15:26 ` [PATCH v18 1/4] dt-bindings: dmaengine: Add doc for tegra gpcdma Akhil R
2022-02-01 15:26 ` [PATCH v18 2/4] dmaengine: tegra: Add tegra gpcdma driver Akhil R
2022-02-02 15:45 ` Dmitry Osipenko
2022-02-03 3:44 ` Akhil R
2022-02-03 18:22 ` Dmitry Osipenko [this message]
2022-02-04 6:47 ` Akhil R
2022-02-04 12:15 ` Dmitry Osipenko
2022-02-04 12:28 ` Dmitry Osipenko
2022-02-01 15:26 ` [PATCH v18 3/4] arm64: defconfig: tegra: Enable GPCDMA Akhil R
2022-02-01 15:26 ` [PATCH v18 4/4] arm64: tegra: Add GPCDMA node for tegra186 and tegra194 Akhil R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6d70e52-a984-d973-f3bb-f70f1a4ce95d@gmail.com \
--to=digetx@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pkunapuli@nvidia.com \
--cc=rgumasta@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).