From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2747FC433EF for ; Mon, 21 Feb 2022 06:19:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345065AbiBUGTs (ORCPT ); Mon, 21 Feb 2022 01:19:48 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:59812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239052AbiBUGTr (ORCPT ); Mon, 21 Feb 2022 01:19:47 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CFF210C1; Sun, 20 Feb 2022 22:19:23 -0800 (PST) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4K2BtB2dDnz9sp9; Mon, 21 Feb 2022 14:17:38 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 21 Feb 2022 14:19:20 +0800 Received: from [10.174.178.55] (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 21 Feb 2022 14:19:18 +0800 Subject: Re: [PATCH v20 2/5] arm64: kdump: introduce some macros for crash kernel reservation To: Baoquan He CC: Thomas Gleixner , Ingo Molnar , Borislav Petkov , , "H . Peter Anvin" , , Dave Young , Vivek Goyal , Eric Biederman , , Catalin Marinas , Will Deacon , , Rob Herring , Frank Rowand , , "Jonathan Corbet" , , Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , "John Donnelly" , Dave Kleikamp References: <20220124084708.683-1-thunder.leizhen@huawei.com> <20220124084708.683-3-thunder.leizhen@huawei.com> <69da7ed5-4ef4-3655-8965-4181c7d7bf0b@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: Date: Mon, 21 Feb 2022 14:19:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022/2/21 11:22, Baoquan He wrote: > On 02/14/22 at 02:22pm, Leizhen (ThunderTown) wrote: >> >> >> On 2022/2/11 18:39, Baoquan He wrote: >>> On 01/24/22 at 04:47pm, Zhen Lei wrote: >>>> From: Chen Zhou >>>> >>>> Introduce macro CRASH_ALIGN for alignment, macro CRASH_ADDR_LOW_MAX >>>> for upper bound of low crash memory, macro CRASH_ADDR_HIGH_MAX for >>>> upper bound of high crash memory, use macros instead. >>>> >>>> Signed-off-by: Chen Zhou >>>> Signed-off-by: Zhen Lei >>>> Tested-by: John Donnelly >>>> Tested-by: Dave Kleikamp >>>> --- >>>> arch/arm64/mm/init.c | 11 ++++++++--- >>>> 1 file changed, 8 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c >>>> index 90f276d46b93bc6..6c653a2c7cff052 100644 >>>> --- a/arch/arm64/mm/init.c >>>> +++ b/arch/arm64/mm/init.c >>>> @@ -65,6 +65,12 @@ EXPORT_SYMBOL(memstart_addr); >>>> phys_addr_t arm64_dma_phys_limit __ro_after_init; >>>> >>>> #ifdef CONFIG_KEXEC_CORE >>>> +/* Current arm64 boot protocol requires 2MB alignment */ >>>> +#define CRASH_ALIGN SZ_2M >>>> + >>>> +#define CRASH_ADDR_LOW_MAX arm64_dma_phys_limit >>>> +#define CRASH_ADDR_HIGH_MAX MEMBLOCK_ALLOC_ACCESSIBLE >>> >>> MEMBLOCK_ALLOC_ACCESSIBLE is obvoiously a alloc flag for memblock >>> allocator, I don't think it's appropriate to make HIGH_MAX get its value. >> >> Right, thanks. >> >>> You can make it as memblock.current_limit, or do not define it, but using >>> MEMBLOCK_ALLOC_ACCESSIBLE direclty in memblock_phys_alloc_range() with >>> a code comment. >> >> This patch is not required at present. These macros are added to eliminate >> differences to share code with x86. > > So this patch may not be needed in this series. It can be added in > another post when you start to do the clean up and code unification > among ARCHes, with my udnerstanding. At that time you can consider how > to abstract the common code to handle the difference. Yes, it should be merged with the v20 3/5. > > . > -- Regards, Zhen Lei