From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0075C4321E for ; Mon, 5 Dec 2022 07:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231521AbiLEHbA (ORCPT ); Mon, 5 Dec 2022 02:31:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231178AbiLEHa7 (ORCPT ); Mon, 5 Dec 2022 02:30:59 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F169B10071 for ; Sun, 4 Dec 2022 23:30:57 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id f21so16295917lfm.9 for ; Sun, 04 Dec 2022 23:30:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ic6F8QFCJK13ebf9asWvu6VyveRvaroZzcFBrpHB3Nc=; b=Qq4IFm0i4P/LFoDZKUn2+/rtTIoRv5thuIbrz0XBnAyu3AEn7V2FNqZoUTfzaGV+gy BY72zOHlUP/wv1LSN/dyZJLQkhGOu5n6q43ypzUObe4hAGjjiGuyhxa8JPWr8ZzNQZZe ytN3Dhh4aPVxiitji9JQse26dzXnYQnRfN6ZeYJSKyz9wP8+513YDHI5sX/ds5IDb10E V8at/+WnV1FgKjbfkOjpB1GewQys8cDF0mWGh1S/QNBz7p94cNvD/K/l/15R4U8gV+3T f8DYACT+Jj/X22clRfhvJGMTjcKKc16vfMmPQ2XGo5W7u5LvORxeyRcngkImmvm0MBbE LBVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ic6F8QFCJK13ebf9asWvu6VyveRvaroZzcFBrpHB3Nc=; b=Ilqpq+ttFAUfP5AAVL3gwowcTYsANd3TVHAOxs3y5tWpZK96DKHo20eCX1FgdAaSII 9ejBml8jALUV1QyCLyFpuRMM0hnveO6PimxSVqRBBht56gfLGPrEoc32e46AzeQqFtW7 qGBWsVcJplKMVlfPquGKIkBo5lDBXsJE56t8fuLQxyK4tm3lGJmvHrnaaBSLdh5r7bqb 8xxRO1css9y2FEkx/nrWtAMkth/vFwnGEk2xIeNhXodiY8rYNFns0hB1qDTGl7hTuoXV pZiuwvmGzJ84n11qi3Pu2nhHZkHkJ67K31OZS1AwCIolXwpaWtUDUYomDOKGp3pV5ZqJ yb9w== X-Gm-Message-State: ANoB5pkNqQWZQxUt+cVwuI0v3B4qUnd7RX55ounR5ZLS2CfWkvL1yLlB wzbWWDz11EC4J587AbHa+XSKJA== X-Google-Smtp-Source: AA0mqf4PVweKhUkPQ+6ewoxxuSwatBKT8xqhq+m8lOVYNmSqJASY6f8sMB6+9CprV3sdvonxsW9kEA== X-Received: by 2002:ac2:50c9:0:b0:4b5:7dd6:4df5 with SMTP id h9-20020ac250c9000000b004b57dd64df5mr138521lfm.410.1670225456216; Sun, 04 Dec 2022 23:30:56 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id t26-20020a056512031a00b004a03fd4476esm2027492lfp.287.2022.12.04.23.30.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Dec 2022 23:30:55 -0800 (PST) Message-ID: Date: Mon, 5 Dec 2022 08:30:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v1 1/3] dt-bindings: watchdog: Add watchdog for StarFive To: Xingyu Wu Cc: Rob Herring , Paul Walmsley , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, Palmer Dabbelt , Albert Ou , Wim Van Sebroeck , Philipp Zabel , Samin Guo , Guenter Roeck , linux-kernel@vger.kernel.org References: <20221202093943.149674-1-xingyu.wu@starfivetech.com> <20221202093943.149674-2-xingyu.wu@starfivetech.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/12/2022 04:49, Xingyu Wu wrote: > On 2022/12/2 18:46, Krzysztof Kozlowski wrote: >> On 02/12/2022 10:39, xingu.wu wrote: >>> From: Xingyu Wu >>> >>> Add bindings to describe the watchdog for the StarFive SoCs. >>> >>> Signed-off-by: Xingyu Wu >>> --- >>> .../bindings/watchdog/starfive,wdt.yaml | 77 +++++++++++++++++++ >>> 1 file changed, 77 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml >>> new file mode 100644 >>> index 000000000000..ece3e80153a0 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml >> >> Filename should be based on compatible. You do not allow here any other >> models... If you intent and you are 100% sure you will grow with new >> models, make it maybe a family-based name. > > First, thank you for your reply. We have some other SoCs like JH7100 would use > this watchdog driver, but we now use JH7110 as our main release chip. > As you say, should we use "starfive,jh71xx-wdt.yaml" as filename? starfive,jh7110-wdt.yaml I would say because you do not expect any other models (const for compatible, not enum) Best regards, Krzysztof