From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B62C83F13 for ; Mon, 28 Aug 2023 07:16:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229511AbjH1HP5 (ORCPT ); Mon, 28 Aug 2023 03:15:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbjH1HP0 (ORCPT ); Mon, 28 Aug 2023 03:15:26 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EDD4115 for ; Mon, 28 Aug 2023 00:15:21 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-99bdcade7fbso359927166b.1 for ; Mon, 28 Aug 2023 00:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693206919; x=1693811719; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HJAzGXxVLZwUhvU/AbwqXIQG//zHq0gh5RxbohWoMzQ=; b=IAPS6RTDr+Uuos2iktTsV6YF4O0gf9AMecbKe0U1yvoJY+4RpFvnUKOeILUOzN9fZd bJwoaK97ve5ZzSZVaBaosV3ZEswi2I9AVBNzAdGbc3p4cMqN2ZhK6MRvgNcLVtJ+hSzD gE0vT4GkyZ/7FB6ZcoO8vnoE476dx1WQdvTuJHZ+Anz57RiGI1lPkcd0FSNGH2Hg5Qd+ FQhS/I9Oww6456S5v4C1Kme9W3UZOusUXKv2KHtboGIp0y9t7w5lysWwhnIvnopFWWds WztDvXU+2dsWMOyjMom12SUquq71oEeatqwgRfmeOGtqnf1uUnIBdsrONQY58Aq5bDsb VRDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693206919; x=1693811719; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HJAzGXxVLZwUhvU/AbwqXIQG//zHq0gh5RxbohWoMzQ=; b=k/aONy0L5wH9PrgInCxfvlW4V2l9zelpZUDXow0Ca+sVHkVzfGKtvxlmcnbnV2oc3B QLZ+fiRAzCXeXp4siocq/bCErORru3MLnM/ridwf1Mx70DHnh9OAYCoEL+QP+R/kwwg7 y+N2p13ZH+pwiQtkeT3CGHCz/OTDh5a3XXEQy8Uw1hGomfBiJHTYww97bjJje4D0s5jj 17w3dRauevbpyYd08AAJP3qPcGe0o8n179+csh0K4BDKW+mBGvkK8SiWJDKQb2c+ML0O QLF5CeqKKNDCWDu1vDFRRAfDmUH6r4I/R1ficaTKztEUFKqmYJjQ21EtDWhwVrefoA4Q Xlxg== X-Gm-Message-State: AOJu0Yyo1EgnFVpP+Ycu3fnOWR7lpXePqC/RcNsakmCBHDbeO3Buc7ty H6l5JnVHzdDsNmQNHkUpqjiGZ5K+gl2IOgReC5Y= X-Google-Smtp-Source: AGHT+IGKvH+GBgAKQHWDhZZV09OE+zv1MgYwJxJsoDg2/XCIHmz1dXnuC31AHBwhEWMoUKUR5gkSfQ== X-Received: by 2002:a17:906:5d:b0:9a5:846d:d823 with SMTP id 29-20020a170906005d00b009a5846dd823mr6109942ejg.45.1693206919659; Mon, 28 Aug 2023 00:15:19 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.225]) by smtp.gmail.com with ESMTPSA id fx13-20020a170906b74d00b00982be08a9besm4376385ejb.172.2023.08.28.00.15.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Aug 2023 00:15:19 -0700 (PDT) Message-ID: Date: Mon, 28 Aug 2023 09:15:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 2/4] dt-bindings: net: Add Loongson-1 Ethernet Controller Content-Language: en-US To: Serge Semin Cc: Keguang Zhang , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thomas Bogendoerfer , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Serge Semin References: <20230824125012.1040288-1-keguang.zhang@gmail.com> <20230824125012.1040288-3-keguang.zhang@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/08/2023 23:01, Serge Semin wrote: > Hi Krzysztof > > On Sun, Aug 27, 2023 at 09:56:06AM +0200, Krzysztof Kozlowski wrote: >> On 26/08/2023 23:04, Serge Semin wrote: >>>> + clock-names: >>>> + items: >>>> + - const: stmmaceth >>> >>> clock-names: >>> const: stmmaceth >>> ? >> > >> The existing syntax is correct. This is a string array. > > Could you please clarify whether it's a requirement (always specify > items: property for an array) or just an acceptable option (another > one is suggested in my comment)? I am asking because: > 1. In this case the "clock-names" array is supposed to have only one > item. Directly setting "const: stmmaceth" with no items: property > shall simplify it. > 2. There are single-entry "clock-names" property in the DT-bindings > defined as I suggested. > 3. There is a "compatible" property which is also a string array but > it can be defined as I suggested (omitting the items property). > > so based on all of that using the "items:"-based constraint here seems > redundant. Am I wrong to think like that? If so in what aspect? Syntax is correct in both cases. However the single list compatible *cannot grow*, while single list clock might, when developer notices that the binding was incomplete. People add binding matching drivers, not the hardware, thus having incomplete list of clocks is happening all the time. Best regards, Krzysztof