[PATCH 0/3] dt-bindings: phy: Fix uniphier descriptions

[PATCH 0/3] dt-bindings: phy: Fix uniphier descriptions

[Kunihiko Hayashi]

This series fixes dt-schema descriptions for USB2, USB3, and AHCI PHYs
implemented in UniPhier SoCs.

Kunihiko Hayashi (3):
  dt-bindings: phy: uniphier-usb2: Add vbus-supply
  dt-bindings: phy: uniphier-usb3ss: Treat vbus-supply as optional
  dt-bindings: phy: uniphier-ahci: Fix missing reset-names

 .../devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml   | 3 ++-
 .../devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml   | 3 +++
 .../devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml | 3 +--
 3 files changed, 6 insertions(+), 3 deletions(-)

-- 
2.25.1

[PATCH 1/3] dt-bindings: phy: uniphier-usb2: Add vbus-supply

[Kunihiko Hayashi]

UniPhier USB2 PHY controller can apply vbus-supply.
Add "vbus-supply" property to fix the following warning.

  uniphier-pro4-ace.dtb: usb-glue: phy@2: 'vbus-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
      From schema: Documentation/devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 .../devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml   | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml
index 479b203f7aa6..63dab914a48d 100644
--- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml
@@ -43,6 +43,9 @@ patternProperties:
       "#phy-cells":
         const: 0
 
+      vbus-supply:
+        description: A phandle to the regulator for USB VBUS, only for USB host
+
     required:
       - reg
       - "#phy-cells"
-- 
2.25.1

Re: [PATCH 1/3] dt-bindings: phy: uniphier-usb2: Add vbus-supply

[Krzysztof Kozlowski]

On 28/03/2022 04:05, Kunihiko Hayashi wrote:
> UniPhier USB2 PHY controller can apply vbus-supply.
> Add "vbus-supply" property to fix the following warning.
> 
>   uniphier-pro4-ace.dtb: usb-glue: phy@2: 'vbus-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
>       From schema: Documentation/devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>  .../devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml   | 3 +++
>  1 file changed, 3 insertions(+)


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

[PATCH 2/3] dt-bindings: phy: uniphier-usb3ss: Treat vbus-supply as optional

[Kunihiko Hayashi]

The usb-device doesn't need "vbus-supply" property, so the property should
be removed from required.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 .../devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml
index 92d46eb913a3..06c957d52d23 100644
--- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml
@@ -61,7 +61,7 @@ properties:
           - const: phy
 
   vbus-supply:
-    description: A phandle to the regulator for USB VBUS
+    description: A phandle to the regulator for USB VBUS, only for USB host
 
 required:
   - compatible
@@ -71,7 +71,6 @@ required:
   - clock-names
   - resets
   - reset-names
-  - vbus-supply
 
 additionalProperties: false
 
-- 
2.25.1

Re: [PATCH 2/3] dt-bindings: phy: uniphier-usb3ss: Treat vbus-supply as optional

[Krzysztof Kozlowski]

On 28/03/2022 04:05, Kunihiko Hayashi wrote:
> The usb-device doesn't need "vbus-supply" property, so the property should
> be removed from required.
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>  .../devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 3/3] dt-bindings: phy: uniphier-ahci: Fix missing reset-names

[Kunihiko Hayashi]

Add missing "phy" reset-names to fix the following warning:

  uniphier-pro4-ace.dtb: ahci-phy@10: resets: [[26, 28], [26, 12], [26, 30], [36, 0], [36, 1], [36, 2]] is too long
      From schema: Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
  uniphier-pro4-ace.dtb: ahci-phy@10: reset-names: 'oneOf' conditional failed, one must be fixed:
      ['link', 'gio', 'phy', 'pm', 'tx', 'rx'] is too long
      From schema: Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml

Fixes: 34f92b67621f ("dt-bindings: phy: uniphier-ahci: Add bindings for Pro4 SoC")
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 .../devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
index 3b400a85b44a..14f7579e7daa 100644
--- a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
@@ -43,13 +43,14 @@ properties:
 
   resets:
     minItems: 2
-    maxItems: 5
+    maxItems: 6
 
   reset-names:
     oneOf:
       - items:          # for Pro4
           - const: link
           - const: gio
+          - const: phy
           - const: pm
           - const: tx
           - const: rx
-- 
2.25.1

Re: [PATCH 3/3] dt-bindings: phy: uniphier-ahci: Fix missing reset-names

[Krzysztof Kozlowski]

On 28/03/2022 04:05, Kunihiko Hayashi wrote:
> Add missing "phy" reset-names to fix the following warning:
> 
>   uniphier-pro4-ace.dtb: ahci-phy@10: resets: [[26, 28], [26, 12], [26, 30], [36, 0], [36, 1], [36, 2]] is too long
>       From schema: Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>   uniphier-pro4-ace.dtb: ahci-phy@10: reset-names: 'oneOf' conditional failed, one must be fixed:
>       ['link', 'gio', 'phy', 'pm', 'tx', 'rx'] is too long
>       From schema: Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml

There is no ahci-phy in current sources...

> 
> Fixes: 34f92b67621f ("dt-bindings: phy: uniphier-ahci: Add bindings for Pro4 SoC")
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>  .../devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml   | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> index 3b400a85b44a..14f7579e7daa 100644
> --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> @@ -43,13 +43,14 @@ properties:
>  
>    resets:
>      minItems: 2
> -    maxItems: 5
> +    maxItems: 6
>  
>    reset-names:
>      oneOf:

As a separate commit, this oneOf should be converted into allOf:if:then:
cases which will enforce the resets per compatible.

Can you do that as well?

>        - items:          # for Pro4
>            - const: link
>            - const: gio
> +          - const: phy
>            - const: pm
>            - const: tx
>            - const: rx

Best regards,
Krzysztof

Re: [PATCH 3/3] dt-bindings: phy: uniphier-ahci: Fix missing reset-names

[Kunihiko Hayashi]

Hi Krzysztof,

Thank you for reviewing.

On 2022/03/29 3:58, Krzysztof Kozlowski wrote:
> On 28/03/2022 04:05, Kunihiko Hayashi wrote:
>> Add missing "phy" reset-names to fix the following warning:
>>
>>    uniphier-pro4-ace.dtb: ahci-phy@10: resets: [[26, 28], [26, 12], [26,
>> 30], [36, 0], [36, 1], [36, 2]] is too long
>>        From schema:
>> Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>    uniphier-pro4-ace.dtb: ahci-phy@10: reset-names: 'oneOf' conditional
>> failed, one must be fixed:
>>        ['link', 'gio', 'phy', 'pm', 'tx', 'rx'] is too long
>>        From schema:
>> Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> 
> There is no ahci-phy in current sources...

Oops, I'm going to add ahci controller to the existing devicetree,
but not yet. I shouldn't write the future warning in the commit message,
so I'll fix it.

>>
>> Fixes: 34f92b67621f ("dt-bindings: phy: uniphier-ahci: Add bindings for
>> Pro4 SoC")
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>>   .../devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml   | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>> b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>> index 3b400a85b44a..14f7579e7daa 100644
>> ---
>> a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>> +++
>> b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>> @@ -43,13 +43,14 @@ properties:
>>
>>     resets:
>>       minItems: 2
>> -    maxItems: 5
>> +    maxItems: 6
>>
>>     reset-names:
>>       oneOf:
> 
> As a separate commit, this oneOf should be converted into allOf:if:then:
> cases which will enforce the resets per compatible.
> 
> Can you do that as well?

Ok, I've found some examples using "allOf:if:them:" cases,
so I'll try to convert it with another commit.

Thank you,

---
Best Regards
Kunihiko Hayashi

Re: [PATCH 3/3] dt-bindings: phy: uniphier-ahci: Fix missing reset-names

[Krzysztof Kozlowski]

On 29/03/2022 12:55, Kunihiko Hayashi wrote:
> Hi Krzysztof,
> 
> Thank you for reviewing.
> 
> On 2022/03/29 3:58, Krzysztof Kozlowski wrote:
>> On 28/03/2022 04:05, Kunihiko Hayashi wrote:
>>> Add missing "phy" reset-names to fix the following warning:
>>>
>>>    uniphier-pro4-ace.dtb: ahci-phy@10: resets: [[26, 28], [26, 12], [26,
>>> 30], [36, 0], [36, 1], [36, 2]] is too long
>>>        From schema:
>>> Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>>    uniphier-pro4-ace.dtb: ahci-phy@10: reset-names: 'oneOf' conditional
>>> failed, one must be fixed:
>>>        ['link', 'gio', 'phy', 'pm', 'tx', 'rx'] is too long
>>>        From schema:
>>> Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>
>> There is no ahci-phy in current sources...
> 
> Oops, I'm going to add ahci controller to the existing devicetree,
> but not yet. I shouldn't write the future warning in the commit message,
> so I'll fix it.
> 
>>>
>>> Fixes: 34f92b67621f ("dt-bindings: phy: uniphier-ahci: Add bindings for
>>> Pro4 SoC")
>>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>>> ---
>>>   .../devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml   | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>> b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>> index 3b400a85b44a..14f7579e7daa 100644
>>> ---
>>> a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>> +++
>>> b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>> @@ -43,13 +43,14 @@ properties:
>>>
>>>     resets:
>>>       minItems: 2
>>> -    maxItems: 5
>>> +    maxItems: 6
>>>
>>>     reset-names:
>>>       oneOf:
>>
>> As a separate commit, this oneOf should be converted into allOf:if:then:
>> cases which will enforce the resets per compatible.
>>
>> Can you do that as well?
> 
> Ok, I've found some examples using "allOf:if:them:" cases,
> so I'll try to convert it with another commit.
> 

For an example, you can take a look at (linux-next):
Documentation/devicetree/bindings/clock/samsung,exynos7885-clock.yaml

and clocks/clock-names properties.


Best regards,
Krzysztof

Re: [PATCH 3/3] dt-bindings: phy: uniphier-ahci: Fix missing reset-names

[Kunihiko Hayashi]

Hi Krzysztof,

On 2022/03/29 20:45, Krzysztof Kozlowski wrote:
> On 29/03/2022 12:55, Kunihiko Hayashi wrote:
>> Hi Krzysztof,
>>
>> Thank you for reviewing.
>>
>> On 2022/03/29 3:58, Krzysztof Kozlowski wrote:
>>> On 28/03/2022 04:05, Kunihiko Hayashi wrote:
>>>> Add missing "phy" reset-names to fix the following warning:
>>>>
>>>>     uniphier-pro4-ace.dtb: ahci-phy@10: resets: [[26, 28], [26, 12], [26,
>>>> 30], [36, 0], [36, 1], [36, 2]] is too long
>>>>         From schema:
>>>> Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>>>     uniphier-pro4-ace.dtb: ahci-phy@10: reset-names: 'oneOf' conditional
>>>> failed, one must be fixed:
>>>>         ['link', 'gio', 'phy', 'pm', 'tx', 'rx'] is too long
>>>>         From schema:
>>>> Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>>
>>> There is no ahci-phy in current sources...
>>
>> Oops, I'm going to add ahci controller to the existing devicetree,
>> but not yet. I shouldn't write the future warning in the commit message,
>> so I'll fix it.
>>
>>>>
>>>> Fixes: 34f92b67621f ("dt-bindings: phy: uniphier-ahci: Add bindings for
>>>> Pro4 SoC")
>>>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>>>> ---
>>>>    .../devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml   | 3 ++-
>>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>>> b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>>> index 3b400a85b44a..14f7579e7daa 100644
>>>> ---
>>>> a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>>> +++
>>>> b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>>> @@ -43,13 +43,14 @@ properties:
>>>>
>>>>      resets:
>>>>        minItems: 2
>>>> -    maxItems: 5
>>>> +    maxItems: 6
>>>>
>>>>      reset-names:
>>>>        oneOf:
>>>
>>> As a separate commit, this oneOf should be converted into allOf:if:then:
>>> cases which will enforce the resets per compatible.
>>>
>>> Can you do that as well?
>>
>> Ok, I've found some examples using "allOf:if:them:" cases,
>> so I'll try to convert it with another commit.
>>
> 
> For an example, you can take a look at (linux-next):
> Documentation/devicetree/bindings/clock/samsung,exynos7885-clock.yaml
> 
> and clocks/clock-names properties.

Thanks for your suggestion.
I understand how to write it and am trying to convert the *-names to this case.

I also found such cases and some mistakes in the other phys (usb3 and pcie),
so I'll fix and resend them next.

Thank you,

---
Best Regards
Kunihiko Hayashi