Re: [PATCH 3/3] arm64: dts: qcom: sdm630: Add support for modem remoteproc

[Konrad Dybcio <konrad.dybcio@linaro.org>]

On 4.06.2023 08:14, Alexey Minnekhanov wrote:
> Modem subsystem in SDM630/660 is similar to MSM8998 and
> device tree node for it is based on the one from msm8998.dtsi.
> 
> Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm630.dtsi | 57 ++++++++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> index 5c4086d2fa99c..5e68972d48fb4 100644
> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> @@ -1026,6 +1026,63 @@ data-pins {
>  			};
>  		};
>  
> +		remoteproc_mss: remoteproc@4080000 {
> +			compatible = "qcom,sdm660-mss-pil";
> +			reg = <0x04080000 0x100>, <0x04180000 0x40>;
> +			reg-names = "qdsp6", "rmb";
> +
> +			interrupts-extended =
> +				<&intc GIC_SPI 448 IRQ_TYPE_EDGE_RISING>,
> +				<&modem_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
> +				<&modem_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
> +				<&modem_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
> +				<&modem_smp2p_in 3 IRQ_TYPE_EDGE_RISING>,
> +				<&modem_smp2p_in 7 IRQ_TYPE_EDGE_RISING>;
Please remove the \n\t\t\t after = and align them to the first entry

> +			interrupt-names = "wdog", "fatal", "ready",
> +					"handover", "stop-ack",
> +					"shutdown-ack";
Please turn this and clock-names into vertical lists with one
entry per line

> +
> +			clocks = <&gcc GCC_MSS_CFG_AHB_CLK>,
> +				<&gcc GCC_BIMC_MSS_Q6_AXI_CLK>,
And these too, align them with a space.


looks good otherwise!

Konrad
> +				<&gcc GCC_BOOT_ROM_AHB_CLK>,
> +				<&gcc GPLL0_OUT_MSSCC>,
> +				<&gcc GCC_MSS_SNOC_AXI_CLK>,
> +				<&gcc GCC_MSS_MNOC_BIMC_AXI_CLK>,
> +				<&rpmcc RPM_SMD_QDSS_CLK>,
> +				<&rpmcc RPM_SMD_XO_CLK_SRC>;
> +			clock-names = "iface", "bus", "mem", "gpll0_mss",
> +				"snoc_axi", "mnoc_axi", "qdss", "xo";
> +
> +			qcom,smem-states = <&modem_smp2p_out 0>;
> +			qcom,smem-state-names = "stop";
> +
> +			resets = <&gcc GCC_MSS_RESTART>;
> +			reset-names = "mss_restart";
> +
> +			qcom,halt-regs = <&tcsr_regs_1 0x3000 0x5000 0x4000>;
> +
> +			power-domains = <&rpmpd SDM660_VDDCX>,
> +					<&rpmpd SDM660_VDDMX>;
> +			power-domain-names = "cx", "mx";
> +
> +			status = "disabled";
> +
> +			mba {
> +				memory-region = <&mba_region>;
> +			};
> +
> +			mpss {
> +				memory-region = <&mpss_region>;
> +			};
> +
> +			glink-edge {
> +				interrupts = <GIC_SPI 452 IRQ_TYPE_EDGE_RISING>;
> +				label = "modem";
> +				qcom,remote-pid = <1>;
> +				mboxes = <&apcs_glb 15>;
> +			};
> +		};
> +
>  		adreno_gpu: gpu@5000000 {
>  			compatible = "qcom,adreno-508.0", "qcom,adreno";
>