From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: <robh+dt@kernel.org>, <amelie.delaunay@foss.st.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<fabien.dessenne@foss.st.com>
Subject: Re: [PATCH] ARM: dts: stm32: fix stusb1600 pinctrl used on stm32mp157c-dk
Date: Mon, 29 Nov 2021 14:13:14 +0100 [thread overview]
Message-ID: <d716a6a6-549f-c790-d1a1-b48c29d6ef00@foss.st.com> (raw)
In-Reply-To: <1637926420-5116-1-git-send-email-fabrice.gasnier@foss.st.com>
Hi Fabrice
On 11/26/21 12:33 PM, Fabrice Gasnier wrote:
> A pinctrl handle is used to setup a pull-up on the stusb1600 IRQ pin (that
> is open drain).
> When in ANALOG state, no pull-up can be applied in the GPIO HW controller,
> still the setting is done into the register. The pull-up is effective
> currently, only when the GPIO IRQ is requested. The correct setting is to
> use directly the GPIO, instead of ANALOG state.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> ---
> arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> index 5f060fe..3b65130 100644
> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> @@ -1718,7 +1718,7 @@
>
> stusb1600_pins_a: stusb1600-0 {
> pins {
> - pinmux = <STM32_PINMUX('I', 11, ANALOG)>;
> + pinmux = <STM32_PINMUX('I', 11, GPIO)>;
> bias-pull-up;
> };
> };
>
Applied on stm32-next
Regards
Alex
prev parent reply other threads:[~2021-11-29 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 11:33 [PATCH] ARM: dts: stm32: fix stusb1600 pinctrl used on stm32mp157c-dk Fabrice Gasnier
2021-11-29 13:13 ` Alexandre TORGUE [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d716a6a6-549f-c790-d1a1-b48c29d6ef00@foss.st.com \
--to=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabien.dessenne@foss.st.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).