From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B9AC433EF for ; Mon, 29 Nov 2021 13:15:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377589AbhK2NSx (ORCPT ); Mon, 29 Nov 2021 08:18:53 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:42976 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235896AbhK2NQx (ORCPT ); Mon, 29 Nov 2021 08:16:53 -0500 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AT8gB0U015642; Mon, 29 Nov 2021 14:13:16 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=sqMNcoQwpA9ck+7HZwoMAo0dG2+QpAolRg6WzPlAIKI=; b=QUDV4Oyu5hgi3RtaH24ANImYc7CEO15DHaQfwhQDcTw94rpXvYxwV3MXaQfBY5ibsI3a o/Y70SCbVBcFhwTwNNVJpXyW+FU+hOHs3HGU4RR58+YhFlBDz9N9AlMJErL5Szp6BTbj tsLtsvLUOhxByTGdVLrvhqxaLnj3RWtcErcjCWCDA/cWMzI6HYYk/4wZOXTcKXY7J0v6 G0O6pHdgJBGQdc4lrGZ9B3y7QnUzKlTG0IQCRiCt7FkQctIQ5b3jJ2Hv9oLPAf63/z40 z7uUOjOrei51DtLHbjzBKR0HM6/wsZ1dtEcN1jZiM+q6DI0Frbg6N3Q9b8iO24TLkHMW Tg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3cmn1ybces-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Nov 2021 14:13:16 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 641F910002A; Mon, 29 Nov 2021 14:13:15 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 58A68218100; Mon, 29 Nov 2021 14:13:15 +0100 (CET) Received: from lmecxl0912.lme.st.com (10.75.127.47) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Mon, 29 Nov 2021 14:13:14 +0100 Subject: Re: [PATCH] ARM: dts: stm32: fix stusb1600 pinctrl used on stm32mp157c-dk To: Fabrice Gasnier CC: , , , , , , References: <1637926420-5116-1-git-send-email-fabrice.gasnier@foss.st.com> From: Alexandre TORGUE Message-ID: Date: Mon, 29 Nov 2021 14:13:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <1637926420-5116-1-git-send-email-fabrice.gasnier@foss.st.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG1NODE3.st.com (10.75.127.3) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-29_08,2021-11-28_01,2020-04-07_01 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Fabrice On 11/26/21 12:33 PM, Fabrice Gasnier wrote: > A pinctrl handle is used to setup a pull-up on the stusb1600 IRQ pin (that > is open drain). > When in ANALOG state, no pull-up can be applied in the GPIO HW controller, > still the setting is done into the register. The pull-up is effective > currently, only when the GPIO IRQ is requested. The correct setting is to > use directly the GPIO, instead of ANALOG state. > > Signed-off-by: Fabrice Gasnier > --- > arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi > index 5f060fe..3b65130 100644 > --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi > +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi > @@ -1718,7 +1718,7 @@ > > stusb1600_pins_a: stusb1600-0 { > pins { > - pinmux = ; > + pinmux = ; > bias-pull-up; > }; > }; > Applied on stm32-next Regards Alex