Re: [PATCH v2 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Georg Gottleuber <g.gottleuber@tuxedocomputers.com>]

Am 06.11.25 um 13:56 schrieb Georg Gottleuber:
> 
> 
> Am 06.11.25 um 09:15 schrieb Krzysztof Kozlowski:
>> On 05/11/2025 16:41, Georg Gottleuber wrote:
>>> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
>>> Snapdragon X Elite SoC (X1E78100).
>>>
>>> Changes in v2:
>>> - Rebase to v6.18-rc4/master
>>> - Add support for accelerated video decoding
>>> - Add support for audio (speakers, microphones, headset)
>>> - Add support for Bluetooth
>>> - Add support for camera
>>> - Add support for fingerprint reader
>>> - Add support for HDMI-A port
>>> - Add support for QSEECOM
>>> - Add support for USB Type-A
>>> - Add support for USB-C DP altmode
>>> - Add ASL Xiamen Technology Co. Ltd. vendor prefix
>>> - Add TUXEDO vendor prefix
>>> - Add cover letter
>>> - Removal of pointless comments
>>> - Coding style fixes
>>> - Spell check
>>>
>>> The device tree uses the dtschema from Linaro qcom-laptops [1].
>>
>> No, it cannot. You must work on mainline.
>>
>> Specifically, you must use mainline dtschema and I do not understand why
>> you choose it from some 3rd party repo. See writing-schema how to
>> install main dtschema package.
> 
> I am building and testing with mainline dtschema, but checking this dts
> with 'make CHECK_DTBS=y qcom/x1e80100-tuxedo-elite-14-gen1.dtb' has
> revealed that one property was unevaluated (output: 'data-lanes' was
> unexpected [see line 1461]).
> 
> This data-lane property is described in the following commit
> https://gitlab.com/Linaro/arm64-laptops/linux/-/commit/3d106a8ac261f81e48e4ee2a31b7484d863e0a4a
> 
> Due to the warning from the check tool, I just wanted to point out this
> commit.

Sorry for not getting that right in my first reply. This commit from
Linaro was also posted to the lkml:

https://lore.kernel.org/all/20251006-topic-x1e80100-hdmi-v5-1-c006311d59d7@linaro.org/

I will include this requirement in the cover letter.
Thanks for the review.

Regards,
Georg