From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
robdclark@gmail.com, quic_abhinavk@quicinc.com,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
quic_mkrishn@quicinc.com, linux-arm-msm@vger.kernel.org
Cc: Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC
Date: Tue, 8 Nov 2022 22:15:11 +0100 [thread overview]
Message-ID: <d721d484-84d3-f380-3bbc-43dad139bdee@linaro.org> (raw)
In-Reply-To: <aeb59d3c-34d0-f00a-bfc3-524cd03acb71@linaro.org>
On 08/11/2022 13:46, Dmitry Baryshkov wrote:
> On 08/11/2022 02:56, Bryan O'Donoghue wrote:
>> Currently we do not differentiate between the various users of the
>> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one
>> compatible string but, the hardware does have some significant differences
>> in the number of clocks.
>>
>> To facilitate documenting the clocks add the following compatible strings
>>
>> - qcom,mdss-dsi-ctrl-apq8064
>
> Generic comment: I think we'd better follow the arm/qcom-soc.yaml and
> use qcom,soc-something as compat string. This would leave us with
> qcom,apq8064-dsi-ctrl
That's a requirement. Only existing patterns are allowed to continue,
but here all there is no such pattern.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-08 21:15 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221107235654.1769462-1-bryan.odonoghue@linaro.org>
2022-11-07 23:56 ` [PATCH v2 01/18] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint Bryan O'Donoghue
2022-11-08 21:10 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 03/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in Bryan O'Donoghue
2022-11-08 12:59 ` Dmitry Baryshkov
2022-11-08 14:42 ` Bryan O'Donoghue
2022-11-08 16:55 ` Dmitry Baryshkov
2022-11-08 21:12 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 04/18] dt-bindings: msm: dsi-controller-main: Fix clock declarations Bryan O'Donoghue
2022-11-08 13:00 ` Dmitry Baryshkov
2022-11-07 23:56 ` [PATCH v2 05/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock Bryan O'Donoghue
2022-11-08 13:01 ` Dmitry Baryshkov
2022-11-08 21:12 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 06/18] dt-bindings: msm: dsi-controller-main: Alphanumerically sort compatible enum Bryan O'Donoghue
2022-11-08 21:13 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC Bryan O'Donoghue
2022-11-08 12:46 ` Dmitry Baryshkov
2022-11-08 21:15 ` Krzysztof Kozlowski [this message]
2022-11-18 13:29 ` Bryan O'Donoghue
2022-11-18 13:30 ` Dmitry Baryshkov
2022-11-07 23:56 ` [PATCH v2 08/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis Bryan O'Donoghue
2022-11-08 12:43 ` Dmitry Baryshkov
2022-11-08 12:45 ` Bryan O'Donoghue
2022-11-08 21:19 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 09/18] ARM: dts: qcom: apq8064: add compat qcom,mdss-dsi-ctrl-apq8064 Bryan O'Donoghue
2022-11-08 13:22 ` David Heidelberg
2022-11-07 23:56 ` [PATCH v2 10/18] ARM: dts: qcom: msm8974: Add compat qcom,mdss-dsi-ctrl-msm8974 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 11/18] arm64: dts: qcom: msm8916: Add compat qcom,mdss-dsi-ctrl-msm8916 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 12/18] arm64: dts: qcom: msm8996: Add compat qcom,mdss-dsi-ctrl-msm8996 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 13/18] arm64: dts: qcom: sc7180: Add compat qcom,mdss-dsi-ctrl-sc7180 Bryan O'Donoghue
2022-11-08 0:24 ` Doug Anderson
2022-11-08 12:16 ` Bryan O'Donoghue
2022-11-08 16:41 ` Doug Anderson
2022-11-07 23:56 ` [PATCH v2 14/18] arm64: dts: qcom: sc7280: Add compat qcom,mdss-dsi-ctrl-sc7280 Bryan O'Donoghue
2022-11-08 16:41 ` Doug Anderson
2022-11-07 23:56 ` [PATCH v2 15/18] arm64: dts: qcom: sdm630: Add compat qcom,mdss-dsi-ctrl-sdm630 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 16/18] arm64: dts: qcom: sdm660: Add compat qcom,mdss-dsi-ctrl-sdm660 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 17/18] arm64: dts: qcom: sdm845: Add compat qcom,mdss-dsi-ctrl-sdm845 Bryan O'Donoghue
2022-11-08 16:42 ` Doug Anderson
2022-11-07 23:56 ` [PATCH v2 18/18] arm64: dts: qcom: sm8250: Add compat qcom,mdss-dsi-ctrl-sm8250 Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d721d484-84d3-f380-3bbc-43dad139bdee@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@gmail.com \
--cc=bryan.odonoghue@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).