From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26065C43217 for ; Mon, 21 Nov 2022 12:05:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230047AbiKUMFy (ORCPT ); Mon, 21 Nov 2022 07:05:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230127AbiKUMFx (ORCPT ); Mon, 21 Nov 2022 07:05:53 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7CD948771 for ; Mon, 21 Nov 2022 04:05:50 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id c1so18499581lfi.7 for ; Mon, 21 Nov 2022 04:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U8lk1yGk+k1jHpBFenfM0E1QDY7dO/CdbSlBNPwvv7M=; b=LL2WCbIR4i1mBwmicLqdPhaaBHpYS/pB5qx+cDvQyMuNImKhaeHSKN4omMeoJ5yVs0 Bc0qnjoCinSjOLLI+Xz69fG8Y9IZywlwyuMXExxYZJKUIOZgUU3ga/ksFGy97ZdaSqGs uyimQZEaLtBUPrQKUpf3phHBqqo5DFqD+PppswTgSXfomx3jmkzvzkq3yA3/WKi4Q0TU sDuS0pkMc0jZpteQBU2Oere/jW1quENeLtv1tXGyFB1wNMkht39QMzrUditBGZLQDfyS cZY02SjnAiKrfdlRVHWVXkrFybqik6oM1Dm0+3G8Oh5xRtUP7ri0zrxYeqCGvtoUxpot QQnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U8lk1yGk+k1jHpBFenfM0E1QDY7dO/CdbSlBNPwvv7M=; b=27krr6Ape2vkGdxUKsR2+ex9WgRhBEFrv1ZVQwT1E1lZhrKhf1ED1Rd3d8Qe05RxLN UeHWsgYDHOIR4CLbpAFXF+J8/QzZAkETY2+wV6E2rb6Ikxx6Nn9DMuQEUKJcmidKMfMQ BSLksTW2VLE06y4dEzyqzIyPG48uA/m3DnryMe7clmGXW20Wiutg1GwcVAlrjI/dk0di DK+5JAszQiwViUJZ2JTfsb19sk6k7b2N+MJzcnZbzmEaoFEJFvaNZbSLgxJnNce5T6Yq TVYJiBrWpXo3PDwyhmEt9wZory8fPs1f70wv9udCSxFcnkqHv8L5xIZN3oqug6Nsmy9F TULQ== X-Gm-Message-State: ANoB5plx7KgwPt4SaogLmCgL5MZV9v2ZRHp25vwsA1ZtRT8AjTY019YX Jpi+7dx7DxSEL54Mh/yB/K/c+A== X-Google-Smtp-Source: AA0mqf4A51rPoijgjuQKSdOsv/cU3hGnDdJXXaLypfldqje/5jUfbTIYx0C/yihusXwzzxxaT054kw== X-Received: by 2002:ac2:5dea:0:b0:4b2:2cff:8446 with SMTP id z10-20020ac25dea000000b004b22cff8446mr5881122lfq.572.1669032348998; Mon, 21 Nov 2022 04:05:48 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id y3-20020a197503000000b004b4b5bd8d02sm1981733lfe.78.2022.11.21.04.05.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 04:05:48 -0800 (PST) Message-ID: Date: Mon, 21 Nov 2022 13:05:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/6] dt-bindings: PCI: Add PCIe controller bindings for FSD Content-Language: en-US To: Shradha Todi , bhelgaas@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, kishon@ti.com, vkoul@kernel.org, lpieralisi@kernel.org, kw@linux.com, mani@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, alim.akhtar@samsung.com, ajaykumar.rs@samsung.com, rcsekar@samsung.com, sriranjani.p@samsung.com, bharat.uppal@samsung.com, s.prashar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, p.rajanbabu@samsung.com, niyas.ahmed@samsung.com, chanho61.park@samsung.com Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20221121105210.68596-1-shradha.t@samsung.com> <20221121105210.68596-3-shradha.t@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20221121105210.68596-3-shradha.t@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/11/2022 11:52, Shradha Todi wrote: > Document the PCIe controller device tree bindings for Subject: drop second, redundant "bindings". > Tesla FSD SoC for both RC and EP Full stop. > > Signed-off-by: Shradha Todi > --- > .../bindings/pci/tesla,pcie-fsd-ep.yaml | 107 ++++++++++++++++ > .../bindings/pci/tesla,pcie-fsd.yaml | 117 ++++++++++++++++++ > 2 files changed, 224 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/tesla,pcie-fsd-ep.yaml > create mode 100644 Documentation/devicetree/bindings/pci/tesla,pcie-fsd.yaml > > diff --git a/Documentation/devicetree/bindings/pci/tesla,pcie-fsd-ep.yaml b/Documentation/devicetree/bindings/pci/tesla,pcie-fsd-ep.yaml > new file mode 100644 > index 000000000000..07308cb9a35c > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/tesla,pcie-fsd-ep.yaml Filename based on compatible. > @@ -0,0 +1,107 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/tesla,pcie-fsd-ep.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Synopsys DesignWare based PCIe EP controller on FSD SoCs > + > +maintainers: > + - Shradha Todi > + > +description: | > + FSD PCIe EP controller is based on Synopsys DesignWare PCIe IP > + and thus inherits all the common properties defined in > + snps,dw-pcie-ep.yaml. The controller instance is dual mode and > + can work in Root port mode or Endpoint mode at a time. > + > +allOf: > + - $ref: /schemas/pci/snps,dw-pcie-ep.yaml# > + > +properties: > + compatible: > + enum: > + - tesla,fsd-pcie-ep > + > + reg: > + items: > + - description: controller's application logic registers > + - description: controller's own configuration registers > + are available. > + - description: controller's own configuration shadow registers > + are available. > + - description: Map the remote Root Complex slave address space > + > + reg-names: > + items: > + - const: appl > + - const: dbi > + - const: dbi2 > + - const: addr_space > + > + clocks: > + items: > + - description: Auxiliary clock for PCIe > + - description: AHB clock for PCIe dbi > + - description: AHB clock for PCIe master > + - description: AHB clock for PCIe slave > + > + clock-names: > + items: > + - const: aux_clk > + - const: dbi_clk > + - const: mstr_clk > + - const: slv_clk Drop "_clk" everywhere. > + > + interrupts: > + items: > + - description: Controller interrupt > + > + interrupt-names: > + items: > + - const: sub_ctrl_intr Drop entire property. > + > + tesla,pcie-sysreg: > + $ref: '/schemas/types.yaml#/definitions/phandle-array' Drop quotes. In the PHY patch you said it is one phandle. Here it is an array. If it is an array, then define it properly: https://elixir.bootlin.com/linux/v5.18-rc1/source/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml#L42 > + description: phandle for system control registers, used to > + control signals at system level > + > +required: > + Drop blank line. > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - ranges > + - num-lanes > + - tesla,pcie-sysreg > + > +additionalProperties: true This must be false. Did you see such code anywhere in existing bindings? Maybe you meant unevaluatedProperties? > + > +examples: > + - | > + #include > + #include > + > + pcie4_ep: pcie-ep@15400000 { > + compatible = "tesla,fsd-pcie-ep"; > + clocks = <&clock_fsys0 PCIE_SUBCTRL_INST0_AUX_CLK_SOC>, > + <&clock_fsys0 PCIE_SUBCTRL_INST0_DBI_ACLK_SOC>, > + <&clock_fsys0 PCIE_SUBCTRL_INST0_MSTR_ACLK_SOC>, > + <&clock_fsys0 PCIE_SUBCTRL_INST0_SLV_ACLK_SOC>; > + clock-names = "aux_clk", "dbi_clk", "mstr_clk", "slv_clk"; > + interrupts = ; > + interrupt-names = "sub_ctrl_intr"; > + reg = <0x15090000 0x1000>, reg is a second property. > + <0x15400000 0x1000>, > + <0x15401000 0x80>, > + <0x15800000 0xFF0000>; Lowercase hex. > + reg-names = "appl", "dbi", "dbi2", "addr_space"; > + num-lanes = <4>; > + tesla,pcie-sysreg = <&sysreg_fsys0 0x434>; > + phys = <&pcie_phy0>; > + phy-names = "pcie_phy0"; > + status = "disabled"; No status. > + }; > +... > diff --git a/Documentation/devicetree/bindings/pci/tesla,pcie-fsd.yaml b/Documentation/devicetree/bindings/pci/tesla,pcie-fsd.yaml > new file mode 100644 > index 000000000000..85648e5c7d27 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/tesla,pcie-fsd.yaml All comments apply here as well. > @@ -0,0 +1,117 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > + > +$id: http://devicetree.org/schemas/pci/tesla,pcie-fsd.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Synopsys DesignWare based PCIe controller on FSD SoCs > + > +maintainers: > + - Shradha Todi > + > +description: | > + FSD PCIe controller is based on Synopsys DesignWare PCIe IP > + and thus inherits all the common properties defined in > + designware-pcie.txt. > + > +allOf: > + - $ref: /schemas/pci/snps,dw-pcie.yaml# > + > +properties: > + compatible: > + const: tesla,fsd-pcie > + > + reg: > + items: > + - description: controller's application logic registers > + - description: controller's own configuration registers > + are available. > + - description: configuration registers > + > + reg-names: > + items: > + - const: appl > + - const: dbi > + - const: config > + > + clocks: > + items: > + - description: Auxiliary clock for PCIe > + - description: AHB clock for PCIe dbi > + - description: AHB clock for PCIe master > + - description: AHB clock for PCIe slave > + > + clock-names: > + items: > + - const: aux_clk > + - const: dbi_clk > + - const: mstr_clk > + - const: slv_clk > + > + interrupts: > + minItems: 1 > + items: > + - description: MSI interrupt > + - description: Controller interrupt > + > + interrupt-names: > + minItems: 1 > + items: > + - const: msi > + - const: sub_ctrl_intr Drop "_intr" > + > + tesla,pcie-sysreg: > + $ref: '/schemas/types.yaml#/definitions/phandle-array' > + description: phandle for system control registers, used to > + control signals at system level > + > +required: > + ? > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - ranges > + - num-lanes > + - tesla,pcie-sysreg > + > +additionalProperties: true false > + > +examples: > + - | > + #include > + #include > + > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + > + pcie4_rc: pcie@15400000 { > + compatible = "tesla,fsd-pcie"; > + clocks = <&clock_fsys0 PCIE_SUBCTRL_INST0_AUX_CLK_SOC>, > + <&clock_fsys0 PCIE_SUBCTRL_INST0_DBI_ACLK_SOC>, > + <&clock_fsys0 PCIE_SUBCTRL_INST0_MSTR_ACLK_SOC>, > + <&clock_fsys0 PCIE_SUBCTRL_INST0_SLV_ACLK_SOC>; > + clock-names = "aux_clk", "dbi_clk", "mstr_clk", "slv_clk"; > + #address-cells = <3>; > + #size-cells = <2>; > + dma-coherent; > + interrupts = ; > + interrupt-names = "msi"; > + num-lanes = <4>; > + reg = <0x0 0x15090000 0x0 0x1000>, > + <0x0 0x15400000 0x0 0x1000>, > + <0x0 0x15800000 0x0 0x1000>; reg is always second. reg-names in such case third. ranges fourth. > + reg-names = "appl", "dbi", "config"; Best regards, Krzysztof