devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 12/14] arm64: dts: qcom: msm8996: Remove AGGRE2 clock from SLPI
  2023-09-12 13:31 [PATCH v2 00/14] Clean up RPM bus clocks remnants Konrad Dybcio
@ 2023-09-12 13:31 ` Konrad Dybcio
  0 siblings, 0 replies; 2+ messages in thread
From: Konrad Dybcio @ 2023-09-12 13:31 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Mathieu Poirier, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
	Sibi Sankar, Will Deacon, Robin Murphy, Joerg Roedel,
	Greg Kroah-Hartman, Wesley Cheng
  Cc: Marijn Suijten, Alexey Minnekhanov, linux-arm-msm,
	linux-remoteproc, devicetree, linux-kernel, linux-arm-kernel,
	iommu, linux-usb, Konrad Dybcio

The AGGRE2 clock is a clock for the entire AGGRE2 bus, managed from
within the interconnect driver. Attaching it to SLPI was a total hack.
Get rid of it.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index acef67ab0581..7061a8e12c81 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -2433,9 +2433,8 @@ slpi_pil: remoteproc@1c00000 {
 					  "handover",
 					  "stop-ack";
 
-			clocks = <&xo_board>,
-				 <&rpmcc RPM_SMD_AGGR2_NOC_CLK>;
-			clock-names = "xo", "aggre2";
+			clocks = <&xo_board>;
+			clock-names = "xo";
 
 			memory-region = <&slpi_mem>;
 

-- 
2.42.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 12/14] arm64: dts: qcom: msm8996: Remove AGGRE2 clock from SLPI
@ 2023-09-13 10:25 Yassine Oudjana
  0 siblings, 0 replies; 2+ messages in thread
From: Yassine Oudjana @ 2023-09-13 10:25 UTC (permalink / raw)
  To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Mathieu Poirier,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Manivannan Sadhasivam, Sibi Sankar, Will Deacon, Robin Murphy,
	Joerg Roedel, Greg Kroah-Hartman, Wesley Cheng
  Cc: Marijn Suijten, Alexey Minnekhanov, linux-arm-msm,
	linux-remoteproc, devicetree, linux-kernel, linux-arm-kernel,
	iommu, linux-usb

On 12/09/2023 4:31 pm, Konrad Dybcio wrote:
> The AGGRE2 clock is a clock for the entire AGGRE2 bus, managed from
> within the interconnect driver. Attaching it to SLPI was a total hack.
> Get rid of it.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>   arch/arm64/boot/dts/qcom/msm8996.dtsi | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index acef67ab0581..7061a8e12c81 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -2433,9 +2433,8 @@ slpi_pil: remoteproc@1c00000 {
>   					  "handover",
>   					  "stop-ack";
>   
> -			clocks = <&xo_board>,
> -				 <&rpmcc RPM_SMD_AGGR2_NOC_CLK>;
> -			clock-names = "xo", "aggre2";
> +			clocks = <&xo_board>;
> +			clock-names = "xo";
>   
>   			memory-region = <&slpi_mem>;
>   

Tested-by: Yassine Oudjana <y.oudjana@protonmail.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-13 10:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-13 10:25 [PATCH v2 12/14] arm64: dts: qcom: msm8996: Remove AGGRE2 clock from SLPI Yassine Oudjana
  -- strict thread matches above, loose matches on Subject: below --
2023-09-12 13:31 [PATCH v2 00/14] Clean up RPM bus clocks remnants Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 12/14] arm64: dts: qcom: msm8996: Remove AGGRE2 clock from SLPI Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).