From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Eibach Subject: Re: [PATCH] powerpc: Make Book E watchdog reset type configurable Date: Fri, 03 May 2013 20:30:03 +0200 Message-ID: References: <1367505913-18970-1-git-send-email-dirk.eibach@gdsys.cc> <20130502161720.GA7797@roeck-us.net> <429ec64cf7c30a139db40eb20fd3e682@gdsys.cc> <20130503011741.GA23266@roeck-us.net> <7be2cb3417615ff206270a756c6422d6@gdsys.cc> <20130503134610.GA31037@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130503134610.GA31037@roeck-us.net> Sender: linux-kernel-owner@vger.kernel.org To: Guenter Roeck Cc: linux-kernel@vger.kernel.org, Kumar Gala , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, devicetree-discuss@lists.ozlabs.org List-Id: devicetree@vger.kernel.org Am 03.05.2013 15:46, schrieb Guenter Roeck: > On Fri, May 03, 2013 at 10:33:13AM +0200, Dirk Eibach wrote: >> Hi Guenter, >> >>>>>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >>>>>> index e89fc31..6048593 100644 >>>>>> --- a/drivers/watchdog/Kconfig >>>>>> +++ b/drivers/watchdog/Kconfig >>>>>> @@ -1172,6 +1172,38 @@ config BOOKE_WDT_DEFAULT_TIMEOUT >>>>>> >>>>>> The value can be overridden by the wdt_period command-line >>>>>> parameter. >>>>>> >>>>>> +choice >>>>>> + prompt "PowerPC Book-E Watchdog reset type" >>>>>> + depends on BOOKE_WDT >>>>>> + default BOOKE_WDT_RESET_CHIP >>>>>> + help >>>>>> + Specify what kind of reset will be executed on watchdog >>>>>> timeout. >>>>>> + >>>>> Seems to me it would be much better to make this configurable via >>>>> platform data >>>>> and/or device tree. >>>> >>>> good catch. What do the device-tree gurus think to be a nice >>>> property name? >> >> having a closer look, I realized booke_wdt is not device-tree based >> yet. Migrating it would come close to a rewrite, breaking >> compatibility for all current users. Sorry, this is way beyond the > > Really ? I don't think making it a platform driver would be that hard, > or break anything. Maybe I am missing something, but wouldn't making it a device-tree driver mean, that I would have to identify all users of BOOKE_WDT and add it to their device trees? Cheers Dirk