From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1155C433FE for ; Wed, 16 Nov 2022 12:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229666AbiKPMkm (ORCPT ); Wed, 16 Nov 2022 07:40:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230115AbiKPMkl (ORCPT ); Wed, 16 Nov 2022 07:40:41 -0500 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F6FBD54 for ; Wed, 16 Nov 2022 04:40:37 -0800 (PST) Received: by mail-lj1-x22e.google.com with SMTP id l8so21626495ljh.13 for ; Wed, 16 Nov 2022 04:40:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sMjAMULuhwmDIgOqqM6Vxh3iSZko0vN2QO1sVbdLZnY=; b=NexxzSeDuKbt0dBCKsAH4EWx2N6qgaOdGHpylos+4JEYagbKQR1elSGsqbnb98Sfm/ hRRefVKhjQEe6sIpSVHIty4vvJ8QiBgyBT/va8/k/SiywVrLO+UAmtPwHf0CC83VheQn edcscXtI8HYxm1DJ82CSdTCWNXwA+GjzQc661J2/T5ke6CyChb9utMUIlbdvyC6uoVDm LTF1Kc7YH7plOXwNli2oj/143LSv2h8lqv0ukyBjCnxWXizP6OO00+7x9MxN8JFEivt9 sM7mMKVElpePl6K/TRk5L+YKyvbAD232eAd+VQcXKAK2RQNYwQCXtTHsGTXyjED+YNSH 6EEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sMjAMULuhwmDIgOqqM6Vxh3iSZko0vN2QO1sVbdLZnY=; b=Y+kgh4FYM/nEQgk/RW67W3ni5w3WpUTDoHlg/Igj2jSK4f02POymaWljCsbiQixhBo Rmxe6nsY/nFAfwbhQoRxcqUK68JmuUqg4sd22GHHJyfizAB9asC/MoE+BCk53o8hqBuL 852nXDMErK+dfeKMZN91lmb1rQ8GpTc5WvRo3ItR+kFEdlzwVG5i6aBz+BbKbx3HA/1O jIKCsREfRBnlOWQNYgLltW7rUf7HtHMHUfvXnswXVwlaaKl7kUgvDBVlCynHV6E7vjAW ODLdpETrQcWhXdvo60uilTn6fCCO+s1nuyOk4SWJAUACtNfNnJfZR2K6deQ6Xu3ExUO0 GvDA== X-Gm-Message-State: ANoB5pnjDdOfjHxYKD9a40mmI+SksP13bp5wjf1o2CsUiby6uoji60J8 NZK2WbpnVlyvqWHK9TjXosgTQA== X-Google-Smtp-Source: AA0mqf6OQIkDD7uLzdcLyX23N1wL0jBRn9QYH4+ABWy3AdhumuX5CFlmGxNSu0QxK39eGh2K/ihMwQ== X-Received: by 2002:a2e:920e:0:b0:26f:c0f4:2360 with SMTP id k14-20020a2e920e000000b0026fc0f42360mr7291571ljg.374.1668602435603; Wed, 16 Nov 2022 04:40:35 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id b13-20020ac25e8d000000b00497ac6b2b15sm2569769lfq.157.2022.11.16.04.40.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 04:40:34 -0800 (PST) Message-ID: Date: Wed, 16 Nov 2022 13:40:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 1/8] dt-bindings: PCI: qcom: Add sm8350 to bindings Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Bjorn Helgaas , Stanimir Varbanov , Manivannan Sadhasivam Cc: Vinod Koul , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org References: <20221110183158.856242-1-dmitry.baryshkov@linaro.org> <20221110183158.856242-2-dmitry.baryshkov@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221110183158.856242-2-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/11/2022 19:31, Dmitry Baryshkov wrote: > Add bindings for two PCIe hosts on SM8350 platform. The only difference > between them is in the aggre0 clock, which warrants the oneOf clause for > the clocks properties. > > Signed-off-by: Dmitry Baryshkov > --- > .../devicetree/bindings/pci/qcom,pcie.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 54f07852d279..502c15f7dd96 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -32,6 +32,7 @@ properties: > - qcom,pcie-sdm845 > - qcom,pcie-sm8150 > - qcom,pcie-sm8250 > + - qcom,pcie-sm8350 > - qcom,pcie-sm8450-pcie0 > - qcom,pcie-sm8450-pcie1 > - qcom,pcie-ipq6018 > @@ -185,6 +186,7 @@ allOf: > - qcom,pcie-sc8180x > - qcom,pcie-sc8280xp > - qcom,pcie-sm8250 > + - qcom,pcie-sm8350 > - qcom,pcie-sm8450-pcie0 > - qcom,pcie-sm8450-pcie1 > then: > @@ -540,6 +542,49 @@ allOf: > items: > - const: pci # PCIe core reset > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pcie-sm8350 > + then: > + oneOf: > + # Unfortunately the "optional" aggre0 clock is used in the middle of the list It's a new device, new support, so you can put it everywhere you wish, can't you? Just put at the and and add minItems:8 Best regards, Krzysztof