From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>
Cc: Bryan O'Donoghue <bod@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Suresh Vankadara <svankada@qti.qualcomm.com>,
Vikram Sharma <vikram.sharma@oss.qualcomm.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: media: qcom,glymur-camss: Drop port@3
Date: Thu, 19 Nov 2026 13:06:32 +0100 [thread overview]
Message-ID: <d741093d-345d-4cdf-a48d-2c5e55be2129@kernel.org> (raw)
In-Reply-To: <88467521-f50d-4c87-8206-4a3249f65212@oss.qualcomm.com>
On 19/11/2026 12:37, Nihal Kumar Gupta wrote:
>
>
> On 16-11-2026 18:02, Nihal Kumar Gupta wrote:
>> On 16-11-2026 17:52, Krzysztof Kozlowski wrote:
>>>> It was not used in-tree yet.
>>> That's different question. You added ABI and that ABI could have been
>>> used. Was the ABI ever correct in the first place?
>> The documented ABI was not correct: port@3 came from the old X1E80100
>> resource-table mapping, not from the Glymur CAMSS port layout.
>
> Hi Krzysztof ,
>
> How would you prefer this ABI issue to be handled, or should I
> send the next version incorporating Loic's comments?
Commit msg should be clear that ABI is changed, whether that ABI was
ever working or even correct/possible to work in the first place. You do
not answer my question really, because if description was not correct
but everything was working fine, then clearly IT WAS correct to some level.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-19 12:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 8:20 [PATCH v2 0/2] media: qcom: camss: Fix Glymur CSIPHY topology Nihal Kumar Gupta
2026-11-13 8:20 ` [PATCH v2 1/2] dt-bindings: media: qcom,glymur-camss: Drop port@3 Nihal Kumar Gupta
2026-11-13 9:54 ` Loic Poulain
2026-11-15 6:49 ` Nihal Kumar Gupta
2026-11-16 12:09 ` Krzysztof Kozlowski
2026-11-16 12:18 ` Nihal Kumar Gupta
2026-11-16 12:22 ` Krzysztof Kozlowski
2026-11-16 12:32 ` Nihal Kumar Gupta
2026-11-19 11:37 ` Nihal Kumar Gupta
2026-11-19 12:06 ` Krzysztof Kozlowski [this message]
2026-11-13 8:20 ` [PATCH v2 2/2] media: qcom: camss: Add Glymur-specific resources Nihal Kumar Gupta
2026-11-13 8:36 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d741093d-345d-4cdf-a48d-2c5e55be2129@kernel.org \
--to=krzk@kernel.org \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=nihal.gupta@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=svankada@qti.qualcomm.com \
--cc=vikram.sharma@oss.qualcomm.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox