From: Matthias Brugger <matthias.bgg@gmail.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
tinghan.shen@mediatek.com, weiyi.lu@mediatek.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: mediatek: mt8195: Use P1 clocks for PCIe1 controller
Date: Fri, 16 Dec 2022 12:29:44 +0100 [thread overview]
Message-ID: <d7432483-7244-1c6e-cff7-ac56a67705a7@gmail.com> (raw)
In-Reply-To: <20221214131117.108008-1-angelogioacchino.delregno@collabora.com>
On 14/12/2022 14:11, AngeloGioacchino Del Regno wrote:
> Despite there being some flexibility regarding the P0/P1 connections,
> especially for TL and PERI, we must use P1 clocks on pcie1 otherwise
> we'll be dealing with unclocked access.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Seems my mail got lost somewhere:
Both patches applied, thanks!
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index 5d31536f4c48..e61944510b8e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1258,9 +1258,9 @@ pcie1: pcie@112f8000 {
>
> clocks = <&infracfg_ao CLK_INFRA_AO_PCIE_PL_P_250M_P1>,
> <&clk26m>,
> - <&infracfg_ao CLK_INFRA_AO_PCIE_TL_96M>,
> + <&infracfg_ao CLK_INFRA_AO_PCIE_P1_TL_96M>,
> <&clk26m>,
> - <&infracfg_ao CLK_INFRA_AO_PCIE_PERI_26M>,
> + <&infracfg_ao CLK_INFRA_AO_PCIE_P1_PERI_26M>,
> /* Designer has connect pcie1 with peri_mem_p0 clock */
> <&pericfg_ao CLK_PERI_AO_PCIE_P0_MEM>;
> clock-names = "pl_250m", "tl_26m", "tl_96m",
prev parent reply other threads:[~2022-12-16 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 13:11 [PATCH 1/2] arm64: dts: mediatek: mt8195: Use P1 clocks for PCIe1 controller AngeloGioacchino Del Regno
2022-12-14 13:11 ` [PATCH 2/2] arm64: dts: mediatek: mt8195: Add power domain to U3PHY1 T-PHY AngeloGioacchino Del Regno
2022-12-16 11:29 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7432483-7244-1c6e-cff7-ac56a67705a7@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=tinghan.shen@mediatek.com \
--cc=weiyi.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).