devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sm8550: enable PMIC RTC on MTP & QRD boards
Date: Tue, 30 May 2023 09:29:43 +0200	[thread overview]
Message-ID: <d76f1e0d-8747-91f7-63f1-9ad85dafef9c@linaro.org> (raw)
In-Reply-To: <4806dbd8-4f9b-0a6f-adf0-4beab74b1ba1@linaro.org>

On 26/05/2023 21:51, Konrad Dybcio wrote:
> 
> 
> On 25.05.2023 17:47, Neil Armstrong wrote:
>> The PMK8550 RTC is functional on the SM8550 MTP & QRD boards,
>> let's enable them.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
> WDYM "functional"? Is there a reason it shouldn't be enabled for
> everyone?

There's none, I'll enable it in the PMIC dtsi instead.

Neil

> 
> Konrad
>>   arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 4 ++++
>>   arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 4 ++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
>> index e2b9bb6b1e27..6bf111e655f7 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
>> @@ -496,6 +496,10 @@ &pm8550b_eusb2_repeater {
>>   	vdd3-supply = <&vreg_l5b_3p1>;
>>   };
>>   
>> +&pmk8550_rtc {
>> +	status = "okay";
>> +};
>> +
>>   &qupv3_id_0 {
>>   	status = "okay";
>>   };
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
>> index 4a8177f99523..b08a8201ad23 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
>> @@ -482,6 +482,10 @@ &pm8550b_eusb2_repeater {
>>   	vdd3-supply = <&vreg_l5b_3p1>;
>>   };
>>   
>> +&pmk8550_rtc {
>> +	status = "okay";
>> +};
>> +
>>   &qupv3_id_0 {
>>   	status = "okay";
>>   };
>>


  reply	other threads:[~2023-05-30  7:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 15:47 [PATCH 0/4] arm64: qcom: sm8550: enable PMIC devices Neil Armstrong
2023-05-25 15:47 ` [PATCH 1/4] arm64: dts: qcom: pm8550: add PWM controller Neil Armstrong
2023-05-26 19:50   ` Konrad Dybcio
2023-05-25 15:47 ` [PATCH 2/4] arm64: dts: qcom: sm8550-qrd: add notification RGB LED Neil Armstrong
2023-05-26 19:50   ` Konrad Dybcio
2023-05-25 15:47 ` [PATCH 3/4] arm64: dts: qcom: sm8550: enable PMIC RTC on MTP & QRD boards Neil Armstrong
2023-05-26 19:51   ` Konrad Dybcio
2023-05-30  7:29     ` Neil Armstrong [this message]
2023-05-25 15:47 ` [PATCH 4/4] arm64: dts: qcom: sm8550-qrd: enable PMIC Volume and Power buttons Neil Armstrong
2023-05-26 19:53   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d76f1e0d-8747-91f7-63f1-9ad85dafef9c@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).