From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BF9CC7EE23 for ; Tue, 30 May 2023 07:30:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231214AbjE3Hay (ORCPT ); Tue, 30 May 2023 03:30:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230464AbjE3Ha0 (ORCPT ); Tue, 30 May 2023 03:30:26 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8C0310E for ; Tue, 30 May 2023 00:29:45 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-30af56f5f52so126988f8f.1 for ; Tue, 30 May 2023 00:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685431784; x=1688023784; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=XHy/LfOj6uTyno9ClqD5FZ00I/Rkz/Xjmgux3hflxTk=; b=ym+oY4CXyrSgaCceabymeYOlBGvNxreXMNA6azegNUVvk2uLxP5llY7KADbBoF+j9C xglV/ILfwZuXjx9Bh1QbRAnKpO0cqvYqIzYgmBsgpdZ8IuFsWqo6DD6PGY3ZBRYruM51 XN05pkm+BRRdsyQLCUJqfLf14FqwM+2e+I2TGg5/Pu2X4+TSzqeCf0HzqRal2hw7b6cT OlkNNry+Dniq+WI7eNoWORS724ZZ/DkxyOZK327XU5cZO8x9nlUIvSSCHQgdy3iqH3iO RGMVzff9WoYord9vpMS5ECfTXk2f+nLCD9KzrlScxXo9S9ZPaBZmQrJrYlNEXICQP0xI USZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685431784; x=1688023784; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XHy/LfOj6uTyno9ClqD5FZ00I/Rkz/Xjmgux3hflxTk=; b=FjVK8N0JjwgpsIkI5Y8Fc4Swc5O5Q1HmrzBpMSU3+lx+H7+zQIOKt5M+7TZYQX7qkY nr/bzSYPP+u4G8wpPEb8hF81std3sUS++N0Zx9Ycnp2iPWnWdH4Lf3/ANkoj8rfe4+hY kVaabC+zF4jGBvvUyhMEQ502553pLw1lJ9+NF35Bv3nABtxlsHEG/gXxBEeO6t7YAgt5 FS0ubuAnU3zi4JkiFLMhZOfCT/nRM5cpB66Lyp5ULsM0cIYXgu15/NHAH73KowrJ3qi+ vf2KwBMNJynVWmFQJvel1MTdd4koedA85XQqNVTtido6ZcUpR30fYfyzMfC27CDmB6D5 nDuA== X-Gm-Message-State: AC+VfDxYI6UyhVrogWFzlSLMupThwZgmpknt4W2XxPQ8ScIQsoyH10O2 feRBN23VpRAl4JT693uDHbRMDA== X-Google-Smtp-Source: ACHHUZ6Oj80NsiNcsYRYMVVckEsOwSLWymbKsXeb+oj8fmPzK/Wkc65dHdjb3SIxn8GblysOHQNkhQ== X-Received: by 2002:adf:f9cd:0:b0:307:41a1:a125 with SMTP id w13-20020adff9cd000000b0030741a1a125mr897548wrr.12.1685431784210; Tue, 30 May 2023 00:29:44 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:4294:2221:d2df:9e87? ([2a01:e0a:982:cbb0:4294:2221:d2df:9e87]) by smtp.gmail.com with ESMTPSA id h12-20020a5d6e0c000000b002ca864b807csm2356099wrz.0.2023.05.30.00.29.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 00:29:43 -0700 (PDT) Message-ID: Date: Tue, 30 May 2023 09:29:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 3/4] arm64: dts: qcom: sm8550: enable PMIC RTC on MTP & QRD boards Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230525-topic-sm8550-upstream-pm8550-lpg-dt-v1-0-4d5d7602f290@linaro.org> <20230525-topic-sm8550-upstream-pm8550-lpg-dt-v1-3-4d5d7602f290@linaro.org> <4806dbd8-4f9b-0a6f-adf0-4beab74b1ba1@linaro.org> Organization: Linaro Developer Services In-Reply-To: <4806dbd8-4f9b-0a6f-adf0-4beab74b1ba1@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/05/2023 21:51, Konrad Dybcio wrote: > > > On 25.05.2023 17:47, Neil Armstrong wrote: >> The PMK8550 RTC is functional on the SM8550 MTP & QRD boards, >> let's enable them. >> >> Signed-off-by: Neil Armstrong >> --- > WDYM "functional"? Is there a reason it shouldn't be enabled for > everyone? There's none, I'll enable it in the PMIC dtsi instead. Neil > > Konrad >> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 4 ++++ >> arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 4 ++++ >> 2 files changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> index e2b9bb6b1e27..6bf111e655f7 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> @@ -496,6 +496,10 @@ &pm8550b_eusb2_repeater { >> vdd3-supply = <&vreg_l5b_3p1>; >> }; >> >> +&pmk8550_rtc { >> + status = "okay"; >> +}; >> + >> &qupv3_id_0 { >> status = "okay"; >> }; >> diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts >> index 4a8177f99523..b08a8201ad23 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts >> @@ -482,6 +482,10 @@ &pm8550b_eusb2_repeater { >> vdd3-supply = <&vreg_l5b_3p1>; >> }; >> >> +&pmk8550_rtc { >> + status = "okay"; >> +}; >> + >> &qupv3_id_0 { >> status = "okay"; >> }; >>