From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 4/4] arm64: dts: rockchip: update the thermal zones for RK3399 SoCs References: <1499840971-20392-1-git-send-email-wxt@rock-chips.com> <1499840971-20392-5-git-send-email-wxt@rock-chips.com> <20170712173208.GA92073@google.com> From: Caesar Wang Message-ID: Date: Thu, 13 Jul 2017 09:01:42 +0800 MIME-Version: 1.0 In-Reply-To: <20170712173208.GA92073@google.com> Content-Type: multipart/alternative; boundary="------------C9A18D10008F253D4627DA97" Content-Language: en-US To: Brian Norris , Caesar Wang Cc: Mark Rutland , devicetree@vger.kernel.org, Heiko Stuebner , linux-kernel@vger.kernel.org, Shawn Lin , Elaine Zhang , Will Deacon , Douglas Anderson , Kever Yang , linux-rockchip@lists.infradead.org, Rob Herring , Roger Chen , Catalin Marinas , William wu , rocky.hao@rock-chips.com, linux-arm-kernel@lists.infradead.org List-ID: This is a multi-part message in MIME format. --------------C9A18D10008F253D4627DA97 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Hi Brian, �� 2017��07��13�� 01:32, Brian Norris �: > Hi Caesar, > > On Wed, Jul 12, 2017 at 02:29:30PM +0800, Caesar Wang wrote: >> As RK3399 had used the Power allocator thermal governor by default, >> enabled this to manage thermals by dynamically allocating and limiting >> power to devices. >> >> Also, this patch supported the dynamic-power-coefficient/sustainable_power >> and GPU's power model for needed parameters with thermal IPA. >> >> Signed-off-by: Caesar Wang >> >> --- >> >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 62 +++++++++++++++----------------- >> 1 file changed, 29 insertions(+), 33 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> index 8c6438b..139f58c 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> @@ -147,7 +147,7 @@ >> enable-method = "psci"; >> #cooling-cells = <2>; /* min followed by max */ >> clocks = <&cru ARMCLKB>; >> - dynamic-power-coefficient = <100>; >> + dynamic-power-coefficient = <436>; >> }; >> >> cpu_b1: cpu@101 { >> @@ -156,7 +156,7 @@ >> reg = <0x0 0x101>; >> enable-method = "psci"; >> clocks = <&cru ARMCLKB>; >> - dynamic-power-coefficient = <100>; >> + dynamic-power-coefficient = <436>; > There are 6 of these properties (1 for each core now; not just 1 for > each cluster), and you're only changing 2 of them. > > BTW, are these values determined from measurement this time? And heavily > tested? The previous values were suspiciously round, but they'd been > heavily tested so I didn't mind :) * * The coefficient is used to calulate the dynamic power as below - Pdyn= dynamic-power-coefficient * V^2 * f The value was tested on rockchip inside, that should be resonable for me. As the PLT tested the little cpu power comsumption Pl = 0.9mw, but big cpu power comsumption Pb= 0.28mw -Caesar > >> }; >> }; >> > ... > > Brian > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip --------------C9A18D10008F253D4627DA97 Content-Type: text/html; charset=gbk Content-Transfer-Encoding: 8bit Hi Brian,

�� 2017��07��13�� 01:32, Brian Norris �:
Hi Caesar,

On Wed, Jul 12, 2017 at 02:29:30PM +0800, Caesar Wang wrote:

As RK3399 had used the Power allocator thermal governor by default,
enabled this to manage thermals by dynamically allocating and limiting
power to devices.

Also, this patch supported the dynamic-power-coefficient/sustainable_power
and GPU's power model for needed parameters with thermal IPA.

Signed-off-by: Caesar Wang <wxt@rock-chips.com>

---

 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 62 +++++++++++++++-----------------
 1 file changed, 29 insertions(+), 33 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 8c6438b..139f58c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -147,7 +147,7 @@
 			enable-method = "psci";
 			#cooling-cells = <2>; /* min followed by max */
 			clocks = <&cru ARMCLKB>;
-			dynamic-power-coefficient = <100>;
+			dynamic-power-coefficient = <436>;
 		};
 
 		cpu_b1: cpu@101 {
@@ -156,7 +156,7 @@
 			reg = <0x0 0x101>;
 			enable-method = "psci";
 			clocks = <&cru ARMCLKB>;
-			dynamic-power-coefficient = <100>;
+			dynamic-power-coefficient = <436>;

There are 6 of these properties (1 for each core now; not just 1 for
each cluster), and you're only changing 2 of them.

BTW, are these values determined from measurement this time? And heavily
tested? The previous values were suspiciously round, but they'd been
heavily tested so I didn't mind :)


The coefficient is used to calulate the dynamic power as below -
Pdyn= dynamic-power-coefficient * V^2 * f

The value was tested on rockchip inside, that should be resonable for me.
As the PLT tested the little cpu power comsumption Pl = 0.9mw, but big cpu power comsumption Pb= 0.28mw
-Caesar


 		};
 	};
 

...

Brian

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

--------------C9A18D10008F253D4627DA97--