Re: [PATCH v2 00/17] mfd: adp5585: support keymap events and drop legacy Input driver

["Nuno Sá" <noname.nuno@gmail.com>]

On Fri, 2025-05-02 at 08:13 +0100, Lee Jones wrote:
> On Thu, 01 May 2025, Laurent Pinchart wrote:
> 
> > Hi Lee,
> > 
> > On Thu, May 01, 2025 at 01:00:03PM +0100, Lee Jones wrote:
> > > On Tue, 15 Apr 2025 15:49:16 +0100, Nuno Sá wrote:
> > > > The adp5585 MFD driver was introduced in 6.11 adding support for gpio
> > > > and PWM. However, the gpio part of it was already supported as part of
> > > > the keyboard driver:
> > > > 
> > > > https://elixir.bootlin.com/linux/v6.14-rc6/source/drivers/input/keyboard/adp5589-keys.c#L532
> > > > 
> > > > On top of that it also overlapped with my refactoring of the above
> > > > driver [1]
> > > > to drop usage of platform data and use FW properties instead.
> > > > 
> > > > [...]
> > > 
> > > Applied, thanks!
> > > 
> > > [01/17] dt-bindings: mfd: adp5585: ease on the required properties
> > >         commit: 3a2ea3e9f369bdae939bcccff67a77a6281dca74
> > > [02/17] mfd: adp5585: enable oscilator during probe
> > >         commit: 7353f196fd73b79e30ff750d93caf096ed660e1b
> > > [03/17] pwm: adp5585: don't control OSC_EN in the pwm driver
> > >         commit: 7c7e9f08a1a9bf16b6c1942c2e0cb919da855970
> > > [04/17] mfd: adp5585: make use of MFD_CELL_NAME()
> > >         commit: e72e9148d017535b39500d0aad624d0a0fcd2ce7
> > > [05/17] dt-bindings: mfd: adp5585: document adp5589 I/O expander
> > >         commit: 6da01b9d833c5efbce7c2e30dde276e0d29105f8
> > > [06/17] mfd: adp5585: add support for adp5589
> > >         commit: 382dc0327b8a9ee03c901df9b85134c68917becc
> > > [07/17] gpio: adp5585: add support for the ad5589 expander
> > >         commit: cff3cef09595001140bd29aedf33fc84998bf77c
> > > [08/17] pwm: adp5585: add support for adp5589
> > >         commit: 333b66fd3edfe18db4dc16041328a89144b73067
> > > [09/17] dt-bindings: mfd: adp5585: add properties for input events
> > >         commit: 7bdb41d7a85e1c6244da57d4dcc491df962ff3fb
> > > [10/17] mfd: adp5585: add support for key events
> > >         commit: 8814ac45c75fcce55896bc376a97b56f392925c3
> > > [11/17] gpio: adp5585: support gpi events
> > >         commit: 8f3d9b44c5c5ada312d0ef71ec0181011854a95b
> > > [12/17] Input: adp5585: Add Analog Devices ADP5585/89 support
> > >         commit: a53fc67a1e21a8507821263946b1d65687b0284f
> > > [13/17] Input: adp5589: remove the driver
> > >         commit: 216c99cf1002a42f896b54fab09823e8ba46b218
> > > [14/17] mfd: adp5585: support getting vdd regulator
> > >         commit: 63a8717f744d51ea0c8228e09db4233d48f2f9ba
> > > [15/17] dt-bindings: mfd: adp5585: document reset gpio
> > >         commit: 49c887f0547bc14eb50ba20e1c8acb7255af3b86
> > > [16/17] mfd: adp5585: add support for a reset pin
> > >         commit: 01c328823459456fb99469cc37f270f70d41fd2a
> > > [17/17] pwm: adp5585: make sure to include mod_devicetable.h
> > >         (no commit info)
> > 
> > I'm a bit surprised, didn't you ask for changes, calling for a v3 ?
> 
> Yes, sorry.  My fault.  Tooling error.  Please disregard.

I was wondering the same...

- Nuno Sá