devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Max Filippov <jcmvbkbc@gmail.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 1/4] dt-bindings: serial: document esp32-uart bindings
Date: Thu, 14 Sep 2023 07:55:35 +0200	[thread overview]
Message-ID: <d7bf0ae3-d263-4231-9656-2b7af4b372a3@linaro.org> (raw)
In-Reply-To: <20230913211449.668796-2-jcmvbkbc@gmail.com>

On 13/09/2023 23:14, Max Filippov wrote:
> Add documentation for the ESP32xx UART controllers.
> 
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  .../bindings/serial/esp,esp32-uart.yaml       | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/serial/esp,esp32-uart.yaml
> 
> diff --git a/Documentation/devicetree/bindings/serial/esp,esp32-uart.yaml b/Documentation/devicetree/bindings/serial/esp,esp32-uart.yaml
> new file mode 100644
> index 000000000000..8b45ef808107
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/esp,esp32-uart.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/serial/esp,esp32-uart.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ESP32 UART controller
> +
> +maintainers:
> +  - Max Filippov <jcmvbkbc@gmail.com>
> +
> +description: |
> +  ESP32 UART controller is a part of ESP32 SoC series.

1. Company name?
2. ESP32 SoC series suggests esp32 is a series.

> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - description: UART controller for the ESP32 SoC
> +        const: esp,esp32-uart

Also, the vendor prefix looks incorrect, so again - what is the company
name?

Best regards,
Krzysztof


  parent reply	other threads:[~2023-09-14  5:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 21:14 [PATCH 0/4] serial: add drivers for the ESP32xx serial devices Max Filippov
2023-09-13 21:14 ` [PATCH 1/4] dt-bindings: serial: document esp32-uart bindings Max Filippov
2023-09-14  5:54   ` Krzysztof Kozlowski
2023-09-14 20:00     ` Max Filippov
2023-09-14  5:55   ` Krzysztof Kozlowski [this message]
2023-09-14 14:48     ` Conor Dooley
2023-09-14 20:02       ` Max Filippov
2023-09-13 21:14 ` [PATCH 2/4] drivers/tty/serial: add driver for the ESP32 UART Max Filippov
2023-09-14  7:06   ` Jiri Slaby
2023-09-15  9:04     ` Max Filippov
2023-09-14 13:07   ` Ilpo Järvinen
2023-09-15 22:33     ` Max Filippov
2023-09-18  9:07       ` Ilpo Järvinen
2023-09-13 21:14 ` [PATCH 3/4] dt-bindings: serial: document esp32s3-acm bindings Max Filippov
2023-09-14  5:57   ` Krzysztof Kozlowski
2023-09-14 20:47     ` Max Filippov
2023-09-15  6:50       ` Krzysztof Kozlowski
2023-09-13 21:14 ` [PATCH 4/4] drivers/tty/serial: add ESP32S3 ACM device driver Max Filippov
2023-09-14  7:16   ` Jiri Slaby
2023-09-15 23:54     ` Max Filippov
2023-09-14 13:14   ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7bf0ae3-d263-4231-9656-2b7af4b372a3@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).