From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other Date: Tue, 3 Jan 2017 11:57:37 -0300 Message-ID: References: <1483430237-26823-1-git-send-email-jcsing.lee@samsung.com> <1483430237-26823-4-git-send-email-jcsing.lee@samsung.com> <20170103095842.h3hl64amje4qv4ts@gangnam.samsung> <20170103102548.73jg6qddlcthe2mu@gangnam.samsung> <20170103115530.zhjwn7bzmqmumy23@gangnam.samsung> <20170103144056.4ft2ohmhgmezeney@jack.zhora.eu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170103144056.4ft2ohmhgmezeney@jack.zhora.eu> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andi Shyti Cc: Mark Rutland , devicetree , beomho.seo@samsung.com, linux-samsung-soc , Kukjin Kim , Catalin Marinas , Jaechul Lee , Dmitry Torokhov , Will Deacon , linux-kernel , Andi Shyti , Chanwoo Choi , Rob Herring , Krzysztof Kozlowski , linux-input@vger.kernel.org, galaxyra@gmail.com, Chanwoo Choi , linux-arm-kernel List-Id: devicetree@vger.kernel.org Hello Andi, On 01/03/2017 11:40 AM, Andi Shyti wrote: > Hi, > >> FWIW, I also agree with Chanwoo that the difference is too small to >> need a common .dtsi file. > > in principle I don't like "switching on and off" properties by > overwriting them with "status = disable", unless it's really This is a very good point. It would had been different if it was the opposite and tm2e had to enable the device node, but disabling it is indeed more confusing. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America