devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Vasut <marex@denx.de>, linux-iio@vger.kernel.org
Cc: Conor Dooley <conor+dt@kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh@kernel.org>,
	Shreeya Patel <shreeya.patel@collabora.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH] iio: light: ltrf216a: Drop undocumented ltr,ltrf216a compatible string
Date: Fri, 5 Jul 2024 11:55:45 +0200	[thread overview]
Message-ID: <d7c950d9-0187-4e42-8e5c-bf518e1ca7b7@kernel.org> (raw)
In-Reply-To: <20240705095047.90558-1-marex@denx.de>

On 05/07/2024 11:50, Marek Vasut wrote:
> The "ltr,ltrf216a" compatible string is not documented in DT binding
> document, remove it.

Also could be useful:
"The compatible was rejected during review by Rob Herring but still made
it to the kernel."

> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Ehh, so the original author just half-understood comment from Rob [1]
and totally ignored checkpatch warning :/

If only people actually run and read the output of the tools instead of
pushing their code...

Thanks for cleanup.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

[1] https://lore.kernel.org/all/20220516170406.GB2825626-robh@kernel.org/

Best regards,
Krzysztof


  reply	other threads:[~2024-07-05  9:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05  9:50 [PATCH] iio: light: ltrf216a: Drop undocumented ltr,ltrf216a compatible string Marek Vasut
2024-07-05  9:55 ` Krzysztof Kozlowski [this message]
2024-07-05 10:42 ` Shreeya Patel
2024-07-05 14:52   ` Marek Vasut
2024-07-05 18:03     ` Shreeya Patel
2024-07-07 11:26       ` Jonathan Cameron
2024-07-07 12:06         ` Krzysztof Kozlowski
2024-07-07 13:43           ` Jonathan Cameron
2024-07-07 12:02   ` Krzysztof Kozlowski
2024-07-07 13:37     ` Jonathan Cameron
2024-07-07 13:46       ` Krzysztof Kozlowski
2024-07-07 14:08         ` Jonathan Cameron
2024-07-08 11:25           ` Krzysztof Kozlowski
2024-07-08 12:29             ` Sebastian Reichel
2024-07-08 12:13           ` Sebastian Reichel
2024-07-08 13:20           ` Shreeya Patel
2024-07-08 16:01             ` Jonathan Cameron
2024-08-12 13:24       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7c950d9-0187-4e42-8e5c-bf518e1ca7b7@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=robh@kernel.org \
    --cc=shreeya.patel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).