From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AE1DC7618D for ; Tue, 4 Apr 2023 02:26:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232550AbjDDC0x convert rfc822-to-8bit (ORCPT ); Mon, 3 Apr 2023 22:26:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232267AbjDDC0w (ORCPT ); Mon, 3 Apr 2023 22:26:52 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 780181BFE; Mon, 3 Apr 2023 19:26:47 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 61CFD24E227; Tue, 4 Apr 2023 10:26:45 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 4 Apr 2023 10:26:45 +0800 Received: from [192.168.1.218] (180.164.60.184) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 4 Apr 2023 10:26:44 +0800 Message-ID: Date: Tue, 4 Apr 2023 10:26:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3 3/9] media: dt-bindings: cadence-csi2rx: Convert to DT schema Content-Language: en-US To: Krzysztof Kozlowski , "Mauro Carvalho Chehab" , Maxime Ripard , Rob Herring , Krzysztof Kozlowski , Robert Foss , "Todor Tomov" , Philipp Zabel , "Laurent Pinchart" , Ezequiel Garcia , Hans Verkuil , Eugen Hristev CC: , , , References: <20230331121826.96973-1-jack.zhu@starfivetech.com> <20230331121826.96973-4-jack.zhu@starfivetech.com> <0aa3a039-daf3-7e05-6da9-258335a5ca20@linaro.org> <9c132e62-7830-90bf-2c3e-1568a54eb6ec@starfivetech.com> From: Jack Zhu In-Reply-To: Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/4/3 17:53, Krzysztof Kozlowski wrote: > On 03/04/2023 11:48, Jack Zhu wrote: >> >> >> On 2023/4/1 4:12, Krzysztof Kozlowski wrote: >>> On 31/03/2023 14:18, Jack Zhu wrote: >>>> Convert DT bindings document for Cadence MIPI-CSI2 RX controller >>>> to DT schema format. >>>> >>>> Signed-off-by: Jack Zhu >>>> --- >>>> .../devicetree/bindings/media/cdns,csi2rx.txt | 100 ---------- >>>> .../bindings/media/cdns,csi2rx.yaml | 174 ++++++++++++++++++ >>>> MAINTAINERS | 1 + >>>> 3 files changed, 175 insertions(+), 100 deletions(-) >>>> delete mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.txt >>>> create mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.txt b/Documentation/devicetree/bindings/media/cdns,csi2rx.txt >>>> deleted file mode 100644 >>>> index 6b02a0657ad9..000000000000 >>>> --- a/Documentation/devicetree/bindings/media/cdns,csi2rx.txt >>>> +++ /dev/null >>>> @@ -1,100 +0,0 @@ >>>> -Cadence MIPI-CSI2 RX controller >>>> -=============================== >>>> - >>>> -The Cadence MIPI-CSI2 RX controller is a CSI-2 bridge supporting up to 4 CSI >>>> -lanes in input, and 4 different pixel streams in output. >>>> - >>>> -Required properties: >>>> - - compatible: must be set to "cdns,csi2rx" and an SoC-specific compatible >>> >>> >>> ... >>> >>>> +$id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Cadence MIPI-CSI2 RX controller >>>> + >>>> +maintainers: >>>> + - Maxime Ripard >>>> + >>>> +description: >>>> + The Cadence MIPI-CSI2 RX controller is a CSI-2 bridge supporting up to 4 CSI >>>> + lanes in input, and 4 different pixel streams in output. >>>> + >>>> +properties: >>>> + compatible: >>>> + const: cdns,csi2rx >>> >>> That's not equivalent conversion and your commit msg does no mention any >>> drops in compatibles. >>> >> The equivalent conversion refers to 'an SoC-specific compatible'? > > Yes. > >> I'm not sure that, is it enough to add a description (drop an 'SoC-specific compatible') >> to my next version commit message? > > Original binding did not allow csi2rx compatible alone. Your binding > here allows it, thus it is not simple conversion. > > I think patch 5 should be squashed here - with proper explanation. > Usually new compatibles should not be messed with conversion, but this > conversion on its own does not make much sense. > Ok, I will merge patch 5 into the patch, and add explanation in my commit msg. > > > Best regards, > Krzysztof >