From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D74D4C433EF for ; Mon, 4 Jul 2022 19:15:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231733AbiGDTPt (ORCPT ); Mon, 4 Jul 2022 15:15:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbiGDTPs (ORCPT ); Mon, 4 Jul 2022 15:15:48 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6BE76351; Mon, 4 Jul 2022 12:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=9LEtZ7AeBNN6P70RAq3sG9bOAFlAYv5x5HPRLtRJ+C4=; b=pw1Zw0tibK+sD2iCiB4IwoFEFf 163lTNfUK64j7CDKzhzuYZXLNznA7TJNPEpD/Durtmk4qqNOgJc9x4ZxVHbRVRLv01kzuuB+f+cJ4 CxTZEczO/AytaFQOJ6uSUUM7SPESP1D4ks5M3ilbVCFydWe813COKbqRkuMemd6SVkLSsGV275lM6 2lNbhzRQrzy8B/7wgNNs7i/NTqVTgEnKlqXUuiSb8Y/4KLM++gwtn9I7LyMKFz1+OAaSLnLpaoXs5 No5yJ2kqN4nvlMFZvmcm4MAkpXJ2T2z+KqBjHgHoliz1+J5f+KNZvCHbxPep6YCfEQQG/R6odJIDx LRz+mfoQ==; Received: from [2601:1c0:6280:3f0::a6b3] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8RXr-00B9Ry-GN; Mon, 04 Jul 2022 19:15:43 +0000 Message-ID: Date: Mon, 4 Jul 2022 12:15:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8 2/4] soc: qcom: icc-bwmon: Add bandwidth monitoring driver Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Rajendra Nayak , Thara Gopinath References: <20220704121730.127925-1-krzysztof.kozlowski@linaro.org> <20220704121730.127925-3-krzysztof.kozlowski@linaro.org> <3770bc6d-b3cc-9e49-a832-4c15af0b5f1a@infradead.org> <9cd658cd-3b8c-89d1-651d-ce81794fb68c@linaro.org> From: Randy Dunlap In-Reply-To: <9cd658cd-3b8c-89d1-651d-ce81794fb68c@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 7/4/22 08:22, Krzysztof Kozlowski wrote: > On 04/07/2022 17:20, Randy Dunlap wrote: >> Hi, >> >> On 7/4/22 05:17, Krzysztof Kozlowski wrote: >>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig >>> index e718b8735444..2c8091535bf7 100644 >>> --- a/drivers/soc/qcom/Kconfig >>> +++ b/drivers/soc/qcom/Kconfig >>> @@ -228,4 +228,19 @@ config QCOM_APR >>> application processor and QDSP6. APR is >>> used by audio driver to configure QDSP6 >>> ASM, ADM and AFE modules. >>> + >>> +config QCOM_ICC_BWMON >>> + tristate "QCOM Interconnect Bandwidth Monitor driver" >>> + depends on ARCH_QCOM || COMPILE_TEST >>> + select PM_OPP >>> + help >>> + Sets up driver monitoring bandwidth on various interconnects and >> >> Sets up driver bandwidth monitoring >> >> would be better, I think. > > It's a driver which monitors bandwidth, so your version sounds a bit > like monitoring of driver's bandwidth. > > Maybe should be: > Sets up driver which monitors bandwidth... > ? Yes, that's OK. Thanks. -- ~Randy