From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from courrier.aliel.fr (courrier.aliel.fr [65.21.61.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4F503BED0C; Fri, 24 Apr 2026 14:00:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.21.61.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777039260; cv=none; b=ggnDITDaTPszaIuLZOvr/PGy4YM/GSA4CdJzHqV4yKLqgBTqMNHZVlo8Q8riEoTLTl8oYlLCQyJYKCNdVB9IU626A6aUJCHG/V46BQW/G/1tSMP0RHKOOyFc8ceSTZC9PDLUgBV+r5euXIQWH9vB+6/MG39YvcX1m3NLeQyEx9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777039260; c=relaxed/simple; bh=9pUhrKJcwFra8E+jfRhvbHF2LOR340gxwUJUdLIfuIs=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=GRavqqSLgvR7vEo90xbw1vC5lret7xMH+8UfLot0OhtMlfJI+lAr7PmgcvR5NvKrP/9SNuKX5VMidzMTkm5WH0JmuVQBySpy4rky67jOqDcJIRiJ7oi4SNqkIUkf/M2I5It1UIAmZ23MQBeP+3SmZnqKgD7CyvNFhb7NHktsIOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=aliel.fr; spf=pass smtp.mailfrom=aliel.fr; dkim=pass (1024-bit key) header.d=aliel.fr header.i=@aliel.fr header.b=ZpHkUmLd; arc=none smtp.client-ip=65.21.61.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=aliel.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aliel.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=aliel.fr header.i=@aliel.fr header.b="ZpHkUmLd" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aliel.fr; s=courrier-s1; t=1777039255; bh=9pUhrKJcwFra8E+jfRhvbHF2LOR340gxwUJUdLIfuIs=; h=Date:From:Subject:To:Cc:References:In-Reply-To; b=ZpHkUmLdcMXDWY338GnmSfmcP+yIFuCYhyVpFLFW0EVRCADz2r2F6I3gxWK7n2F94 zf3VQC/HKYFmdwULy3kXCe27kGQu19amfQL+y/nOJa3hT+jY1wC9lykgSdv1C/vd8T VEGWxpuHPTqTqnnZjx0vylRhNyF1VyoaWN4KRrB8= Date: Fri, 24 Apr 2026 16:00:53 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta From: linux-kernel-dev@aliel.fr Subject: Re: [PATCH v4 5/8] thermal: khadas-mcu-fan: Add fan config from platform data Add regulator support To: Neil Armstrong Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andi Shyti , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Beniamino Galvani , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Liam Girdwood , Mark Brown References: <20260421-add-mcu-fan-khadas-vim4-v4-0-447114a28f2d@aliel.fr> <20260421-add-mcu-fan-khadas-vim4-v4-5-447114a28f2d@aliel.fr> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thanks for your review. On 4/24/26 12:00 PM, Neil Armstrong wrote: > On 4/21/26 13:49, Ronald Claveau via B4 Relay wrote: >> From: Ronald Claveau >> >> Replace the hardcoded MAX_LEVEL constant and fan register >> with values read from platform_data (fan_reg, max_level), >> as new MCUs need different values. >> >> Optionally acquire and enable a "fan" regulator supply >> at probe time and on resume, >> so boards that gate fan power through a regulator are handled. >> >> Signed-off-by: Ronald Claveau >> --- >>   drivers/thermal/khadas_mcu_fan.c | 49 ++++++++++++++++++++++++++++++ >> +++++----- >>   1 file changed, 43 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/thermal/khadas_mcu_fan.c b/drivers/thermal/ >> khadas_mcu_fan.c >> index d35e5313bea41..24559bf65de46 100644 >> --- a/drivers/thermal/khadas_mcu_fan.c >> +++ b/drivers/thermal/khadas_mcu_fan.c >> @@ -13,13 +13,15 @@ >>   #include >>   #include >>   #include >> - >> -#define MAX_LEVEL 3 >> +#include >>     struct khadas_mcu_fan_ctx { >>       struct khadas_mcu *mcu; >> +    unsigned int fan_reg; >>       unsigned int level; >> +    unsigned int max_level; >>       struct thermal_cooling_device *cdev; >> +    struct regulator *power; >>   }; >>     static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx, >> @@ -27,8 +29,7 @@ static int khadas_mcu_fan_set_level(struct >> khadas_mcu_fan_ctx *ctx, >>   { >>       int ret; >>   -    ret = regmap_write(ctx->mcu->regmap, >> KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG, >> -               level); >> +    ret = regmap_write(ctx->mcu->regmap, ctx->fan_reg, level); >>       if (ret) >>           return ret; >>   @@ -40,7 +41,9 @@ static int khadas_mcu_fan_set_level(struct >> khadas_mcu_fan_ctx *ctx, >>   static int khadas_mcu_fan_get_max_state(struct >> thermal_cooling_device *cdev, >>                       unsigned long *state) >>   { >> -    *state = MAX_LEVEL; >> +    struct khadas_mcu_fan_ctx *ctx = cdev->devdata; >> + >> +    *state = ctx->max_level; >>         return 0; >>   } >> @@ -61,7 +64,7 @@ khadas_mcu_fan_set_cur_state(struct >> thermal_cooling_device *cdev, >>   { >>       struct khadas_mcu_fan_ctx *ctx = cdev->devdata; >>   -    if (state > MAX_LEVEL) >> +    if (state > ctx->max_level) >>           return -EINVAL; >>         if (state == ctx->level) >> @@ -83,11 +86,32 @@ static int khadas_mcu_fan_probe(struct >> platform_device *pdev) >>       struct device *dev = &pdev->dev; >>       struct khadas_mcu_fan_ctx *ctx; >>       int ret; >> +    const struct khadas_mcu_fan_pdata *pdata = >> dev_get_platdata(&pdev->dev); > > Move this on top to respect reverse christmas ordering. > Ok I will do that. >>         ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); >>       if (!ctx) >>           return -ENOMEM; >> + >>       ctx->mcu = mcu; >> +    ctx->fan_reg   = pdata->fan_reg; >> +    ctx->max_level = pdata->max_level; >> + >> +    ctx->power = devm_regulator_get_optional(dev->parent, "fan"); >> +    if (IS_ERR(ctx->power)) { >> +        if (PTR_ERR(ctx->power) == -ENODEV) >> +            ctx->power = NULL; >> +        else >> +            return PTR_ERR(ctx->power); >> +    } >> + >> +    if (ctx->power) { >> +        ret = regulator_enable(ctx->power); >> +        if (ret) { >> +            dev_err(dev, "Failed to enable fan power supply: %d\n", >> ret); >> +            return ret; +        } >> +    } > > Or you can request with devm_regulator_get(dev->parent, "fan"); which will > return a dummy regulator, and then you can just call regulator_enable & > disable > and remove all those checks. > Make sense, I'm on it. >> + >>       platform_set_drvdata(pdev, ctx); >>         cdev = devm_thermal_of_cooling_device_register(dev->parent, >> @@ -124,12 +148,25 @@ static int khadas_mcu_fan_suspend(struct device >> *dev) >>         ctx->level = level_save; >>   +    if (ctx->power) { >> +        ret = regulator_disable(ctx->power); >> +        if (ret) >> +            return ret; >> +    } > > if (ctx->power) >     return regulator_disable(ctx->power); > >> + >>       return 0; >>   } >>     static int khadas_mcu_fan_resume(struct device *dev) >>   { >>       struct khadas_mcu_fan_ctx *ctx = dev_get_drvdata(dev); >> +    int ret; >> + >> +    if (ctx->power) { >> +        ret = regulator_enable(ctx->power); >> +        if (ret) >> +            return ret; >> +    } >>         return khadas_mcu_fan_set_level(ctx, ctx->level); >>   } >> > > Thanks, > Neil -- Best regards, Ronald