devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Jun Nie <jun.nie@linaro.org>,
	myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
	cw00.choi@samsung.com
Cc: linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] PM / devfreq: qcom: Introduce CCI devfreq driver
Date: Wed, 1 Feb 2023 10:27:25 +0000	[thread overview]
Message-ID: <d83949e7-d221-a5c1-4e96-19acbeff3d98@linaro.org> (raw)
In-Reply-To: <20230201080227.473547-2-jun.nie@linaro.org>

On 01/02/2023 08:02, Jun Nie wrote:
> Cache Coherent Interconnect (CCI) is used by some Qualcomm SoCs. This
> driver is introduced so that its freqency can be adjusted. And regulator
> associated with opp table can be also adjusted accordingly which is
> shared with cpu cluster.
> 
> Signed-off-by: Jun Nie <jun.nie@linaro.org>

Nice work.

Thanks for taking the time to follow up on this. I had a look at the 
4.19 out-of-tree version of this we have and this code looks just about 
right.

With Krzysztof's comments addressed please add my

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>


  parent reply	other threads:[~2023-02-01 10:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01  8:02 [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm CCI dt-bindings Jun Nie
2023-02-01  8:02 ` [PATCH 2/2] PM / devfreq: qcom: Introduce CCI devfreq driver Jun Nie
2023-02-01  8:48   ` Krzysztof Kozlowski
2023-02-01 15:15     ` Jun Nie
2023-02-01 10:27   ` Bryan O'Donoghue [this message]
2023-02-01 11:02   ` Chanwoo Choi
2023-02-01 15:17     ` Jun Nie
2023-02-01 17:18       ` Dmitry Baryshkov
2023-02-01 11:32   ` Dmitry Baryshkov
2023-02-01 11:46     ` Bryan O'Donoghue
2023-02-01 13:41       ` Dmitry Baryshkov
2023-02-01 14:45         ` Bryan O'Donoghue
2023-02-01 14:58           ` Dmitry Baryshkov
2023-02-01 15:17             ` Bryan O'Donoghue
2023-02-01 17:12               ` Dmitry Baryshkov
2023-02-01 17:16                 ` Bryan O'Donoghue
2023-02-01 17:19                   ` Dmitry Baryshkov
2023-02-02 12:55         ` Jun Nie
2023-02-01 15:23     ` Jun Nie
2023-02-01  8:43 ` [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm CCI dt-bindings Krzysztof Kozlowski
2023-02-02  9:29   ` Jun Nie
2023-02-02  9:42     ` Krzysztof Kozlowski
2023-02-03  3:45       ` Jun Nie
2023-02-03  7:06         ` Krzysztof Kozlowski
2023-02-01 10:46 ` Chanwoo Choi
2023-02-01 14:23 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d83949e7-d221-a5c1-4e96-19acbeff3d98@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jun.nie@linaro.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).