devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Roger Quadros <rogerq@ti.com>
Cc: <aniljoy@cadence.com>, <adouglas@cadence.com>, <nsekhar@ti.com>,
	<jsarha@ti.com>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: phy: ti,phy-j721e-wiz: Add Type-C dir GPIO
Date: Wed, 23 Oct 2019 18:30:26 +0530	[thread overview]
Message-ID: <d8398dc4-cd6c-a3d1-1951-f1ad3d1b3ae3@ti.com> (raw)
In-Reply-To: <20191023084916.26895-3-rogerq@ti.com>

Roger,

On 23/10/19 2:19 PM, Roger Quadros wrote:
> This is an optional GPIO, if specified will be used to
> swap lane 0 and lane 1 based on GPIO status. This is required
> to achieve plug flip support for USB Type-C.
> 
> Type-C companions typically need some time after the cable is
> plugged before and before they reflect the correct status of
> Type-C plug orientation on the DIR line.
> 
> Type-C Spec specifies CC attachment debounce time (tCCDebounce)
> of 100 ms (min) to 200 ms (max).
> 
> Allow the DT node to specify the time (in ms) that we need
> to wait before sampling the DIR line.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
>  .../devicetree/bindings/phy/ti,phy-j721e-wiz.txt         | 9 +++++++++

I've posted new version to change the binding document to YAML format. Can you
make the changes on top of that series?

Thanks
Kishon

>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.txt b/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.txt
> index 19b4c3e855d6..253535a8819f 100644
> --- a/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.txt
> +++ b/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.txt
> @@ -24,6 +24,15 @@ Optional properties:
>  assigned-clocks and assigned-clock-parents: As documented in the generic
>  clock bindings in Documentation/devicetree/bindings/clock/clock-bindings.txt
>  
> + - typec-dir-gpios: GPIO to signal Type-C cable orientation for lane swap.
> +     If GPIO is active, lane 0 and lane 1 of SERDES will be swapped to
> +     achieve the funtionality of an exernal type-C plug flip mux.
> +
> + - typec-dir-debounce: Number of milliseconds to wait before sampling
> +     typec-dir-gpio. If not specified, the GPIO will be sampled ASAP.
> +     Type-C spec states minimum CC pin debounce of 100 ms and maximum
> +     of 200 ms.
> +
>  Required subnodes:
>   - Clock Subnode: WIZ node should have '3' subnodes for each of the clock
>       selects it supports. The clock subnodes should have the following names
> 

  reply	other threads:[~2019-10-23 13:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23  8:49 [PATCH v2 0/3] phy: cadence: j721e-wiz: Add Type-C plug flip support Roger Quadros
2019-10-23  8:49 ` [PATCH v2 1/3] phy: cadence: Sierra: add phy_reset hook Roger Quadros
2019-10-23  8:49 ` [PATCH v2 2/3] dt-bindings: phy: ti,phy-j721e-wiz: Add Type-C dir GPIO Roger Quadros
2019-10-23 13:00   ` Kishon Vijay Abraham I [this message]
2019-10-23  8:49 ` [PATCH v2 3/3] phy: ti: j721e-wiz: Manage typec-gpio-dir Roger Quadros
2019-10-23 12:32 ` [PATCH v2 0/3] phy: cadence: j721e-wiz: Add Type-C plug flip support Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8398dc4-cd6c-a3d1-1951-f1ad3d1b3ae3@ti.com \
    --to=kishon@ti.com \
    --cc=adouglas@cadence.com \
    --cc=aniljoy@cadence.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jsarha@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).