From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA567C433EF for ; Tue, 12 Jul 2022 15:21:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233800AbiGLPVa (ORCPT ); Tue, 12 Jul 2022 11:21:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233014AbiGLPVJ (ORCPT ); Tue, 12 Jul 2022 11:21:09 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5ED5C176A for ; Tue, 12 Jul 2022 08:18:14 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id w2so10266060ljj.7 for ; Tue, 12 Jul 2022 08:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Tj5Gg27gp6guU9o9CDqxeuyaEnEIyrvYSMIuKpk5DD8=; b=tGqKNetCeWXzqGSSNavFzF6GgOnaP8uE2YFx+VXS9WdGV5+5ap7lYe4ilTL/1ca+f+ ouoKcLg2D+XuplmIZ64Lz27n+Eh3j2Ya6E+NSRFRl3bnp1leC9bzqMmv7HUj60q49LET rIvE/HVfZH7a4dyRgaENaiFzB5AsCD1r63XXMdITydVZRxTVBgbNgWAB2rO9AxLLVuaC AzOFcDK+tXjAOimM2VbjoHL+V5TK3gLBOqx+O79eaba0f8hHPr9JyQA8CWPolOaN8rpT 6B9s+95UGjNRSOzF5Y3dhERiewU2/lC5qnFS8oZu/sLrVVw+82sAAOSBpGrbvWYEnvPL 5OrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Tj5Gg27gp6guU9o9CDqxeuyaEnEIyrvYSMIuKpk5DD8=; b=4QCGJlpBY/zi2lGV7dr/LSuMvZkUOV0kUzP6moa4cGqnYecDU42h+EfcvSI8U08dtq 5IhV2A83yXWApbobjSjAT5iyx3UTwP53kg7GCwHp9/nFXLyyJwuSazrmL9sPYaDcap6H XuZr7sivWdYMMC8KMt0hfctbjftZ6i53DvwW0/JxjcXY7CRYBK3i5ihPh8HNWfGqNC0Q mC3uFOmN60RatTwmn8dm4Gq0yrPQGHlZEk/V5ajw+Cl4Ut4YJxrrJyISCv4AlpX+kqzf VRRBfvQxVmMq3opFWH/Hvo2zA/wanv0W7dcXdQzAm7e/4Q3/b/FccLS5bIEU+NhC8m3v 8WMA== X-Gm-Message-State: AJIora+gi5WoTDhwjK+3xoHeL1+PovaSzikVRNSwZYBKhyR1E32M+NEw hnTV4PKLDR1EMiMs3isdnl8LRg== X-Google-Smtp-Source: AGRyM1s3SKYPr8wCbAab/dh6Yo/xp76xDbLfy2u6JUJeWpoicCcLEvo3aAi857vpfyk8jA3cDKyCLA== X-Received: by 2002:a2e:9547:0:b0:24f:2e31:6078 with SMTP id t7-20020a2e9547000000b0024f2e316078mr12469910ljh.102.1657639093026; Tue, 12 Jul 2022 08:18:13 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id o28-20020a198c1c000000b00482bb812713sm2232708lfd.94.2022.07.12.08.18.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jul 2022 08:18:12 -0700 (PDT) Message-ID: Date: Tue, 12 Jul 2022 17:18:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RFC PATCH net-next 2/9] dt-bindings: net: Expand pcs-handle to an array Content-Language: en-US To: Sean Anderson , Heiner Kallweit , Russell King , netdev@vger.kernel.org Cc: Jakub Kicinski , Madalin Bucur , "David S . Miller" , Paolo Abeni , Ioana Ciornei , linux-kernel@vger.kernel.org, Eric Dumazet , Andrew Lunn , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org References: <20220711160519.741990-1-sean.anderson@seco.com> <20220711160519.741990-3-sean.anderson@seco.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/07/2022 17:06, Sean Anderson wrote: > Hi Krzysztof, > > On 7/12/22 4:51 AM, Krzysztof Kozlowski wrote: >> On 11/07/2022 18:05, Sean Anderson wrote: >>> This allows multiple phandles to be specified for pcs-handle, such as >>> when multiple PCSs are present for a single MAC. To differentiate >>> between them, also add a pcs-names property. >>> >>> Signed-off-by: Sean Anderson >>> --- >>> >>> .../devicetree/bindings/net/ethernet-controller.yaml | 7 ++++++- >>> 1 file changed, 6 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml >>> index 4f15463611f8..c033e536f869 100644 >>> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml >>> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml >>> @@ -107,11 +107,16 @@ properties: >>> $ref: "#/properties/phy-connection-type" >>> >>> pcs-handle: >>> - $ref: /schemas/types.yaml#/definitions/phandle >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> description: >>> Specifies a reference to a node representing a PCS PHY device on a MDIO >>> bus to link with an external PHY (phy-handle) if exists. >> >> You need to update all existing bindings and add maxItems:1. >> >>> >>> + pcs-names: >> >> To be consistent with other properties this should be "pcs-handle-names" >> and the other "pcs-handles"... and then actually drop the "handle". > > Sorry, I'm not sure what you're recommending in the second half here. I would be happy to see consistent naming with other xxxs/xxx-names properties, therefore I recommend to: 1. deprecate pcs-handle because anyway the naming is encoding DT spec into the name ("handle"), 2. add new property 'pcs' or 'pcss' (the 's' at the end like clocks but maybe that's too much) with pcs-names. However before implementing this, please wait for more feedback. Maybe Rob or net folks will have different opinions. Best regards, Krzysztof