devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: "Stephen Boyd" <sboyd@kernel.org>,
	devicetree@vger.kernel.org, jonas.gorski@gmail.com,
	krzysztof.kozlowski+dt@linaro.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, mturquette@baylibre.com,
	p.zabel@pengutronix.de, robh+dt@kernel.org,
	william.zhang@broadcom.com,
	"Álvaro Fernández Rojas" <noltari@gmail.com>
Subject: Re: [PATCH v3 4/4] clk: bcm: Add BCM63268 timer clock and reset driver
Date: Wed, 22 Mar 2023 10:18:18 -0700	[thread overview]
Message-ID: <d84a84d7-f065-8ac6-fb21-20a0c9af6c14@gmail.com> (raw)
In-Reply-To: <896d16997cf3d308eff0cb8ce8596fc3.sboyd@kernel.org>

On 3/21/23 16:23, Stephen Boyd wrote:
> Quoting Florian Fainelli (2023-03-21 16:09:54)
>> On 3/21/23 16:06, Stephen Boyd wrote:
>>> Quoting Florian Fainelli (2023-03-21 16:00:29)
>>>>
>>>> These SoCs are big-endian, require native endian register access and
>>>> have no posted writes within their bus logic (UBUS) and require no
>>>> barriers, hence the use of __raw_readl() and __raw_writel() is adequate.
>>>>
>>>
>>> Use ioread32be() then?
>>
>> BCM63xx drivers tend to use __raw_{read,write}l for consistency and to
>> make it clear that no barriers, no endian swapping is necessary, I would
>> prefer to remain consistent with that convention.
> 
> Ok.
> 
> Is the clk device big-endian? Or the CPU is big-endian? SoC being
> big-endian sounds like the devices in the SoC are big-endian. I hope we
> never plop this device down with a CPU that's litle-endian.

The CPU is big endian and the peripheral and bus to access the 
peripheral are native endian, so also big endian in that case.

The newer SoCs are ARM-based and are little endian, but we already have 
a clock driver for those.
-- 
Florian


  parent reply	other threads:[~2023-03-22 17:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 12:26 [PATCH v2 0/4] clk: add BCM63268 timer clock and reset Álvaro Fernández Rojas
2021-03-15 12:26 ` [PATCH v2 1/4] dt-bindings: clk: add BCM63268 timer clock definitions Álvaro Fernández Rojas
2021-03-15 12:26 ` [PATCH v2 2/4] dt-bindings: reset: add BCM63268 timer reset definitions Álvaro Fernández Rojas
2021-03-15 12:26 ` [PATCH v2 3/4] dt-bindings: clock: Add BCM63268 timer binding Álvaro Fernández Rojas
2021-03-15 12:26 ` [PATCH v2 4/4] clk: bcm: Add BCM63268 timer clock and reset driver Álvaro Fernández Rojas
2023-03-21 20:10 ` [PATCH v3 0/4] clk: add BCM63268 timer clock and reset Álvaro Fernández Rojas
2023-03-21 20:10   ` [PATCH v3 1/4] dt-bindings: clk: add BCM63268 timer clock definitions Álvaro Fernández Rojas
2023-03-21 20:10   ` [PATCH v3 2/4] dt-bindings: reset: add BCM63268 timer reset definitions Álvaro Fernández Rojas
2023-03-21 20:10   ` [PATCH v3 3/4] dt-bindings: clock: Add BCM63268 timer binding Álvaro Fernández Rojas
2023-03-21 20:10   ` [PATCH v3 4/4] clk: bcm: Add BCM63268 timer clock and reset driver Álvaro Fernández Rojas
2023-03-21 22:57     ` Stephen Boyd
2023-03-21 23:00       ` Florian Fainelli
2023-03-21 23:06         ` Stephen Boyd
2023-03-21 23:09           ` Florian Fainelli
2023-03-21 23:23             ` Stephen Boyd
2023-03-22 17:17               ` Álvaro Fernández Rojas
2023-03-22 17:18               ` Florian Fainelli [this message]
2023-03-21 22:54   ` [PATCH v3 0/4] clk: add BCM63268 timer clock and reset Stephen Boyd
2023-03-22 17:18     ` Álvaro Fernández Rojas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d84a84d7-f065-8ac6-fb21-20a0c9af6c14@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonas.gorski@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=noltari@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=william.zhang@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).