From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Daehwan Jung <dh10.jung@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Felipe Balbi <balbi@kernel.org>
Cc: "open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
sc.suh@samsung.com, taehyun.cho@samsung.com,
jh0801.jung@samsung.com, eomji.oh@samsung.com
Subject: Re: [RFC PATCH v2 2/3] dt-bindings: usb: generic-xhci: add Samsung Exynos compatible
Date: Thu, 29 Dec 2022 11:19:09 +0100 [thread overview]
Message-ID: <d84f46f5-9975-cde2-0b56-b51990e27150@linaro.org> (raw)
In-Reply-To: <1672307866-25839-3-git-send-email-dh10.jung@samsung.com>
On 29/12/2022 10:57, Daehwan Jung wrote:
> Add compatible for Samsung Exynos SOCs
Missing full stop. Please explain here in details the hardware.
Otherwise it looks it is not for any hardware and patch should be dropped.
Also, missing DTS. I am going to keep NAK-ing this till you provide the
user.
NAK.
>
> Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
> ---
> Documentation/devicetree/bindings/usb/generic-xhci.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/generic-xhci.yaml b/Documentation/devicetree/bindings/usb/generic-xhci.yaml
> index db841589fc33..f54aff477637 100644
> --- a/Documentation/devicetree/bindings/usb/generic-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-xhci.yaml
> @@ -29,6 +29,8 @@ properties:
> enum:
> - brcm,xhci-brcm-v2
> - brcm,bcm7445-xhci
> + - description: Samsung Exynos SoCs with xHCI
> + const: samsung,exynos-xhci
Missing fallback.
> - description: Generic xHCI device> const: xhci-platform
> deprecated: true
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-29 10:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221229100409epcas2p123de28f73dfb4d7429d0e15e41bb13a7@epcas2p1.samsung.com>
2022-12-29 9:57 ` [RFC PATCH v2 0/3] support Samsung Exynos xHCI Controller Daehwan Jung
[not found] ` <CGME20221229100413epcas2p34c702faf8c96d207cf1659b1173f8858@epcas2p3.samsung.com>
2022-12-29 9:57 ` [RFC PATCH v2 1/3] usb: " Daehwan Jung
2022-12-29 10:25 ` Krzysztof Kozlowski
2023-01-02 6:24 ` Jung Daehwan
2023-01-02 8:30 ` Krzysztof Kozlowski
2022-12-29 14:44 ` Arnd Bergmann
2023-01-02 6:35 ` Jung Daehwan
[not found] ` <CGME20221229100416epcas2p3614b693ab922aadbdc76c0387f768de9@epcas2p3.samsung.com>
2022-12-29 9:57 ` [RFC PATCH v2 2/3] dt-bindings: usb: generic-xhci: add Samsung Exynos compatible Daehwan Jung
2022-12-29 10:19 ` Krzysztof Kozlowski [this message]
2023-01-02 5:30 ` Jung Daehwan
2023-01-02 8:27 ` Krzysztof Kozlowski
[not found] ` <CGME20221229100416epcas2p18f7600737b8f4149a1d75d2d8db3317a@epcas2p1.samsung.com>
2022-12-29 9:57 ` [RFC PATCH v2 3/3] dt-bindings: usb: snps,dwc3: add generic-xhci as child Daehwan Jung
2022-12-29 10:23 ` Krzysztof Kozlowski
2023-01-02 5:45 ` Jung Daehwan
2023-01-03 18:52 ` Rob Herring
2022-12-30 16:34 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d84f46f5-9975-cde2-0b56-b51990e27150@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dh10.jung@samsung.com \
--cc=eomji.oh@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jh0801.jung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=robh+dt@kernel.org \
--cc=sc.suh@samsung.com \
--cc=taehyun.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).