Re: [PATCH] dt-bindings: firmware: arm,scpi: Add missing maxItems to shmem property

[Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>]

On 16/02/2022 14:42, Geert Uytterhoeven wrote:
> Hi Krzysztof,
> 
> On Wed, Feb 16, 2022 at 2:39 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>> On 16/02/2022 14:21, Geert Uytterhoeven wrote:
>>> "make dt_binding_check":
>>>
>>>     Documentation/devicetree/bindings/firmware/arm,scpi.example.dt.yaml: scpi: shmem: [[2], [1]] is too long
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>> ---
>>> Exposed by commit 39bd2b6a3783b899 ("dt-bindings: Improve phandle-array
>>> schemas").
>>> ---
>>>  Documentation/devicetree/bindings/firmware/arm,scpi.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
>>> index 800417a76bda0bd9..3735f221fdf24e0a 100644
>>> --- a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
>>> +++ b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
>>> @@ -51,6 +51,7 @@ properties:
>>>        be any memory reserved for the purpose of this communication between the
>>>        processors.
>>>      minItems: 1
>>> +    maxItems: 2
>>
>> The same should be done to "mboxes" (I mean 39bd2b6a3783b899 and what
>> you are doing here)
> 
> Indeed, thanks!
> 
>> and the maxItems should match both, shouldn't it?
> 
> No idea, I'm not familiar with SCPI ;-)

Neither I am. The driver though counts number of mboxes and then loops
till that number to get each shmem device node. The driver does not
limit number of mboxes or shmem to 2, but will fail if they are not equal.

Best regards,
Krzysztof