From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 484324E1C75 for ; Thu, 17 Sep 2026 12:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789648678; cv=none; b=Qb9+90GlR6SWWeq47W2Hqg0OLyS7A9rSJyOrsX5q/P5wCQnAAq1htOLuqp9lOds1381q4jRJsgb3UOUhfr0gns2rjIQilabnDXSidZ2kLXMJI19xjZzxXbV8CY/Ngzk2gS7fhT8flwBZrEQ3BWrLoROAloBSRnAawuRUzEEFXUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789648678; c=relaxed/simple; bh=SnMHYeXiWguGfxVXceu+bBQETBsAqvaJWpMi6JFepAY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nEcaM20aMK9KsRTjqyXzvW2IAG64eVtVu+zDt1o31KZjiyZI0pUp94SW2t0mDGPIX5od7S5PRSnSc7Du3rW4lw8lyCmIczRXm/Hem+rshK17pTHCtCROrxLhcVSNzU5tSIjDR+sCIKX0yD3JFpCsASuHb5CFEKkSVq2SkE/TqsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TUb6sH19; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=al0pQ+FK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TUb6sH19"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="al0pQ+FK" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68H9ZtWf1390189 for ; Thu, 17 Sep 2026 12:37:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OjSRMZDcecv5N4PzfaSL6P3SNko4UxD+X15iRKhspJs=; b=TUb6sH19bLlZlDwy Mwo5Lv56rfGtp7Vmhcfe2xXoPNZgfJXpcJjNC8VbYcVVL4Smb6JqSC3AUSPIgGoA mxPBZYWKv1cTvHKwGmlEAiw/kh1OFz3PQefDJTJe+Dq6QxmV+/BW133xZcWGdqxV rxPRTF7P8eunvg4hYfT4xwf7bwSahkJwxRazLuIZx4BFFu3SQTbABJAd1rgzo+Yp xwIJaZkA/C6VLaUcCQ5zGonN2GpOUOIB4cGWbGj+aIwdDfJKxphFWFcAjDi8Ucj7 tqfSmAeoj/PCvURBsQq9t6kAepbTbXtDIqitLc81aiSzRpjteMN88xL8rxmwtOa9 e7iygw== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqy2d4cxv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 17 Sep 2026 12:37:51 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-9106fce784dso14221966d6.2 for ; Thu, 17 Sep 2026 05:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789648670; x=1790253470; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=OjSRMZDcecv5N4PzfaSL6P3SNko4UxD+X15iRKhspJs=; b=al0pQ+FK3kfp2OdVVXBUJ6uIcUbYCv2OFJ66PY9E9mW04S7clBmgBNqShJO5bawNmD 8myT08Ejx1A1dBudf6RnoYxQB2VMD9lOUfe6j1TjHvJ7YwJCOuxVGElW3tIztPTi2mZ+ Lb9/mN7eW1yFTZDle58drJAe92cHwyBenpNGTQz7Qn6No+jzmyx/eCKto/FNx3lVbUuT +kjU/h3iSE9KmLRSb72KtlYBJRoeoTc/fSrgERv5xEowgSKUjQwDdkVrPllRWavV9DwN K7X3NADR5J4Jnt/aVhyxK1Kq4l5kzY/fPXyKcaQJJASH3X/YoUngbEh3/J4Q22vujq3j 9AGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789648670; x=1790253470; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OjSRMZDcecv5N4PzfaSL6P3SNko4UxD+X15iRKhspJs=; b=fqytPiLDtIUXc9n6H+6gYlhylDgkkpcTFxvbowg+nrYdBVseWcgsswnjrqQow/KzeQ pIiWswl6RVq5outL64Xf29O7hfAqtETtFlmNws/3QkGdfNqCPDnYfVTC3XV/4I++2pk9 SHJ6JIHAX8M3/rQ8zITU+xPrilApVZp2anQfKHwTtRjdjZmFvK4dcwIAYW8AV2/hWoX3 JdF8GtF2KyjhkoJHH2WwOB38rrosMhZAj0+BXXEdJ6MizifXqYSPmS1pFo55WqHpFjd2 a8Quwqi8xasIwK9I1Ni7mq3tW5FiEDRBWvphiEHo7tj4vo4eDxdsT49j5X4IfFtZ4TDv BlAw== X-Forwarded-Encrypted: i=1; AKwUvBzAb55XZ0Z6dvyl9xEfpYuyIVL/Oe0QMZ/DQ6eXjGWTVUOyp4dR+DzjkAw1vJ4Abe1ZQIWh5U047u7i@vger.kernel.org X-Gm-Message-State: AFuF++mwNulrmSTTFQkErsZ+B7QvueYDmJ5VFtP7877TfnbH2CVqm4Ym c1zvpGsHVkW/sNO3nrREefRQBxo4AfgJorjGLeJjgmp+ch+s3lvPD4bIuKUBYDtOVmS60vdCA6P 4I8LC9a6tk0XBynlR7Z213Pi4LRkpa4DHoRi8PG33USoSOB5AFw+wm8MX+q5Y5+fR X-Gm-Gg: AYBFou3OdFzLTKZUqaCYegDtRs2pm6ezP/EWOXgTLQfhy1oImlQM0Rg0JDpyHLuD6iz nw1yc6JIl0q7FnHrSEGA33aezQ0i9oEkYen3gPWygP+4zb5m+pX6ROur6eXzkscvUiadYxGPBWB 5L9iRMNjMenrrE64PbrskDjR1K/WUm4B6vhzxfSdyhe28PM9U4TEXzRDMo9RMJekNU3JD5boJE6 jx9aQ8g1wHIWzU79XgIhcundjZLYX5Dj4/KKwaxxVGU4MLUww2wsSyIZ5I7ZrSQkCnGHO4adolL 4LaXh9AS0a6jUPMX2z8TYuVBOzkBrR4eKVDSKZwOq0ZnRN6Bv5Iy+He+Zy2LAA/uS8kNgVWPpiY Fo+VCNgHb83lzC22eykUbcsAAx0WuR7Nz2Ue6HleLRhlJ/1GXUjEqTJUHL5Rr/24= X-Received: by 2002:ad4:5ec9:0:b0:90c:5947:7e64 with SMTP id 6a1803df08f44-9123d703456mr137304986d6.3.1789648670066; Thu, 17 Sep 2026 05:37:50 -0700 (PDT) X-Received: by 2002:ad4:5ec9:0:b0:90c:5947:7e64 with SMTP id 6a1803df08f44-9123d703456mr137304136d6.3.1789648669428; Thu, 17 Sep 2026 05:37:49 -0700 (PDT) Received: from [10.38.246.218] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9123be5fcb5sm49155906d6.11.2026.09.17.05.37.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2026 05:37:48 -0700 (PDT) Message-ID: Date: Thu, 17 Sep 2026 20:37:42 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] dt-bindings: media: Add bindings for qcom,nord-camss To: Krzysztof Kozlowski Cc: Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260915-nord-v1-0-20db41a7f1ff@oss.qualcomm.com> <20260915-nord-v1-1-20db41a7f1ff@oss.qualcomm.com> <20260917-active-strong-emu-bf8fbd@quoll> From: Wenmeng Liu In-Reply-To: <20260917-active-strong-emu-bf8fbd@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: sATRT3PFpnB_QXXzfZ1sXkAk4l-xTnPp X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE3MDE3NiBTYWx0ZWRfXzBCmW6f49EvH TiDw9KAr/KcjmB/BrVESb4xhNcOFzqyZ2znWA5cyaXN22DCcGD+Z2Cc2HhdRJoc/Uzgv4HrOrBQ Ln8qdmib/5TI8EkuzTtmtzvkZlZZAw0= X-Authority-Analysis: v=2.4 cv=HbeB3SE8 c=1 sm=1 tr=0 ts=6aabdf1f cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=yKxla6SPEuOvPVJYePEA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: sATRT3PFpnB_QXXzfZ1sXkAk4l-xTnPp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE3MDE3NiBTYWx0ZWRfXwcZgtjWQL8Yw WzaCqupCKrtaD7G7ACclnMd3RcETDvMExd9qrS06CNN9d+oyggLnyM5xTDLLyLWNjwk1v9HErBC YlvKIEmTe+NyUqi8NIYjSltVLhOdqMGHLHp3sDVR7QyaP4WwYJoiZHPaVOM39pEmVcLVjILQgpH 01KdojR5Zqi75fcXUd4JNJlB4wy3KhMNldjj5DbkdlCaSDp5gX0N82Fb+fRtGHHJb4dNOFZmgLR NLnCVKNl8Bbwys9NviaXToiyuDfmeHURxsT7KXkyk8LoZVro7AkHKcDCF9rqu5KdngOAvkFZVp9 DpRGu9qtWlGbD4H1CHZDeXU4AJqbTRIHmZM7WrQ9cPvrUnJAwV0/L0vj02J288gA1rqV6HxMevf a4pz+oRjcifo265fEscsXFYLpYCKEucZ+mgiNAnfGPMqEKcZh5PQ8vu8++1xEgwxoogIUVCDBNy yj/25jQGy/ZjOOgwYtQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-17_02,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609170176 Hi Krzysztof, On 9/17/2026 6:13 PM, Krzysztof Kozlowski wrote: > On Tue, Sep 15, 2026 at 05:34:11PM +0800, Wenmeng Liu wrote: >> Add bindings for the camera subsystem (CAMSS) on the Qualcomm Nord >> platform. >> >> The Nord platform provides: >> - 3 x TPG (Test Pattern Generator) >> - 3 x CSID (CSI Decoder) >> - 10 x CSID Lite >> - 3 x VFE (Video Front End) >> - 10 x VFE Lite >> >> Signed-off-by: Wenmeng Liu >> --- >> .../devicetree/bindings/media/qcom,nord-camss.yaml | 393 +++++++++++++++++++++ >> 1 file changed, 393 insertions(+) > > A nit, subject: drop second/last, redundant "bindings for". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23 > ACK > ... > >> + description: >> + Input port for receiving CSI data. >> + >> + properties: >> + endpoint: >> + $ref: video-interfaces.yaml# >> + unevaluatedProperties: false >> + >> + properties: >> + data-lanes: >> + minItems: 1 >> + maxItems: 4 >> + >> + bus-type: >> + enum: >> + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY >> + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY >> + >> + required: >> + - data-lanes >> + > > Missing supplies, altough maybe this is related to some other ongoing > work, so would be useful to see explanation in commit msg. At the moment, the Nord platform only supports TPG. Perhaps I should remove this part of the change for now and reintroduce it later when CSIPHY support is available, once the EVK board is ready. Anyway, I will explanation in commit msg next version. Thanks, Wenmeng