From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH v3 3/5] mtd: aspeed: used a label property Date: Mon, 12 Dec 2016 03:27:00 +0100 Message-ID: References: <1481302167-28044-1-git-send-email-clg@kaod.org> <1481302167-28044-4-git-send-email-clg@kaod.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Joel Stanley , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, David Woodhouse , Brian Norris , Boris Brezillon , Richard Weinberger , Cyrille Pitchen , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Mark Rutland List-Id: devicetree@vger.kernel.org On 12/12/2016 12:46 AM, Joel Stanley wrote: > On Sat, Dec 10, 2016 at 3:49 AM, Cédric Le Goater wrote: >> This can be used to easily identify a chip on a system with multiple >> chips. >> >> Signed-off-by: Cédric Le Goater > > Our userspace benefits from having this. > > Acked-by: Joel Stanley Shouldn't such thing be part of core code then ? >> --- >> drivers/mtd/spi-nor/aspeed-smc.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c >> index 99302b0d7786..9119c0ca86b6 100644 >> --- a/drivers/mtd/spi-nor/aspeed-smc.c >> +++ b/drivers/mtd/spi-nor/aspeed-smc.c >> @@ -676,6 +676,8 @@ static int aspeed_smc_setup_flash(struct aspeed_smc_controller *controller, >> nor->prepare = aspeed_smc_prep; >> nor->unprepare = aspeed_smc_unprep; >> >> + mtd->name = of_get_property(child, "label", NULL); >> + >> ret = aspeed_smc_chip_setup_init(chip, r); >> if (ret) >> break; >> -- >> 2.7.4 >> -- Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html