From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from spam.coasia.com (mail2.coasia.com [112.168.119.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D53D3218EB7 for ; Mon, 21 Jul 2025 04:32:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=112.168.119.159 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753072341; cv=none; b=qMBKLibUBuYusX1gdMQ1zYbWXGlED0hjVMCmBmj+IqJgyaSkhJFEezKZ9T95E432j0uFGdVvWu2giXpY2G0Fqb+BZG2YOFjs2NO8FuzUoKx6/P3XpHFnW3xPXzn9iDUweWrd653Bq+OZ4y+ZHL4QwVJP3f1Su61TbYMuXomCik4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753072341; c=relaxed/simple; bh=fkkRCoPbO262N6nh5T1e3WS51jJoTMENI1DUO2zY2Qs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=eDpgI2cPcxkuuWCWsy6cY5FDMdT7uJOPiVKbNyUzUYAyDZ32aG6ErxqdmxV3aQRQx+hVA6Xozb15zAMP6QGneOutxkZnFVM8uXbLeBK80SZ87NnIvG3cV8gjPtd5F9ejnDRfgWcwz719D9Eju4UordX3kZgEQtQ/jzkeIKgJErA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=coasia.com; spf=pass smtp.mailfrom=coasia.com; dkim=pass (1024-bit key) header.d=coasia.com header.i=@coasia.com header.b=tgvv69//; arc=none smtp.client-ip=112.168.119.159 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=coasia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=coasia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=coasia.com header.i=@coasia.com header.b="tgvv69//" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=coasia.com; s=coasia; t=1753072336; bh=fkkRCoPbO262N6nh5T1e3WS51jJoTMENI1DUO2zY2Qs=; l=1861; h=Message-ID:Subject:From:To:Date:Content-Type:MIME-Version; b=tgvv69//Fs2/46nT31h2p0wGINamYYhDrCg79CyxUey8MTdRF1HJGc/TKxIYA5Rc0 XlNgTsN+sZhzN3g1aJ5a+q8qXiGKCc3wsewQxj5nCw5eyP5Y+xniRugyr7dvH5dIjW tZ4Mxu35CtyS0zkANrBXcO1f39m/BIYPhB2j5YR4= Received: from unknown (HELO ?192.168.1.65?) (119.65.249.123) by 192.168.10.159 with ESMTP; 21 Jul 2025 13:32:16 +0900 X-Original-SENDERIP: 119.65.249.123 X-Original-SENDERCOUNTRY: KR, South Korea X-Original-MAILFROM: hgkim05@coasia.com X-Original-RCPTTO: linus.walleij@linaro.org, ksk4725@coasia.com, jesper.nilsson@axis.com, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, krzk@kernel.org, s.nawrocki@samsung.com, cw00.choi@samsung.com, alim.akhtar@samsung.com, tomasz.figa@gmail.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, kenkim@coasia.com, pjsin865@coasia.com, gwk1013@coasia.com, mingyoungbo@coasia.com, smn1196@coasia.com, pankaj.dubey@samsung.com, shradha.t@samsung.com, ravi.patel@samsung.com, inbaraj.e@samsung.com, swathi.ks@samsung.com, hrishikesh.d@samsung.com, dj76.yang@samsung.com, hypmean.kim@samsung.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@axis.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, soc@lists.linux.dev Message-ID: Subject: Re: [PATCH 00/16] Add support for the Axis ARTPEC-8 SoC From: Hakyeong Kim To: Linus Walleij , ksk4725@coasia.com Cc: Jesper Nilsson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Tomasz Figa , Catalin Marinas , Will Deacon , Arnd Bergmann , kenkim , Jongshin Park , GunWoo Kim , GyoungBo Min , SungMin Park , Pankaj Dubey , Shradha Todi , Ravi Patel , Inbaraj E , Swathi K S , Hrishikesh , Dongjin Yang , Sang Min Kim , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@axis.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, soc@lists.linux.dev Date: Mon, 21 Jul 2025 13:32:17 +0900 In-Reply-To: References: <20250710002047.1573841-1-ksk4725@coasia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2025-07-12 at 21:26 +0200, Linus Walleij wrote: > Hi Hakyeong, >=20 > thanks for your patch! >=20 > On Thu, Jul 10, 2025 at 2:20=E2=80=AFAM wrote: >=20 > > Add basic support for the Axis ARTPEC-8 SoC. > > This SoC contains four Cortex-A53 CPUs and other several IPs. > >=20 > > Patches 1 to 10 provide the support for the clock controller, > > which is similar to other Samsung SoCs. > >=20 > > The remaining patches provide pinctrl support and > > initial device tree support. > >=20 > > Hakyeong Kim (9): > > =C2=A0 dt-bindings: clock: Add ARTPEC-8 CMU bindings > > =C2=A0 clk: samsung: Add clock PLL support for ARTPEC-8 SoC > > =C2=A0 clk: samsung: artpec-8: Add initial clock support > > =C2=A0 clk: samsung: artpec-8: Add clock support for CMU_CMU block > > =C2=A0 clk: samsung: artpec-8: Add clock support for CMU_BUS block > > =C2=A0 clk: samsung: artpec-8: Add clock support for CMU_CORE block > > =C2=A0 clk: samsung: artpec-8: Add clock support for CMU_CPUCL block > > =C2=A0 clk: samsung: artpec-8: Add clock support for CMU_FSYS block > > =C2=A0 clk: samsung: artpec-8: Add clock support for CMU_PERI block >=20 > Out of the 9 patches there are 7 patches related to "CMU" without > any explanation or even expansion of this acronym. >=20 > Camera Management Unit? I think I'm not supposed to > guess. Is is an Axis-custom piece of hardware? (Would make > sense.) >=20 > Please expand this acronym and state clearly that (if this > is a correct assumption) that you are not supplying any > bindings and even less a driver for the "CMU" thing, just the > clocks. (That's fine the actual CMU can come later, but > it should be clear *what* it is.) Ok, I will add CMU abbreviation on cover-letter and respective patches. Thanks, Hakyeong Kim >=20 > Yours, > Linus Walleij