devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 4/4] dt-bindings: display: panel: mipi-dbi-spi: Add io-supply
@ 2022-11-25 18:02 Otto Pflüger
  2022-11-27 12:55 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Otto Pflüger @ 2022-11-25 18:02 UTC (permalink / raw)
  To: Noralf Trønnes, Thierry Reding, Sam Ravnborg, David Airlie,
	Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, dri-devel,
	devicetree, linux-kernel

Add the new io-supply property, which specifies the regulator for
the I/O voltage supply on platforms where the panel panel power and
I/O supplies are separate.

Signed-off-by: Otto Pflüger <affenull2345@gmail.com>
---
  .../bindings/display/panel/panel-mipi-dbi-spi.yaml        | 8 +++++++-
  1 file changed, 7 insertions(+), 1 deletion(-)

diff --git 
a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml 
b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
index d55bf12ecead..68cbdfab5438 100644
--- 
a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
+++ 
b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
@@ -22,8 +22,9 @@ description: |
    The standard defines the following interface signals for type C:
    - Power:
      - Vdd: Power supply for display module
+      Called power-supply in this binding.
      - Vddi: Logic level supply for interface signals
-    Combined into one in this binding called: power-supply
+      Called io-supply in this binding.
    - Interface:
      - CSx: Chip select
      - SCL: Serial clock
@@ -80,6 +81,11 @@ properties:
        Controller data/command selection (D/CX) in 4-line SPI mode.
        If not set, the controller is in 3-line SPI mode.

+  io-supply:
+    description: |
+      Logic level supply for interface signals (Vddi).
+      No need to set if this is the same as power-supply.
+
    power-supply:
      description: Power supply for the display module (Vdd).

-- 
2.30.2

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH 1/4] drm/mipi-dbi: Support separate I/O regulator
@ 2022-11-27 19:14 Otto Pflüger
  2022-11-27 19:14 ` [PATCH 4/4] dt-bindings: display: panel: mipi-dbi-spi: Add io-supply Otto Pflüger
  0 siblings, 1 reply; 3+ messages in thread
From: Otto Pflüger @ 2022-11-27 19:14 UTC (permalink / raw)
  To: Noralf Trønnes, Thierry Reding, Sam Ravnborg, David Airlie,
	Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, dri-devel,
	devicetree, linux-kernel
  Cc: Otto Pflüger

The MIPI DBI specification defines separate vdd (panel power) and
vddi (I/O voltage) supplies. Displays that require different voltages
for the different supplies do exist, so the supplies cannot be
combined into one as they are now. Add a new io_regulator property to
the mipi_dbi_dev struct which can be set by the panel driver along
with the regulator property.

Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de>
---
 drivers/gpu/drm/drm_mipi_dbi.c | 14 ++++++++++++++
 include/drm/drm_mipi_dbi.h     |  7 ++++++-
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c
index a6ac56580876..047cab93a041 100644
--- a/drivers/gpu/drm/drm_mipi_dbi.c
+++ b/drivers/gpu/drm/drm_mipi_dbi.c
@@ -427,6 +427,8 @@ void mipi_dbi_pipe_disable(struct drm_simple_display_pipe *pipe)
 
 	if (dbidev->regulator)
 		regulator_disable(dbidev->regulator);
+	if (dbidev->io_regulator)
+		regulator_disable(dbidev->io_regulator);
 }
 EXPORT_SYMBOL(mipi_dbi_pipe_disable);
 
@@ -652,6 +654,16 @@ static int mipi_dbi_poweron_reset_conditional(struct mipi_dbi_dev *dbidev, bool
 		}
 	}
 
+	if (dbidev->io_regulator) {
+		ret = regulator_enable(dbidev->io_regulator);
+		if (ret) {
+			DRM_DEV_ERROR(dev, "Failed to enable I/O regulator (%d)\n", ret);
+			if (dbidev->regulator)
+				regulator_disable(dbidev->regulator);
+			return ret;
+		}
+	}
+
 	if (cond && mipi_dbi_display_is_on(dbi))
 		return 1;
 
@@ -661,6 +673,8 @@ static int mipi_dbi_poweron_reset_conditional(struct mipi_dbi_dev *dbidev, bool
 		DRM_DEV_ERROR(dev, "Failed to send reset command (%d)\n", ret);
 		if (dbidev->regulator)
 			regulator_disable(dbidev->regulator);
+		if (dbidev->io_regulator)
+			regulator_disable(dbidev->io_regulator);
 		return ret;
 	}
 
diff --git a/include/drm/drm_mipi_dbi.h b/include/drm/drm_mipi_dbi.h
index 14eaecb1825c..e4efbd8ffc9d 100644
--- a/include/drm/drm_mipi_dbi.h
+++ b/include/drm/drm_mipi_dbi.h
@@ -122,10 +122,15 @@ struct mipi_dbi_dev {
 	struct backlight_device *backlight;
 
 	/**
-	 * @regulator: power regulator (optional)
+	 * @regulator: power regulator (Vdd) (optional)
 	 */
 	struct regulator *regulator;
 
+	/**
+	 * @io_regulator: I/O power regulator (Vddi) (optional)
+	 */
+	struct regulator *io_regulator;
+
 	/**
 	 * @dbi: MIPI DBI interface
 	 */
-- 
2.30.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-27 19:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-25 18:02 [PATCH 4/4] dt-bindings: display: panel: mipi-dbi-spi: Add io-supply Otto Pflüger
2022-11-27 12:55 ` Krzysztof Kozlowski
  -- strict thread matches above, loose matches on Subject: below --
2022-11-27 19:14 [PATCH 1/4] drm/mipi-dbi: Support separate I/O regulator Otto Pflüger
2022-11-27 19:14 ` [PATCH 4/4] dt-bindings: display: panel: mipi-dbi-spi: Add io-supply Otto Pflüger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).