From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D60F8C433EF for ; Tue, 12 Jul 2022 07:49:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232444AbiGLHtw (ORCPT ); Tue, 12 Jul 2022 03:49:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232452AbiGLHtv (ORCPT ); Tue, 12 Jul 2022 03:49:51 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13D189CE04 for ; Tue, 12 Jul 2022 00:49:49 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id r9so4553584lfp.10 for ; Tue, 12 Jul 2022 00:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=2nzDFbOQzhmz/22ypvi14S91HEzakYKEGdQDyNBSOY0=; b=K30R07foS4PkukDYXfgfRdxcfQzZ64mmEDIA6OE83yNtpTLbK8Udhtk0b3VVYLuZS9 UiQkWpBULMSMpVR31zKATQCzrGu88YL3TrLc0mJcR+PbGfuZfeTHHs4QDC/QE637RGGt WraEEELQODV/pnxsZnEYkD6IDistT9vRbgCdT8KvmfKAvsFqaZKYTZbupKb1Sp8zi5Sl tRGbeYB0wb6WXZM6KBBFchFAfPNFB3hRgw6Ron2oAOBCfv/nbI2+tj6mnPq2FW9pdRE0 QQqe1L/r+Nc0dKqFilENciRUBIUElXWR8YvBqFmcuGv3SAo6cSnOC0HHw7jVjmscOWpg arTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2nzDFbOQzhmz/22ypvi14S91HEzakYKEGdQDyNBSOY0=; b=qronk/INzzgPOy+xrj6mZPfbOniXz9yKyr++pjSQczWGUiAx9VHJNyCYpn4Rll/6qw M3Tv4zhxaf5xs/OlfqeG0picvBDHs9YT1Gay4bcMAez3QH2O9eH/BWc468tFFJxI+z2r 6pcfpn1XGgg+VmKqyC469qN5Sqgw4WZJENA3Ut/9qeNWSzmZpOPpRAygHZ6qE6n+rEeM yWpMmd27wgq/Q7i656seR1TGm1xpUAXrn/1AiPK20QIJ46rwOBNcnqLCRsm93B931mI7 9iyWMkLyzmBkG4Najdlf9iIDQNwrEbgjLiNG6YZ+6J5ooig34/a7qMAJQS1CYMmRfGw1 v5ZA== X-Gm-Message-State: AJIora8J+X2tV7+ohN3n+vr7+LQRxs4iAupFWjuPytwOag0F9Oa8jhUp SY9871kDwR5n/nq11GG5uvMHtw== X-Google-Smtp-Source: AGRyM1s7uIrC/au+kDw8CXEA5rnjdHYxZZLGJ3RZwoUeDyjJUKUk9riccSMB5BuxMqz1v2e3X9Qz9A== X-Received: by 2002:a05:6512:2306:b0:485:8e08:5740 with SMTP id o6-20020a056512230600b004858e085740mr14669012lfu.354.1657612187373; Tue, 12 Jul 2022 00:49:47 -0700 (PDT) Received: from [10.0.0.8] (fwa5cab-55.bb.online.no. [88.92.171.55]) by smtp.gmail.com with ESMTPSA id j6-20020a2e3c06000000b0025d5b505df1sm2268080lja.136.2022.07.12.00.49.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jul 2022 00:49:46 -0700 (PDT) Message-ID: Date: Tue, 12 Jul 2022 09:49:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 6/7] dt-bindings: media: Add i.MX8 ISI DT bindings Content-Language: en-US To: Laurent Pinchart , linux-media@vger.kernel.org Cc: Sakari Ailus , Hans Verkuil , Jacopo Mondi , Xavier Roumegue , linux-imx@nxp.com, kernel@pengutronix.de, devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski References: <20220712000251.13607-1-laurent.pinchart@ideasonboard.com> <20220712000251.13607-7-laurent.pinchart@ideasonboard.com> From: Krzysztof Kozlowski In-Reply-To: <20220712000251.13607-7-laurent.pinchart@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/07/2022 02:02, Laurent Pinchart wrote: > The Image Sensing Interface (ISI) combines image processing pipelines > with DMA engines to process and capture frames originating from a > variety of sources. The inputs to the ISI go through Pixel Link > interfaces, and their number and nature is SoC-dependent. They cover > both capture interfaces (MIPI CSI-2 RX, HDMI RX) and memory inputs. > > Signed-off-by: Laurent Pinchart > --- > Changes since v1: > > - Fix compatible string checks in conditional schema > - Fix interrupts property handling > --- > .../bindings/media/nxp,imx8-isi.yaml | 148 ++++++++++++++++++ > 1 file changed, 148 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml > new file mode 100644 > index 000000000000..390dfa03026b > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml > @@ -0,0 +1,148 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/nxp,imx8-isi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: i.MX8 Image Sensing Interface > + > +maintainers: > + - Laurent Pinchart > + > +description: | > + The Image Sensing Interface (ISI) combines image processing pipelines with > + DMA engines to process and capture frames originating from a variety of > + sources. The inputs to the ISI go through Pixel Link interfaces, and their > + number and nature is SoC-dependent. They cover both capture interfaces (MIPI > + CSI-2 RX, HDMI RX, ...) and display engine outputs for writeback support. > + > +properties: > + compatible: > + enum: > + - fsl,imx8mn-isi > + - fsl,imx8mp-isi > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: The AXI clock > + - description: The APB clock > + # TODO: Check if the per-channel ipg_proc_clk clocks need to be specified > + # as well, in case some SoCs have the ability to control them separately. > + # This may be the case of the i.MX8[DQ]X(P) > + > + clock-names: > + items: > + - const: axi > + - const: apb > + > + fsl,blk-ctrl: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + A phandle referencing the block control that contains the CSIS to ISI > + gasket. > + > + interrupts: true Need generic constraints - min/maxItems. > + > + power-domains: true Ditto. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: | > + Ports represent the Pixel Link inputs to the ISI. Their number and > + assignment are model-dependent. Each port shall have a single endpoint. > + > + patternProperties: > + "^port@[0-9]$": > + $ref: /schemas/graph.yaml#/properties/port > + unevaluatedProperties: false > + > + unevaluatedProperties: false At least one port is always required? > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - fsl,blk-ctrl > + - ports > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8mn-isi > + then: > + properties: > + interrupts: > + maxItems: 1 > + ports: > + properties: > + port@0: > + description: MIPI CSI-2 RX > + required: > + - port@0 > + > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8mp-isi > + then: > + properties: > + interrupts: > + maxItems: 2 You need to describe the items. Best regards, Krzysztof