From: "Nuno Sá" <noname.nuno@gmail.com>
To: Mark Brown <broonie@kernel.org>, Nuno Sa <nuno.sa@analog.com>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 4/4] ASoC: codecs: adau1373: add powerdown gpio
Date: Tue, 22 Oct 2024 08:39:49 +0200 [thread overview]
Message-ID: <d8bd85955bc5051f50b473028698f1c9d6b802ce.camel@gmail.com> (raw)
In-Reply-To: <7a8b1560-c091-4e87-a6f4-7ca7453b7414@sirena.org.uk>
On Mon, 2024-10-21 at 16:30 +0100, Mark Brown wrote:
> On Mon, Oct 21, 2024 at 03:46:48PM +0200, Nuno Sa wrote:
> > If the powerdown GPIO is specified, we use it for reset. Otherwise,
> > fallback to a software reset.
>
> Ideally we'd also put the device into reset when we unload, but that's
> not essential.
Alright... I can do a v2 with that. Will just wait for some more feedback on the
rest.
- Nuno Sá
prev parent reply other threads:[~2024-10-22 6:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 13:46 [PATCH 0/4] ASoC: codecs: adau1373: drop platform data Nuno Sa
2024-10-21 13:46 ` [PATCH 1/4] ASoC: codecs: adau1373: add some kconfig text Nuno Sa
2024-10-21 13:46 ` [PATCH 2/4] ASoC: dt-bindings: document the adau1373 Codec Nuno Sa
2024-10-22 6:06 ` Krzysztof Kozlowski
2024-10-22 6:42 ` Nuno Sá
2024-10-26 18:14 ` Krzysztof Kozlowski
2024-10-28 14:10 ` Nuno Sá
2024-10-21 13:46 ` [PATCH 3/4] ASoC: codecs: adau1373: drop patform_data Nuno Sa
2024-10-21 13:46 ` [PATCH 4/4] ASoC: codecs: adau1373: add powerdown gpio Nuno Sa
2024-10-21 15:30 ` Mark Brown
2024-10-22 6:39 ` Nuno Sá [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8bd85955bc5051f50b473028698f1c9d6b802ce.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).