Re: [PATCH v6 4/5] ARM: dts: imx6sx: Add LDB support

[Marek Vasut <marex@denx.de>]

On 5/22/23 22:14, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> i.MX6SX has an LVDS controller that is connected to the eLCDIF.
> 
> Add support for it.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v5:
> - Dropped fsl,imx6q-iomuxc-gpr" and "reg-names" (Marek).
> 
>   arch/arm/boot/dts/imx6sx.dtsi | 43 ++++++++++++++++++++++++++++++++---
>   1 file changed, 40 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 4233943a1cca..8dd38107bed2 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -841,10 +841,39 @@ iomuxc: pinctrl@20e0000 {
>   				reg = <0x020e0000 0x4000>;
>   			};
>   
> -			gpr: iomuxc-gpr@20e4000 {
> -				compatible = "fsl,imx6sx-iomuxc-gpr",
> -					     "fsl,imx6q-iomuxc-gpr", "syscon";
> +			gpr: syscon@20e4000 {
> +				compatible = "fsl,imx6sx-iomuxc-gpr", "syscon";
> +				#address-cells = <1>;
> +				#size-cells = <1>;
>   				reg = <0x020e4000 0x4000>;
> +
> +				lvds_bridge: bridge@18 {
> +					compatible = "fsl,imx6sx-ldb";
> +					reg = <0x18 0x4>;
> +					clocks = <&clks IMX6SX_CLK_LDB_DI0>;
> +					clock-names = "ldb";

Since there is only once clock, is this clock-names even needed ?