* [PATCH v1] dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS
@ 2024-06-27 21:17 Johan Jonker
2024-06-28 7:27 ` Krzysztof Kozlowski
2024-07-04 18:01 ` Heiko Stuebner
0 siblings, 2 replies; 5+ messages in thread
From: Johan Jonker @ 2024-06-27 21:17 UTC (permalink / raw)
To: heiko
Cc: mturquette, sboyd, robh, krzk+dt, conor+dt, linux-clk, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
CLK_NR_CLKS should not be part of the binding.
Remove since the kernel code no longer uses it.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
include/dt-bindings/clock/rk3188-cru-common.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/dt-bindings/clock/rk3188-cru-common.h b/include/dt-bindings/clock/rk3188-cru-common.h
index afad90680fce..01e14ab252a7 100644
--- a/include/dt-bindings/clock/rk3188-cru-common.h
+++ b/include/dt-bindings/clock/rk3188-cru-common.h
@@ -132,8 +132,6 @@
#define HCLK_VDPU 472
#define HCLK_HDMI 473
-#define CLK_NR_CLKS (HCLK_HDMI + 1)
-
/* soft-reset indices */
#define SRST_MCORE 2
#define SRST_CORE0 3
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1] dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS
2024-06-27 21:17 [PATCH v1] dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS Johan Jonker
@ 2024-06-28 7:27 ` Krzysztof Kozlowski
2024-06-28 8:13 ` Heiko Stübner
2024-07-04 18:01 ` Heiko Stuebner
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-28 7:27 UTC (permalink / raw)
To: Johan Jonker, heiko
Cc: mturquette, sboyd, robh, krzk+dt, conor+dt, linux-clk, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
On 27/06/2024 23:17, Johan Jonker wrote:
> CLK_NR_CLKS should not be part of the binding.
> Remove since the kernel code no longer uses it.
Please wrap neither too early nor over the limit. Not one sentence per line.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> include/dt-bindings/clock/rk3188-cru-common.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/dt-bindings/clock/rk3188-cru-common.h b/include/dt-bindings/clock/rk3188-cru-common.h
> index afad90680fce..01e14ab252a7 100644
> --- a/include/dt-bindings/clock/rk3188-cru-common.h
> +++ b/include/dt-bindings/clock/rk3188-cru-common.h
> @@ -132,8 +132,6 @@
> #define HCLK_VDPU 472
> #define HCLK_HDMI 473
>
> -#define CLK_NR_CLKS (HCLK_HDMI + 1)
I still see it as being used in linux-next. Some explanation is missing.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS
2024-06-28 7:27 ` Krzysztof Kozlowski
@ 2024-06-28 8:13 ` Heiko Stübner
2024-06-28 8:22 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Heiko Stübner @ 2024-06-28 8:13 UTC (permalink / raw)
To: Johan Jonker, Krzysztof Kozlowski
Cc: mturquette, sboyd, robh, krzk+dt, conor+dt, linux-clk, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
Hi Krzysztof,
Am Freitag, 28. Juni 2024, 09:27:14 CEST schrieb Krzysztof Kozlowski:
> On 27/06/2024 23:17, Johan Jonker wrote:
> > CLK_NR_CLKS should not be part of the binding.
> > Remove since the kernel code no longer uses it.
>
> Please wrap neither too early nor over the limit. Not one sentence per line.
>
>
>
> >
> > Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> > ---
> > include/dt-bindings/clock/rk3188-cru-common.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/include/dt-bindings/clock/rk3188-cru-common.h b/include/dt-bindings/clock/rk3188-cru-common.h
> > index afad90680fce..01e14ab252a7 100644
> > --- a/include/dt-bindings/clock/rk3188-cru-common.h
> > +++ b/include/dt-bindings/clock/rk3188-cru-common.h
> > @@ -132,8 +132,6 @@
> > #define HCLK_VDPU 472
> > #define HCLK_HDMI 473
> >
> > -#define CLK_NR_CLKS (HCLK_HDMI + 1)
>
> I still see it as being used in linux-next. Some explanation is missing.
I think me applying Johan's patch [0] removing the constant's usage, simply
overlapped with yesterday's next-creation.
[0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=for-next&id=ec2265dc91307622e43a7d602c3ea425da6f5de1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS
2024-06-28 8:13 ` Heiko Stübner
@ 2024-06-28 8:22 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-28 8:22 UTC (permalink / raw)
To: Heiko Stübner, Johan Jonker
Cc: mturquette, sboyd, robh, krzk+dt, conor+dt, linux-clk, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
On 28/06/2024 10:13, Heiko Stübner wrote:
> Hi Krzysztof,
>
> Am Freitag, 28. Juni 2024, 09:27:14 CEST schrieb Krzysztof Kozlowski:
>> On 27/06/2024 23:17, Johan Jonker wrote:
>>> CLK_NR_CLKS should not be part of the binding.
>>> Remove since the kernel code no longer uses it.
>>
>> Please wrap neither too early nor over the limit. Not one sentence per line.
>>
>>
>>
>>>
>>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>>> ---
>>> include/dt-bindings/clock/rk3188-cru-common.h | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/include/dt-bindings/clock/rk3188-cru-common.h b/include/dt-bindings/clock/rk3188-cru-common.h
>>> index afad90680fce..01e14ab252a7 100644
>>> --- a/include/dt-bindings/clock/rk3188-cru-common.h
>>> +++ b/include/dt-bindings/clock/rk3188-cru-common.h
>>> @@ -132,8 +132,6 @@
>>> #define HCLK_VDPU 472
>>> #define HCLK_HDMI 473
>>>
>>> -#define CLK_NR_CLKS (HCLK_HDMI + 1)
>>
>> I still see it as being used in linux-next. Some explanation is missing.
>
> I think me applying Johan's patch [0] removing the constant's usage, simply
> overlapped with yesterday's next-creation.
>
These should be sent in one patchset, which makes it obvious. Splitting
does not help...
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS
2024-06-27 21:17 [PATCH v1] dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS Johan Jonker
2024-06-28 7:27 ` Krzysztof Kozlowski
@ 2024-07-04 18:01 ` Heiko Stuebner
1 sibling, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2024-07-04 18:01 UTC (permalink / raw)
To: Johan Jonker
Cc: Heiko Stuebner, linux-kernel, robh, linux-rockchip,
linux-arm-kernel, krzk+dt, linux-clk, sboyd, mturquette,
devicetree, conor+dt
On Thu, 27 Jun 2024 23:17:45 +0200, Johan Jonker wrote:
> CLK_NR_CLKS should not be part of the binding.
> Remove since the kernel code no longer uses it.
>
>
Applied, thanks!
[1/1] dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS
commit: d89e8096957e35742c9922d3f6628f24de0d6163
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-04 18:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-27 21:17 [PATCH v1] dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS Johan Jonker
2024-06-28 7:27 ` Krzysztof Kozlowski
2024-06-28 8:13 ` Heiko Stübner
2024-06-28 8:22 ` Krzysztof Kozlowski
2024-07-04 18:01 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).