From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C9DBC433F5 for ; Tue, 26 Apr 2022 07:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239008AbiDZH1N (ORCPT ); Tue, 26 Apr 2022 03:27:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240910AbiDZH1M (ORCPT ); Tue, 26 Apr 2022 03:27:12 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E407EAF1C5 for ; Tue, 26 Apr 2022 00:24:02 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id w1so30316675lfa.4 for ; Tue, 26 Apr 2022 00:24:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=eXtqXcAbsPLbhUnLplLAUrfp7LOU/SjKEif65DdFddY=; b=RjT5NS3KcY2orNbvmBSpXy1jJ8Ow9Y+AEZGN5UeedbFepPo9eZYSsJBrlk+M5HbJgJ N9/gQJO/jn2vJt3H27RywyKgpVpMjjxP76plx+pwErzZgekg2SR3fJktjch6jQEAyYoE XnGIoDJ7jlYs1Su26aGwLO5ks+T+Alz8JBMY2PmQujoa1NedM7TLmMNxOdL5DQb755Eh Wu4waf+E4G1JenQAveLgZUHXprIGoPTTMiULWL020YzzUsewq3RMcVi8q9jwNe0X8Tf0 nEELfrh4YxZUGX9MNR1JQv1Ps1h098fC7rfWAiCL/vvtTFKlkDKnCWDGCN9vRUDHRxNc 9m8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=eXtqXcAbsPLbhUnLplLAUrfp7LOU/SjKEif65DdFddY=; b=vMcnSoWvaLmfw7IwUeUvH/7g7VqK1iQ53pssLww6HSTvF+K209JMACLlAsEEs9imKw H/El+LaCmAMeBhJcEcAH3EJElAZc6QLisbaKqcssP6enczjczQ2/vNyiovYkwa2Uswcb GzI/D+xpZAXkG4yoIqxkt4RrMJLQHff3WiXflZdLJ4YRu2iu2Rnh9O0YPH7l+5z+EPGv ZvvuCGZ44L746APoWaJG4G0LGyCJF20el0f0Y+aItHiL/jponuPAfhMD4QWaXKnwGnP1 FEBw57VO/qJrR48zQOwu60zxuA0Fa7Myts0ZYtBFKBfcKbZd1e2Dn3U3jFAWV0YCgMtm hQFA== X-Gm-Message-State: AOAM531CRe9wtdfFaFnBRlYBBTG7uzf0qTh9r86az4LRfZysKRODh45n iPF/g0NJ2hzU/KC9WnFFk1J9Ng== X-Google-Smtp-Source: ABdhPJwsG0y9iB+agiH1tnKpqhvSRk36yyN2InhyHQ8i1YlREGRjoX7xFZzC3EusBEs84fst8AhOgA== X-Received: by 2002:ac2:5e9c:0:b0:471:eba5:afe with SMTP id b28-20020ac25e9c000000b00471eba50afemr13348036lfq.477.1650957840955; Tue, 26 Apr 2022 00:24:00 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id y15-20020a056512044f00b004721549b9c2sm176712lfk.219.2022.04.26.00.24.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 00:24:00 -0700 (PDT) Message-ID: Date: Tue, 26 Apr 2022 10:23:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible and split apq8084 Content-Language: en-GB To: Krzysztof Kozlowski , Bjorn Andersson , Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Taniya Das , Ansuel Smith , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring References: <20220425204001.710238-1-krzysztof.kozlowski@linaro.org> From: Dmitry Baryshkov In-Reply-To: <20220425204001.710238-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/04/2022 23:40, Krzysztof Kozlowski wrote: > The qcom,gcc-apq8064.yaml was meant to describe only APQ8064 and APQ8084 > should have slightly different bindings (without Qualcomm thermal sensor > device). > > Fixes: a469bf89a009 ("dt-bindings: clock: simplify qcom,gcc-apq8064 Documentation") > Reported-by: Rob Herring > Signed-off-by: Krzysztof Kozlowski I think we can simply move it to the gcc-other.yaml. I'll send a patch. > --- > .../bindings/clock/qcom,gcc-apq8064.yaml | 4 +- > .../bindings/clock/qcom,gcc-apq8084.yaml | 42 +++++++++++++++++++ > 2 files changed, 43 insertions(+), 3 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml > index 97936411b6b4..9fafcb080069 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml > @@ -20,12 +20,10 @@ description: | > See also: > - dt-bindings/clock/qcom,gcc-msm8960.h > - dt-bindings/reset/qcom,gcc-msm8960.h > - - dt-bindings/clock/qcom,gcc-apq8084.h > - - dt-bindings/reset/qcom,gcc-apq8084.h > > properties: > compatible: > - const: qcom,gcc-apq8084 > + const: qcom,gcc-apq8064 > > nvmem-cells: > minItems: 1 > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml > new file mode 100644 > index 000000000000..63d08e82b3d8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,gcc-apq8084.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Global Clock & Reset Controller Binding for APQ8084 > + > +maintainers: > + - Stephen Boyd > + - Taniya Das > + > +description: | > + Qualcomm global clock control module which supports the clocks, resets and > + power domains on APQ8064/APQ8084. > + > + See also:: > + - dt-bindings/clock/qcom,gcc-apq8084.h > + - dt-bindings/reset/qcom,gcc-apq8084.h > + > +allOf: > + - $ref: qcom,gcc.yaml# > + > +properties: > + compatible: > + const: qcom,gcc-apq8084 > + > +required: > + - compatible > + > +unevaluatedProperties: false > + > +examples: > + - | > + clock-controller@fc400000 { > + compatible = "qcom,gcc-apq8084"; > + reg = <0xfc400000 0x4000>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + }; > +... -- With best wishes Dmitry