From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B5CB2E11A6 for ; Thu, 9 Oct 2025 12:52:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760014381; cv=none; b=J04m8gSpXPAtoW5kylww1olmnlBaBO0znr0yqM98jT0LVjw+tweuqGFoarrQ5H12R+ctGdzk70eoDu2p1Jb7+a64IUuM1D+vQtyCQFQkRuI5/APOXtIS3IeYqYb7twgPmpgsKNf6GUgMN2vTLHafiwl725woalBMzBSg4JTlg30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760014381; c=relaxed/simple; bh=oHmAYYmBYTRgLg0G9VZWm0tEmWvRwHCDyhkyoHqAr5s=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=kEnI+2mbmOy5EXglFaXw28KAxAoooel7nSaZUnZKR3f4MC3wZQgvbWzC5RgwQrSFM/+GfjmiVtNlQC45aMj/8gx0Fml57hJ58qv4XqfuvtVWmHZnHGdlcs71sh2t+auBxO+CrVoL3Mwm5kK0fQ5qaUfV7GQ3yI50Jq/DKSDCpUI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rtfwD2fi; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rtfwD2fi" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-46e2e363118so8022925e9.0 for ; Thu, 09 Oct 2025 05:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760014378; x=1760619178; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=ZRtylrFTnY/RG87DO6cfv9SyY42tBE2nSVvu8MAsJcY=; b=rtfwD2fir4E5htRQ1iMTydGys7Dw1iA1UwnC1gdYsE0IpGRMHt7zdXqdAvng4T8bh/ S6Qqb19rsxe7/A5cAADl56rHLpBh51GjyTnCC2GCwW8/IxlzlwjO6vEWJIkKxGjCqFSp lu5y0gFQXizLySgqel1BXkOPpkUFsckJ5GCj9xu9IUqod5oVDgjA6fsY45iHzE7LHWe9 8f7BZYS1kNK008neqLZZ4IbSSSKRgJJ/UVv1c7kSUrL/+sesTO9EMI3OjILtoQE9LcXt Gtw1IEJf31HgiU2xGWAQrdRwj6qGtktCkv/guORzvpuIYEUKruuBE5zqAn8K13l59wIb GLTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760014378; x=1760619178; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZRtylrFTnY/RG87DO6cfv9SyY42tBE2nSVvu8MAsJcY=; b=rjICd0rk6aWtJsQqc6FfqrJCOVHr6ELFzfk9PK7xkLJjR9MsDGXkTSeG1pRv9xFWTY zqcszR66nB/gJjO5dGactGUvHiHAVfuuailWNP72R/zYgwfG52IbtJPLy594wD7wDJdy pXPqWuIxYcFxx36Ozge7SvbN+ZlcAcydjF4elxKxlJbIn6GBABmh8KgWJN7rYvw4zaMS r1UDIyVPIbg+d9foP/jW32aMuFwHm49qGpWLK6ZXnHRvveyXlOw0ZqwR3VmotXBqJdPe GjwciRC2HjqoAinDrfgIgS8ebBRyUxw0ZANvvvkSvUBYbBCjFVWHXzhE8f/GUTD1+eK0 JWjw== X-Forwarded-Encrypted: i=1; AJvYcCVzXtks+jQLROLzg0EXVu2odxslNM2rp3m+E6KVHNYjpLYLh9xV9RFCp6fPX4YtfIQZM2qqQrTCK5/P@vger.kernel.org X-Gm-Message-State: AOJu0Yx9N8SBPAbV0q+Leeg0sylk7xk3P3oxfOBGZ/T9PGYlAMRXYeNf 8dO+vs839w3xB3koQshqIGjBBvFE8gjF85wgjMYrA2Ac2P7NcT8kE001S2/YxNFKc34= X-Gm-Gg: ASbGncs+KljhtRXJsAO5Z73QFB/EonOwpTjGu5RLebkqofUXd/jNIMCw49H1eKH4A7/ ABn5qjESGcLQoxjZYRiYuJjS51gN1Ap+vf9D+9YiTdE9epbyO6V+JMhlztTu66J3O+fEERs5JZk H5JbMeVh+0Ul4qxCGBXd++cdYTOlRVYJ42vil5248VJl2OJERnbSV2l92eELoHPyatxJ5k1rLp+ 5YwJpFrIY6iXjAVaAyXJEsiMukkt65LOI2Tf19t6uiHUUTEEgy4aRhlUyU3gdJLlAcOkaF1VEo7 j4wggtt0wh7ZqqXEVTn4KZo5YU/AAEp3XBou2rseVbmJ2ZmgsvjFGuoZxnLZQ87HjhP85CIgktE F7Tvi5mz591LlZ7gNWTWDmAbgNiUuk8F+SKtO0mxwFbOotHbMhI0iwDi/rf2GMSUXcASRx93Xvq s/inRHAJlif5+LtOHg637Bioao8WfwvKjhwhpy+A== X-Google-Smtp-Source: AGHT+IGRW0VgRpdPRqZKnwEt2a74cE0bxiKcQVyqAB6CmaLRieyQoIUZBI/ty0xAJli/ZygNnj4dqA== X-Received: by 2002:a05:6000:2504:b0:3eb:d906:e553 with SMTP id ffacd0b85a97d-4266e8e61dfmr4927007f8f.55.1760014377777; Thu, 09 Oct 2025 05:52:57 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:7a0c:da2f:6591:67ee? ([2a01:e0a:3d9:2080:7a0c:da2f:6591:67ee]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8a6daasm34964676f8f.7.2025.10.09.05.52.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Oct 2025 05:52:57 -0700 (PDT) Message-ID: Date: Thu, 9 Oct 2025 14:52:56 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH RFC v2 4/6] arm64: dts: qcom: sm8450-hdk: Enable I2S for HDMI To: Konrad Dybcio , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251008-topic-sm8x50-next-hdk-i2s-v2-0-6b7d38d4ad5e@linaro.org> <20251008-topic-sm8x50-next-hdk-i2s-v2-4-6b7d38d4ad5e@linaro.org> <488d9182-175e-47a9-9dc1-f43753d6fdbc@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <488d9182-175e-47a9-9dc1-f43753d6fdbc@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/9/25 14:37, Konrad Dybcio wrote: > On 10/8/25 8:56 PM, Neil Armstrong wrote: >> Add the necessary nodes to configure the right I2S interface >> to output audio via the DSI HDMI bridge. >> >> Signed-off-by: Neil Armstrong >> --- >> arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 26 +++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/sm8450.dtsi | 40 +++++++++++++++++++++++++++++++++ >> 2 files changed, 66 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >> index 0c6aa7ddf43263f30595b3f0733ec3e126e38608..7b822086a57c600ae9b5668d6d7a375d0ec55fa7 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >> @@ -667,6 +667,8 @@ lt9611_codec: hdmi-bridge@2b { >> pinctrl-names = "default"; >> pinctrl-0 = <<9611_irq_pin <9611_rst_pin>; >> >> + #sound-dai-cells = <1>; >> + >> ports { >> #address-cells = <1>; >> #size-cells = <0>; >> @@ -1016,6 +1018,14 @@ &sound { >> "TX SWR_INPUT0", "ADC3_OUTPUT", >> "TX SWR_INPUT1", "ADC4_OUTPUT"; >> >> + pinctrl-0 = <&i2s0_default_state>, <&audio_mclk0_default_state>; >> + pinctrl-names = "default"; >> + >> + clocks = <&q6prmcc LPASS_CLK_ID_PRI_MI2S_IBIT LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >> + <&q6prmcc LPASS_CLK_ID_MCLK_1 LPASS_CLK_ATTRIBUTE_COUPLE_NO>; >> + clock-names = "primart-mi2s", > > "primary-mi2s" > > [...] Damn typo > >> + audio_mclk0_default_state: audio-mclk0-default-state { >> + pins = "gpio125"; >> + function = "pri_mi2s"; >> + drive-strength = <8>; >> + bias-disable; >> + output-high; >> + }; >> + >> + i2s0_default_state: i2s0-default-state { >> + sck-pins { >> + pins = "gpio126"; >> + function = "mi2s0_sck"; >> + drive-strength = <8>; >> + bias-disable; >> + output-high; > > I doubt output-high for a clock pin is what you want.. This was copied from downstream: ================><============================ i2s0_sck_active: i2s0_sck_active { config { pins = "gpio126"; drive-strength = <8>; /* 8 mA */ bias-disable; /* NO PULL */ output-high; }; i2s0_ws_active: i2s0_ws_active { config { pins = "gpio129"; drive-strength = <8>; /* 8 mA */ bias-disable; /* NO PULL */ output-high; }; ================><============================ And also set the same way arch/arm64/boot/dts/qcom/sm4250.dtsi And I guess this level would only set when the function is not active. Neil > >> + }; >> + >> + data0-pins { >> + pins = "gpio127"; >> + function = "mi2s0_data0"; >> + drive-strength = <8>; >> + bias-disable; >> + }; >> + >> + data1-pins { >> + pins = "gpio128"; >> + function = "mi2s0_data1"; >> + drive-strength = <8>; >> + bias-disable; >> + }; >> + >> + ws-pins { >> + pins = "gpio129"; >> + function = "mi2s0_ws"; >> + drive-strength = <8>; >> + bias-disable; >> + output-high; > > here too > > Konrad