From: Marek Vasut <marex@denx.de>
To: Rob Herring <robh@kernel.org>
Cc: linux-i2c@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: at24: add ST M24C32-D Additional Write lockable page
Date: Thu, 12 Oct 2023 14:51:13 +0200 [thread overview]
Message-ID: <d8eefb50-dc68-4df2-9f7b-b2a90c6d89f1@denx.de> (raw)
In-Reply-To: <20231012115719.GA291445-robh@kernel.org>
On 10/12/23 13:57, Rob Herring wrote:
> On Tue, Oct 10, 2023 at 09:09:25PM +0200, Marek Vasut wrote:
>> The ST M24C32-D behaves as a regular M24C32, except for the -D variant
>> which uses up another I2C address for Additional Write lockable page.
>> This page is 32 Bytes long and can contain additional data. Document
>> compatible string for it, so users can describe that page in DT. Note
>> that users still have to describe the main M24C32 area separately as
>> that is on separate I2C address from this page.
>
> So 2 nodes for 1 device? Wouldn't it make more sense for the 1 node to
> have 2 addresses?
It would, if the 32 Byte Additional Write lockable page was somehow
related to the main area, but it doesn't seem to be, except that they
are both on single chip.
next prev parent reply other threads:[~2023-10-12 12:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 19:09 [PATCH 1/2] dt-bindings: at24: add ST M24C32-D Additional Write lockable page Marek Vasut
2023-10-10 19:09 ` [PATCH 2/2] eeprom: at24: add ST M24C32-D Additional Write lockable page support Marek Vasut
2023-10-12 9:28 ` Bartosz Golaszewski
2023-10-11 14:32 ` [PATCH 1/2] dt-bindings: at24: add ST M24C32-D Additional Write lockable page Conor Dooley
2023-10-11 14:36 ` Bartosz Golaszewski
2023-10-12 9:28 ` Bartosz Golaszewski
2023-10-12 11:57 ` Rob Herring
2023-10-12 12:51 ` Marek Vasut [this message]
2023-10-12 12:57 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8eefb50-dc68-4df2-9f7b-b2a90c6d89f1@denx.de \
--to=marex@denx.de \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).