devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, chrome-platform@lists.linux.dev,
	Julius Werner <jwerner@chromium.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: firmware: coreboot: Document optional device specific properties
Date: Wed, 19 Nov 2025 09:12:56 +0100	[thread overview]
Message-ID: <d8f3eb00-c7a6-425a-9e69-a01bc3532f0c@kernel.org> (raw)
In-Reply-To: <CAGXv+5EnfwRA1SMvt=3n7gj1gS3BndXKNVfmfkC=y6n2A3VsdA@mail.gmail.com>

On 19/11/2025 08:32, Chen-Yu Tsai wrote:
> On Wed, Nov 19, 2025 at 3:13 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 19/11/2025 08:11, Chen-Yu Tsai wrote:
>>> Coreboot, or the ChromeOS second stage bootloader, depthcharge, will
>>> insert device specific properties into the coreboot firmware node when
>>> there are valid values.
>>>
>>> Document these properties in the binding.
>>>
>>> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
>>> ---
>>>  Documentation/devicetree/bindings/firmware/coreboot.txt | 9 +++++++++
>>>  1 file changed, 9 insertions(+)
>>>
>>
>> TXT files cannot receive new properties. You need to first convert to DT
>> schema.
> 
> OK. Let me look into this.

After the conversion you will hit another problem - you need vendor
prefixes for these, because only generic properties can come without
them. Otherwise (without vendor prefix) these would define the type for
all other bindings, which probably is not what we want.

Best regards,
Krzysztof

  reply	other threads:[~2025-11-19  8:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19  7:11 [PATCH] dt-bindings: firmware: coreboot: Document optional device specific properties Chen-Yu Tsai
2025-11-19  7:13 ` Krzysztof Kozlowski
2025-11-19  7:32   ` Chen-Yu Tsai
2025-11-19  8:12     ` Krzysztof Kozlowski [this message]
2025-11-19  8:54       ` Chen-Yu Tsai
2025-11-19  9:26         ` Krzysztof Kozlowski
2025-11-19  9:36           ` Chen-Yu Tsai
2025-11-19 10:11             ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8f3eb00-c7a6-425a-9e69-a01bc3532f0c@kernel.org \
    --to=krzk@kernel.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jwerner@chromium.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).