From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: 20220614094956 created <yelian.wang@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
yaya.chang@mediatek.com, teddy.chen@mediatek.com,
hidenorik@chromium.org
Subject: Re: [PATCH 0/3] media: mediatek: Add support MT8188 AIE
Date: Wed, 17 Jul 2024 15:43:13 +0200 [thread overview]
Message-ID: <d90ef170-6c4c-4db2-9757-8e3f1cf46ec7@collabora.com> (raw)
In-Reply-To: <20240717125426.32660-1-yelian.wang@mediatek.com>
Il 17/07/24 14:41, 20220614094956 created ha scritto:
> From: Yelian Wang <yelian.wang@mediatek.com>
>
> *** BLURB HERE ***
>
> This patch series add YAML DT binding and V4L2 sub-device driver
> for mediatek MT8188 AIE. AIE is the ISP unit in the SoC，it's used
> to detect faces on an image stored in dram. Mainly used for the
> camera's Face Detection function of MT8188.
>
Leaving the fact that this driver is *far* from being upstream quality, there's
something missing that is essential for reviewers to even try to help you here.
What does this hardware do, in depth?
I get it, it's giving out "face detection" functionality, okay, but what are we
supposed to feed to it? An image? A stream? Encoded? Decoded? Size limitations?
What is it supposed to output?
An image? A stream? Polygons? With or without text?
....too many questions, and I'm afraid that this should not even be a V4L2 driver,
or a generous part of it should not, anyway... maybe.
With such a huge driver, you should at least provide an extensive overview of what
you are trying to implement and how the user(/kernel)-facing part is supposed to
work.
Regards,
Angelo
> This series is based on linux-next, tag: next-20240716
>
> Yelian Wang (3):
> media: dt-bindings: add MT8188 AIE
> uapi: linux: add MT8188 AIE
> media: mediatek: add MT8188 AIE driver
>
> .../bindings/media/mediatek-aie.yaml | 99 +
> drivers/media/platform/mediatek/Kconfig | 1 +
> drivers/media/platform/mediatek/Makefile | 1 +
> drivers/media/platform/mediatek/aie/Kconfig | 13 +
> drivers/media/platform/mediatek/aie/Makefile | 5 +
> drivers/media/platform/mediatek/aie/mtk_aie.h | 1012 +++++
> .../media/platform/mediatek/aie/mtk_aie_53.c | 2031 +++++++++
> .../media/platform/mediatek/aie/mtk_aie_drv.c | 3613 +++++++++++++++++
> include/uapi/linux/mtk_aie_v4l2_controls.h | 130 +
> include/uapi/linux/videodev2.h | 6 +
> 10 files changed, 6911 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek-aie.yaml
> create mode 100644 drivers/media/platform/mediatek/aie/Kconfig
> create mode 100644 drivers/media/platform/mediatek/aie/Makefile
> create mode 100644 drivers/media/platform/mediatek/aie/mtk_aie.h
> create mode 100644 drivers/media/platform/mediatek/aie/mtk_aie_53.c
> create mode 100644 drivers/media/platform/mediatek/aie/mtk_aie_drv.c
> create mode 100644 include/uapi/linux/mtk_aie_v4l2_controls.h
>
prev parent reply other threads:[~2024-07-17 13:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 12:41 [PATCH 0/3] media: mediatek: Add support MT8188 AIE 20220614094956 created
2024-07-17 12:41 ` [PATCH 1/3] media: dt-bindings: add " 20220614094956 created
2024-07-17 13:04 ` Krzysztof Kozlowski
2024-07-17 13:24 ` Krzysztof Kozlowski
2024-07-17 12:41 ` [PATCH 2/3] uapi: linux: " 20220614094956 created
2024-07-17 17:45 ` Nicolas Dufresne
2024-07-17 12:41 ` [PATCH 3/3] media: mediatek: add MT8188 AIE driver 20220614094956 created
2024-07-17 13:16 ` Krzysztof Kozlowski
2024-07-17 13:43 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d90ef170-6c4c-4db2-9757-8e3f1cf46ec7@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hidenorik@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=teddy.chen@mediatek.com \
--cc=yaya.chang@mediatek.com \
--cc=yelian.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).