From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD10C64ED9 for ; Tue, 21 Feb 2023 02:13:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232353AbjBUCNi (ORCPT ); Mon, 20 Feb 2023 21:13:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232246AbjBUCNh (ORCPT ); Mon, 20 Feb 2023 21:13:37 -0500 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C47B1A649 for ; Mon, 20 Feb 2023 18:13:35 -0800 (PST) Received: by mail-lj1-x22f.google.com with SMTP id b18so2938925ljr.4 for ; Mon, 20 Feb 2023 18:13:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AiW1Ta6IBbAqhmcXMDuesOeKjslnZyHw8cj0RcHsMpM=; b=q2n3pOcNSff0lmLUH6TzkO4y2Wbwsgs7VVt5p4KOyIs0+e00UIkUexaic4YPCWLnII QKdsQo0BQmEhQzFa1qX+A3zCO/El+bSe6gviIsJMUBJgsrNYhfQ55tsDYxt/iSgY3co3 2sFb4wrYsu5UkgyaR1PC+OrvNduvWQM4kPY9v8zXoZAxQH7Gxeq+c2Rb59P0QVSdGfha DH8iOrM2WPmuazOee6skUPCkYk7zLrzTWL2Qt00M1/rJMWqdRkSmFsOCgbVSnrsmAyZD X99DVVLFvrGkFt8hbjjn2faV+BbxoiOqDtANNkWPW4w/R2OYzlQkkavOv1m4vyBtCv15 27FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AiW1Ta6IBbAqhmcXMDuesOeKjslnZyHw8cj0RcHsMpM=; b=grMM5+XWGgmYBffjaaombUSTmK91YEBlsfCURAgBx3J7RRn5m4AV0GnT8XUD2zU40E 7p1AONuDzsCXMFCLH1W5M60XrEO+Yb4coAVYmINgDm/ew/MCEBMNfIkhf0XHzZ2+CROe P+Jp0FQpx3ZtjuBTQ/n0FI5WR54buHyPRX/6q9YfS1fs4pKgW9FLErDN6q3h4hv/WBhs ZZJ2O2K1mlL7IkD4CY77bT9E8fBweKL52OzS5EJRCZ7ElzoHycQsAFwLxoNiIhNuL286 rb1CVE4J6NGjpE8WhLdFN4JsDuzGDrENy72QGTP4ub0AOBk6QsmAsOEJ6uDpFae4Q+ZT xOdQ== X-Gm-Message-State: AO0yUKWnip0bzoxMCwlsmLHt+ZBxFaT4euvekkNiBsX8llEv2xeusJmK kQ2HrAoEZRyOi7hc6PAwkWv/MA== X-Google-Smtp-Source: AK7set8WttfIXgREx/DW//8k7URrt/2t6ghhms3MAPdLGVDin45jZVDbJmSbypfK9cYXpJfSL7m1WA== X-Received: by 2002:a2e:be07:0:b0:293:4bab:39c6 with SMTP id z7-20020a2ebe07000000b002934bab39c6mr1533436ljq.47.1676945613642; Mon, 20 Feb 2023 18:13:33 -0800 (PST) Received: from [192.168.1.101] (abxh184.neoplus.adsl.tpnet.pl. [83.9.1.184]) by smtp.gmail.com with ESMTPSA id e18-20020a2eb1d2000000b002934abfb109sm170466lja.45.2023.02.20.18.13.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 18:13:33 -0800 (PST) Message-ID: Date: Tue, 21 Feb 2023 03:13:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/2] dt-bindings: display/panel: Add Lenovo NT36523W BOE panel To: Rob Herring Cc: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Krzysztof Kozlowski , Neil Armstrong , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230217-topic-lenovo-panel-v1-0-9d7ee1602089@linaro.org> <20230217-topic-lenovo-panel-v1-1-9d7ee1602089@linaro.org> <20230221020859.GA818929-robh@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20230221020859.GA818929-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21.02.2023 03:08, Rob Herring wrote: > On Fri, Feb 17, 2023 at 12:29:07PM +0100, Konrad Dybcio wrote: >> Add bindings for the 2000x1200px IPS panel found on Lenovo Tab P11/ >> XiaoXin Pad devices. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../display/panel/lenovo,nt36523w-boe-j606.yaml | 60 ++++++++++++++++++++++ >> 1 file changed, 60 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/panel/lenovo,nt36523w-boe-j606.yaml b/Documentation/devicetree/bindings/display/panel/lenovo,nt36523w-boe-j606.yaml >> new file mode 100644 >> index 000000000000..43dcbe3f9f30 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/lenovo,nt36523w-boe-j606.yaml >> @@ -0,0 +1,60 @@ >> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/panel/lenovo,nt36523w-boe-j606.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NT36523W BOE panel found on Lenovo J606 devices >> + >> +maintainers: >> + - Konrad Dybcio >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + >> +properties: >> + compatible: >> + const: lenovo,nt36523w-boe-j606 >> + >> + reg: >> + maxItems: 1 >> + description: DSI virtual channel >> + >> + vddio-supply: true > > If only one supply, why not use panel-simple-dsi.yaml? Though probably > there's more than just an IO supply? Display regulators (AB/IBB/AMOLEDB, not to be confused with LAB/IBB) on modern Qualcomm platforms are controlled by the secure firmware layer (yes, you read that correctly). Some panels require additional supplies, but this one just has one positive, one negative and one I/O regulator. Konrad > > Rob