From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E65DB337B87; Mon, 8 Jun 2026 11:50:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780919442; cv=none; b=LCOoWMEYMhPw4UZAGbXv08hMFJ+j9LPS4TjfhjQGDs+NsUJWC/7xcrmKBgkZO2cyl83PjC5WV7P3uN7RazTpOGWdKrxpyfeO9HjkO/VzAqxycBfWmlIuEUPM7WXMT3PqK0K2S6PVDITCScZKStp0HOwq3K29/UhE2mCD6SOymLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780919442; c=relaxed/simple; bh=PW46KWxiznbKfcUciXDxvBGmhz7/kHyTsyVJeeWLqXQ=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=VOtrgfOq49CnjNi/ZzLMn7Ld+r3AkuXj/nmGhSGoqZ/K7oIX0ZO3sdOqoW3lekRobHtiCYcVyvmykMAmW1fzFfVqByNjwqR+SoPhi2YiXjAiYgC3RHu61Hb8LtQXJTkWOaYKhkpyZRLP+pZHP9HvSVsBJEO3Mh0Ko3xEWqh31nM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SWpg+Mlk; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SWpg+Mlk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD3231F00893; Mon, 8 Jun 2026 11:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780919441; bh=omxjQHGTvIZgymdUmYMZVSme4P4ErwqJYuWOeDyBKUU=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=SWpg+MlkJTvNqSJucABieZZIh37ifYXkEltcDUCDGtGH497I63JUq3/TcJ2WjWzhm ozrYdIymp/JM7Mxw09OOHzfu3Em0R8H+Llm8NE6YZd7DBTO8qYiywTaQaTbUSft25c V8Gml/VXfnr2bXVSxF9dOb4j7PINzTlv3sLYCG/f+BMI9RpDqjW9l2yUoIBTEhmGuu bq4HGzO7z87ietsg1iLQxy66ijT05WncaobiJ4CKOc5jqmDu5S3W8eysUFtTGUbyRt PSohtpsOjIVYAHysNNf7CSXiYync1Hnqe9A1s9rFXFufFFEHaGsTZx5ENpR5YLXYg2 roP8dE1YLAOAQ== Message-ID: Date: Mon, 8 Jun 2026 13:50:35 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn From: Krzysztof Kozlowski To: Biju Das , "biju.das.au" Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , "magnus.damm" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Prabhakar Mahadev Lad References: <20260602131331.90756-1-biju.das.jz@bp.renesas.com> <20260608-alluring-remarkable-echidna-d107ea@quoll> <6960d660-2851-44e3-af89-b334ab6cecc0@kernel.org> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <6960d660-2851-44e3-af89-b334ab6cecc0@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08/06/2026 13:46, Krzysztof Kozlowski wrote: > On 08/06/2026 13:22, Biju Das wrote: >> Hi Krzysztof Kozlowski, >> >>> -----Original Message----- >>> From: Krzysztof Kozlowski >>> Sent: 08 June 2026 12:11 >>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn >>> >>> On 08/06/2026 12:26, Biju Das wrote: >>>> Hi Krzysztof Kozlowski, >>>> >>>> Thanks for the feedback. >>>> >>>>> -----Original Message----- >>>>> From: Krzysztof Kozlowski >>>>> Sent: 08 June 2026 11:22 >>>>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required >>>>> for renesas,r9a08g046-lvds-cmn >>>>> >>>>> On 08/06/2026 12:20, Krzysztof Kozlowski wrote: >>>>>> On Tue, Jun 02, 2026 at 02:13:29PM +0100, Biju wrote: >>>>>>> From: Biju Das >>>>>>> >>>>>>> Add a conditional schema rule to the syscon bindings that requires >>>>>>> the ranges property when the compatible string contains >>>>>>> renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control >>>>>>> block on the RZ/G3L SoC correctly declares its address translation, >>>>>>> as the device has child nodes that need a valid ranges mapping to >>>>>>> be described in the device tree. >>>>>>> >>>>>>> Signed-off-by: Biju Das >>>>>>> --- >>>>>>> Documentation/devicetree/bindings/mfd/syscon.yaml | 14 >>>>>>> ++++++++++++++ >>>>>>> 1 file changed, 14 insertions(+) >>>>>>> >>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml >>>>>>> b/Documentation/devicetree/bindings/mfd/syscon.yaml >>>>>>> index 9c81010d5a74..cbf83a06ae25 100644 >>>>>>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml >>>>>>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml >>>>>>> @@ -269,6 +269,8 @@ properties: >>>>>>> resets: >>>>>>> maxItems: 1 >>>>>>> >>>>>>> + ranges: true >>>>>> >>>>>> There are no children allowed, so ranges property is wrong. >>>>>> >>>>>> You are changing binding which DOES NOT allow simple-mfd or any >>>>>> other children. Ranges is not a problem here. >>>>> >>>>> >>>>> And if you tested it on your DTS, you would see this does not work... >>>> >>>> I don't see any warnings or error. I have done this change based on >>>> Rob's comment based on sashiko review [1]. >>>> >>>> If you agree, I can drop this patch. >>>> >>>> [1] >>>> https://lore.kernel.org/all/20260601022619.GA3961324-robh@kernel.org/ >>> >>> Look: >>> https://lore.kernel.org/all/20260524194457.479681-2-biju.das.jz@bp.renesas.com/ >>> What compatibles are here? >>> >>> Now open the binding - what compatibles are allowed for renesas,r9a08g046-lvds-cmn ? >> >> OK, I am missing the fallbacks "simple-mfd", "syscon"; in the compatibles allowed >> for renesas,r9a08g046-lvds-cmn. >> >> OK, I will add those. > > No, maybe, dunno... How anything here could have been tested? dtbs_check > clearly points errors on your DTS. > You should re-do the commit 51284d8b1dbcd7fa0220c49eeab29b14617e0d88 because it is completely broken. This is schema for syscons, not devices with children. You added incomplete, incorrect binding having obvious dtbs_check failures which you would see if you validated DTS (never posted!!!). And you keep introducing more issues, by trying to fix non-existing issues while keeping the main problem - completely mismatched renesas,r9a08g046-lvds-cmn binding with reality unfixed. Best regards, Krzysztof