From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1 Date: Mon, 25 Jun 2018 06:15:35 -0700 Message-ID: References: <1529571737-3552-1-git-send-email-ludovic.Barre@st.com> <1529571737-3552-3-git-send-email-ludovic.Barre@st.com> <20180621165335.GA4563@roeck-us.net> <0bfe0082-2134-2d3b-322f-cd6c193a9974@st.com> <3f65a889-f625-9521-ea09-bcf7b5b24927@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Alexandre Torgue , Ludovic BARRE Cc: devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Maxime Coquelin , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 06/25/2018 05:52 AM, Alexandre Torgue wrote: > Hi Guenter, > > >>> But you are right I forgot to change stm32f429.dtsi. >>> If I add a commit for stm32f429.dtsi, it's Ok for you ? >>> >> >> Not really. You are imposing a personal preference on others, >> and you would make stm32f429.dtsi inconsistent since it doesn't >> use clock names for anything else.This in turn means that people >> will have an endless source of irritation since they will need >> a clock name for this node but not for others. > > Why? This kind of implementation depends on each driver. Isn't ? > > Or do you mean that if iwdg driver uses this implementation (clock name usage) all nodes inside stm32f429.dtsi should follow the same implementation ? > >> >> You will have to get the arm and DT maintainers to agree on this change. > > As this patch makes easier integration of new platform, I agree with Ludovic proposition. > Please provide a formal Acked-by:. Guenter