From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E92EC001DC for ; Wed, 26 Jul 2023 10:58:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233417AbjGZK6Z (ORCPT ); Wed, 26 Jul 2023 06:58:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232216AbjGZK6Y (ORCPT ); Wed, 26 Jul 2023 06:58:24 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB95DE69 for ; Wed, 26 Jul 2023 03:58:22 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-31765aee31bso2444858f8f.1 for ; Wed, 26 Jul 2023 03:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690369101; x=1690973901; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=69jj580P1DSe8cr6wdR9bzkleON+onBpdSJQbX0RqQQ=; b=abCtLTAHxzLZQx3yZP7Jwy4wSL5/u0dolDfq845g7zh8r+qohhm8WyQ+I08DytVAGW ov2RCtlAbso2q1msLc44f4Pn2L4C5m4OhY/FW+ucsvoB1+dYUb91WvHy+R+wdv67Hf99 VBFCnBwPuVvzZ14c8i5mauC35jRBgiU7bRl3jo52k8wT5YXoSarMnQbycr5BopNVsxeQ BmDlAe2ugU2cpcJWzqTLcpMks9xh/dyZZ5aAUFuKqteDD7iRu7C0mZeBL17G+KpOTtgt 2DEn4g5qMf3a6AKY7IRjhPtr9qEuNY3RHTNaW2qC8xRijyBvzM/cPoWyu0lT7cQ80ceb ntMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690369101; x=1690973901; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=69jj580P1DSe8cr6wdR9bzkleON+onBpdSJQbX0RqQQ=; b=j2Vop9xQ1Q49WW9Dw6T9PhudIyCQdsCCazxp3xFKrpELlqtfE257eGQQ1ORc0TX5C3 rx6TKawO2HKJ0YnhODC+Avy4Vny6JaFewSCgQGrTMCiKoWPkWjPyJqa279lEUHLX2T06 vPgRnL2aIVo4GmxLS/voGWrCNcKy2Yj7vXYH5A1Nq6MEWlbeBR9f3x72FQTJauMFa4op ZWQn6RJByEXQnBBnECo6H3wCx8UmhMCzO+XXhvDfVyiuqPYaM3lKQjg2Y6nlga9zU1y3 MKO+mDpjBJcJ3gslooQBIlEvn/rU1c24uOxwNzRPgVxK2lyIrnXk3FBMPjyjWkouStn1 mcjQ== X-Gm-Message-State: ABy/qLYBfslAtZDgRq0xH2LWFKU5THL9R1sAQPhFBz92jFZ24xGz3U37 aX1emu/gDFlLwamIbIUZQEsrRg== X-Google-Smtp-Source: APBJJlFuFExWjA3/qcQB/qgB2FxAoydz5gV11+BnboLGZNTKevsjTGJMa3597JykIshfwxKFQJTPDA== X-Received: by 2002:a5d:4450:0:b0:317:70cb:4f58 with SMTP id x16-20020a5d4450000000b0031770cb4f58mr997310wrr.63.1690369101230; Wed, 26 Jul 2023 03:58:21 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id r15-20020adff70f000000b003143ba62cf4sm19225643wrp.86.2023.07.26.03.58.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 03:58:20 -0700 (PDT) Message-ID: Date: Wed, 26 Jul 2023 11:58:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v7 3/6] media: starfive: camss: Add basic driver Content-Language: en-US To: Jack Zhu , Mauro Carvalho Chehab , Robert Foss , Todor Tomov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Laurent Pinchart , Hans Verkuil , Eugen Hristev , Ezequiel Garcia Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, changhuang.liang@starfivetech.com References: <20230619112838.19797-1-jack.zhu@starfivetech.com> <20230619112838.19797-4-jack.zhu@starfivetech.com> From: Bryan O'Donoghue In-Reply-To: <20230619112838.19797-4-jack.zhu@starfivetech.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/06/2023 12:28, Jack Zhu wrote: > Add basic platform driver for StarFive Camera Subsystem. Another nit here. "Add basic driver" isn't a great title. Recommend "Add core driver". Basic implies a thing that will be added to or improved upon but, this code here is your "core" interface where you do your probing and resource parsing/allocation etc. Use "core" not "basic" to describe this. --- bod