From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: matthew.gerlach@linux.intel.com, dinguyen@kernel.org,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000
Date: Wed, 4 May 2022 16:56:15 +0200 [thread overview]
Message-ID: <d9608f47-e70b-43bd-14a1-d03b2ca3b1a9@linaro.org> (raw)
In-Reply-To: <20220503194546.1287679-4-matthew.gerlach@linux.intel.com>
On 03/05/2022 21:45, matthew.gerlach@linux.intel.com wrote:
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>
> Add a device tree for the n6000 instantiation of Agilex
> Hard Processor System (HPS).
>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> +
> +&spi0 {
> + status = "okay";
> +
> + spidev: spidev@0 {
> + status = "okay";
> + compatible = "linux,spidev";
> + spi-max-frequency = <25000000>;
> + reg = <0>;
You should see big fat warnings - from checkpatch and when you boot your
device. This compatible is not accepted.
Please be sure you run checkpatch on your patches. Using reviewers time
instead of automated tool for the same job is discouraged...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-04 14:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 19:45 [PATCH v2 0/3] Add device tree for Intel n6000 matthew.gerlach
2022-05-03 19:45 ` [PATCH v2 1/3] dt-bindings: misc: add bindings for Intel HPS Copy Engine matthew.gerlach
2022-05-04 15:04 ` Krzysztof Kozlowski
2022-05-04 22:41 ` matthew.gerlach
2022-05-05 8:18 ` Krzysztof Kozlowski
2022-05-05 17:18 ` matthew.gerlach
2022-05-03 19:45 ` [PATCH v2 2/3] dt-bindings: intel: add binding for Intel n6000 matthew.gerlach
2022-05-04 14:54 ` Krzysztof Kozlowski
2022-05-04 21:09 ` matthew.gerlach
2022-05-03 19:45 ` [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000 matthew.gerlach
2022-05-04 14:56 ` Krzysztof Kozlowski [this message]
2022-05-04 21:14 ` matthew.gerlach
2022-05-04 15:02 ` Krzysztof Kozlowski
2022-05-04 21:22 ` matthew.gerlach
2022-05-05 6:42 ` Krzysztof Kozlowski
2022-05-05 17:16 ` matthew.gerlach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9608f47-e70b-43bd-14a1-d03b2ca3b1a9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).